From owner-svn-src-head@freebsd.org Thu Nov 24 16:27:23 2016 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id A665DC53569; Thu, 24 Nov 2016 16:27:23 +0000 (UTC) (envelope-from des@des.no) Received: from smtp.des.no (smtp.des.no [194.63.250.102]) by mx1.freebsd.org (Postfix) with ESMTP id 6FB4F1FA3; Thu, 24 Nov 2016 16:27:23 +0000 (UTC) (envelope-from des@des.no) Received: from desk.des.no (smtp.des.no [194.63.250.102]) by smtp.des.no (Postfix) with ESMTP id 8A2B6A375; Thu, 24 Nov 2016 16:27:16 +0000 (UTC) Received: by desk.des.no (Postfix, from userid 1001) id 780644E52; Thu, 24 Nov 2016 17:27:17 +0100 (CET) From: =?utf-8?Q?Dag-Erling_Sm=C3=B8rgrav?= To: Marcelo Araujo Cc: araujo@freebsd.org, src-committers@freebsd.org, svn-src-head@freebsd.org, svn-src-all@freebsd.org Subject: Re: svn commit: r309109 - head/lib/libutil References: <201611241450.uAOEoLA5079215@repo.freebsd.org> Date: Thu, 24 Nov 2016 17:27:17 +0100 In-Reply-To: (Marcelo Araujo's message of "Thu, 24 Nov 2016 23:27:52 +0800") Message-ID: <861sy0n8re.fsf@desk.des.no> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1 (berkeley-unix) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 24 Nov 2016 16:27:23 -0000 Marcelo Araujo writes: > We have code review, we have some many ways for communication, even > revert a commit if needed. No. This is the kind of mistake where the code will seem to work just fine and end up in a release before a user suddenly discovers that they have two instances of the same daemon running and trashing their data. If I remember correctly, the last time someone touched flopen(), everything worked except 'service mountd reload' stopped working. > Everybody can read the svn history. Yeah, but they don't. And before you say MAINTAINERS, they don't read or respect that either. Believe me, I have years of experience cleaning up after unapproved, unreviewed commits to code I maintain. Conversely, another committer once reverted a commit they had reviewed and approved because they thought I hadn't committed it and hit 'y' blindly when patch told them it was already applied. DES --=20 Dag-Erling Sm=C3=B8rgrav - des@des.no