From owner-svn-src-all@FreeBSD.ORG Tue Mar 20 14:36:13 2012 Return-Path: Delivered-To: svn-src-all@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 90AF01065670; Tue, 20 Mar 2012 14:36:13 +0000 (UTC) (envelope-from glebius@FreeBSD.org) Received: from cell.glebius.int.ru (glebius.int.ru [81.19.64.117]) by mx1.freebsd.org (Postfix) with ESMTP id 13E5F8FC0A; Tue, 20 Mar 2012 14:36:12 +0000 (UTC) Received: from cell.glebius.int.ru (localhost [127.0.0.1]) by cell.glebius.int.ru (8.14.5/8.14.5) with ESMTP id q2KEaBsv026135; Tue, 20 Mar 2012 18:36:11 +0400 (MSK) (envelope-from glebius@FreeBSD.org) Received: (from glebius@localhost) by cell.glebius.int.ru (8.14.5/8.14.5/Submit) id q2KEaBSD026134; Tue, 20 Mar 2012 18:36:11 +0400 (MSK) (envelope-from glebius@FreeBSD.org) X-Authentication-Warning: cell.glebius.int.ru: glebius set sender to glebius@FreeBSD.org using -f Date: Tue, 20 Mar 2012 18:36:11 +0400 From: Gleb Smirnoff To: Davide Italiano Message-ID: <20120320143611.GH30704@FreeBSD.org> References: <201203162032.q2GKWBRV033715@svn.freebsd.org> <20120319194431.GD30704@FreeBSD.org> MIME-Version: 1.0 Content-Type: text/plain; charset=koi8-r Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) Cc: svn-src-head@FreeBSD.org, George Neville-Neil , svn-src-all@FreeBSD.org, src-committers@FreeBSD.org Subject: Re: svn commit: r233045 - in head/sys: conf kern X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 20 Mar 2012 14:36:13 -0000 On Mon, Mar 19, 2012 at 09:06:36PM +0100, Davide Italiano wrote: D> >> These indented ifdefs look like a major violation of style used throughout D> >> the FreeBSD kernel code. Can you please keep with common style? D> >> D> > D> > Heh, D> > sorry, also Juli Mallet noticed this, I'm writing a fix for this and D> > after I'll have approval from my mentor I'll commit. Looks okay, apart from additional empty line in NOTES. Isn't single empty line enough? -- Totus tuus, Glebius.