From owner-freebsd-bugs@FreeBSD.ORG  Sat Jul  1 08:30:20 2006
Return-Path: <owner-freebsd-bugs@FreeBSD.ORG>
X-Original-To: freebsd-bugs@hub.freebsd.org
Delivered-To: freebsd-bugs@hub.freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 1AD2F16A4D4
	for <freebsd-bugs@hub.freebsd.org>;
	Sat,  1 Jul 2006 08:30:20 +0000 (UTC)
	(envelope-from gnats@FreeBSD.org)
Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 3AB3443D46
	for <freebsd-bugs@hub.freebsd.org>;
	Sat,  1 Jul 2006 08:30:19 +0000 (GMT)
	(envelope-from gnats@FreeBSD.org)
Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1])
	by freefall.freebsd.org (8.13.4/8.13.4) with ESMTP id k618UJAB073559
	for <freebsd-bugs@freefall.freebsd.org>; Sat, 1 Jul 2006 08:30:19 GMT
	(envelope-from gnats@freefall.freebsd.org)
Received: (from gnats@localhost)
	by freefall.freebsd.org (8.13.4/8.13.4/Submit) id k618UJ8v073558;
	Sat, 1 Jul 2006 08:30:19 GMT (envelope-from gnats)
Resent-Date: Sat, 1 Jul 2006 08:30:19 GMT
Resent-Message-Id: <200607010830.k618UJ8v073558@freefall.freebsd.org>
Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer)
Resent-To: freebsd-bugs@FreeBSD.org
Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org,
	KIYOHARA Takashi <kiyohara@netbsd.org>
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id CC26C16A403
	for <freebsd-gnats-submit@FreeBSD.org>;
	Sat,  1 Jul 2006 08:28:42 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from www.freebsd.org (www.freebsd.org [216.136.204.117])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 7C0CA43D48
	for <freebsd-gnats-submit@FreeBSD.org>;
	Sat,  1 Jul 2006 08:28:42 +0000 (GMT)
	(envelope-from nobody@FreeBSD.org)
Received: from www.freebsd.org (localhost [127.0.0.1])
	by www.freebsd.org (8.13.1/8.13.1) with ESMTP id k618SgMd090744
	for <freebsd-gnats-submit@FreeBSD.org>; Sat, 1 Jul 2006 08:28:42 GMT
	(envelope-from nobody@www.freebsd.org)
Received: (from nobody@localhost)
	by www.freebsd.org (8.13.1/8.13.1/Submit) id k618SgS9090743;
	Sat, 1 Jul 2006 08:28:42 GMT (envelope-from nobody)
Message-Id: <200607010828.k618SgS9090743@www.freebsd.org>
Date: Sat, 1 Jul 2006 08:28:42 GMT
From: KIYOHARA Takashi <kiyohara@netbsd.org>
To: freebsd-gnats-submit@FreeBSD.org
X-Send-Pr-Version: www-2.3
Cc: 
Subject: kern/99676: The strange expression in if_ural.c::ural_set_chan()
X-BeenThere: freebsd-bugs@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Bug reports <freebsd-bugs.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-bugs>,
	<mailto:freebsd-bugs-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-bugs>
List-Post: <mailto:freebsd-bugs@freebsd.org>
List-Help: <mailto:freebsd-bugs-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-bugs>,
	<mailto:freebsd-bugs-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sat, 01 Jul 2006 08:30:20 -0000


>Number:         99676
>Category:       kern
>Synopsis:       The strange expression in if_ural.c::ural_set_chan()
>Confidential:   no
>Severity:       serious
>Priority:       high
>Responsible:    freebsd-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Sat Jul 01 08:30:18 GMT 2006
>Closed-Date:
>Last-Modified:
>Originator:     KIYOHARA Takashi
>Release:        -current
>Organization:
>Environment:
>Description:
I look and think strange expression in if_ural.c::ural_set_chan().  I guess the "i<..." is an accident.

if_ural.c::ural_set_chan() ---

	/* dual-band RF */
	case RAL_RF_5222:
		for (i = 0; i < ural_rf5222[i].chan != chan; i++);
                           ^^^^^
		ural_rf_write(sc, RAL_RF1, ural_rf5222[i].r1);

--- if_ural.c::ural_set_chan()
>How-To-Repeat:

>Fix:

	/* dual-band RF */
	case RAL_RF_5222:
-		for (i = 0; i < ural_rf5222[i].chan != chan; i++);
+		for (i = 0; ural_rf5222[i].chan != chan; i++);

		ural_rf_write(sc, RAL_RF1, ural_rf5222[i].r1);

>Release-Note:
>Audit-Trail:
>Unformatted: