From owner-cvs-src@FreeBSD.ORG Sun Jan 2 19:33:56 2005 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id EABB116A4CE; Sun, 2 Jan 2005 19:33:56 +0000 (GMT) Received: from acampi.inet.it (acampi.inet.it [213.92.1.165]) by mx1.FreeBSD.org (Postfix) with ESMTP id AA0EC43D39; Sun, 2 Jan 2005 19:33:56 +0000 (GMT) (envelope-from andrea@acampi.inet.it) Received: by acampi.inet.it (Postfix, from userid 1000) id 4470FA7; Sun, 2 Jan 2005 20:33:55 +0100 (CET) Date: Sun, 2 Jan 2005 20:33:55 +0100 From: Andrea Campi To: Tim Kientzle Message-ID: <20050102193354.GC50060@webcom.it> References: <200501020521.j025LF68085390@repoman.freebsd.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200501020521.j025LF68085390@repoman.freebsd.org> User-Agent: Mutt/1.5.6i cc: cvs-src@FreeBSD.org cc: src-committers@FreeBSD.org cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/lib/libarchive Makefile archive.h.in archive_read_support_format_iso9660.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 02 Jan 2005 19:33:57 -0000 Hi, On Sun, Jan 02, 2005 at 05:21:15AM +0000, Tim Kientzle wrote: > First cut support for extracting from ISO9660 disk images. > This seems to be able to extract a TOC and extract files from > the couple of ISO images I've tested it with. > > Treat this as experimental proof-of-concept code for the > moment. There are still a bunch of debug messages (there > are a few oddities in ISO9660 that I haven't yet figured > out how to handle), a lot of bugs to be addressed (this > code leaks memory very badly), and a lot of missing features (no > Rockridge support, in particular). I'd appreciate > feedback from anyone who understands ISO9660 format > better than I do. ;-) I do appreciate your work on libarchive and bsdtar, and I'm very pleased we have a totally BSD clean tar. However, it's always been my understanding that doing development in the main repository was frowned upon. After all, that's the reason why there's a projects sub-repository. I fail to see the reason for committing this, or portability-only changes as you committed in the past, as a work-in-progress when you could have kept it somewhere else until such time as you were totally ready. Again: I like you work and I like this particular change, I'm mentioning it now because I've thought about this again and again in several instances. Bye, Andrea -- There's no place like ~