From owner-freebsd-audit Mon Jul 16 1:51:40 2001 Delivered-To: freebsd-audit@freebsd.org Received: from salmon.maths.tcd.ie (salmon.maths.tcd.ie [134.226.81.11]) by hub.freebsd.org (Postfix) with SMTP id 7798437B403 for ; Mon, 16 Jul 2001 01:51:38 -0700 (PDT) (envelope-from dwmalone@maths.tcd.ie) Received: from walton.maths.tcd.ie by salmon.maths.tcd.ie with SMTP id ; 16 Jul 2001 09:51:37 +0100 (BST) To: Mike Barcroft Cc: audit@FreeBSD.org Subject: Re: inetd(8) warns patch In-reply-to: Your message of "Mon, 16 Jul 2001 01:08:17 EDT." <200107160508.f6G58HF31122@coffee.q9media.com> X-Request-Do: Date: Mon, 16 Jul 2001 09:51:37 +0100 From: David Malone Message-ID: <200107160951.aa79104@salmon.maths.tcd.ie> Sender: owner-freebsd-audit@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG > I would appreciate your comments on the patch at the end of this > message. I'm not entirely sure about removing the legacy setproctitle > stuff. If you'd like to keep it in there, the prototype for main() > will need two versions. One for the legacy setproctitle and one > for normal use. Looks fine to me, as long as __unused is considered acceptable in our code. (I know you can get rid of the __unused for compilers that don't understand it by using a #define, but if another compiler denotes unused variables/parameters by "unused int blah;" then you can't generate this statement.) Would you like me to commit it? (I'm also slightly suprised that the WARNS flags don't whine about the nasty SWAP marco which contains a gccism.) BTW - I was looking at doing WARNS stuff for syslogd and it doesn't seem to be very easy 'cos syslogd uses writev(2) and iov_base pointers are of type "char *" not "const char *". I'm not subscribed to -audit so I don't know if anyone has a suggested workaround for these situations. David. To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-audit" in the body of the message