Date: Mon, 6 Apr 2020 18:08:11 +0200 From: Emanuel Haupt <ehaupt@FreeBSD.org> To: Mathieu Arnold <mat@freebsd.org> Cc: Emanuel Haupt <ehaupt@freebsd.org>, Alexey Dokuchaev <danfe@freebsd.org>, ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r530864 - head/audio/fasttracker2 Message-ID: <20200406180811.615ba361a285b49d60c332ce@FreeBSD.org> In-Reply-To: <20200406155336.bjshfwz7ueq5bjp2@aching.in.mat.cc> References: <202004060736.0367a5jk032226@repo.freebsd.org> <20200406123833.GA45635@FreeBSD.org> <20200406152927.64594364bfe06cd5be79d373@FreeBSD.org> <20200406155336.bjshfwz7ueq5bjp2@aching.in.mat.cc>
next in thread | previous in thread | raw e-mail | index | archive | help
Mathieu Arnold <mat@freebsd.org> wrote: > On Mon, Apr 06, 2020 at 03:29:27PM +0200, Emanuel Haupt wrote: > > Alexey Dokuchaev <danfe@freebsd.org> wrote: > > > On Mon, Apr 06, 2020 at 07:36:05AM +0000, Emanuel Haupt wrote: > > > > New Revision: 530864 > > > > URL: https://svnweb.freebsd.org/changeset/ports/530864 > > > > > > > > Log: > > > > - Restore accidentally removed Makefile header > > > > - Provide an option to build with pulseaudio > > > > > > > > ... > > > > @@ -29,14 +32,17 @@ DESKTOP_ENTRIES="FastTracker II" \ > > > > > > > > PLIST_FILES= bin/fasttracker2 > > > > share/pixmaps/ft2-clone.ico > > > > -OPTIONS_DEFINE= ALSA > > > > -OPTIONS_DEFAULT=ALSA > > > > +OPTIONS_DEFINE= ALSA PULSEAUDIO > > > > +OPTIONS_DEFAULT=ALSA PULSEAUDIO > > > > > > We typically do not enable PA by default in FreeBSD ports because > > > it's mainly Linuxish piece of software, unneeded under FreeBSD as > > > we have superior sound stack which offers similar, but better > > > placed and implemented functionality by itself. It may be > > > helpful in some bizarre edge case usage scenario (which justifies > > > having it as an OPTION), but for most users r530864 would pull > > > needless and often unwanted dependency. > > > > I'll keep that in mind for the next update (upstream has short > > release cycles). > > Hi, > > Unless upstream has a release cycle of a day, why not simply remove > PULSEAUDIO fron the OPTIONS_DEFAULT line and commit just that? r530886 done.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20200406180811.615ba361a285b49d60c332ce>