From owner-svn-ports-all@freebsd.org  Mon Apr  6 16:08:13 2020
Return-Path: <owner-svn-ports-all@freebsd.org>
Delivered-To: svn-ports-all@mailman.nyi.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1])
 by mailman.nyi.freebsd.org (Postfix) with ESMTP id 96BCA2B41C9;
 Mon,  6 Apr 2020 16:08:13 +0000 (UTC)
 (envelope-from ehaupt@FreeBSD.org)
Received: from smtp.freebsd.org (smtp.freebsd.org
 [IPv6:2610:1c1:1:606c::24b:4])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 server-signature RSA-PSS (4096 bits)
 client-signature RSA-PSS (4096 bits) client-digest SHA256)
 (Client CN "smtp.freebsd.org",
 Issuer "Let's Encrypt Authority X3" (verified OK))
 by mx1.freebsd.org (Postfix) with ESMTPS id 48wwSF3QmSz4FZL;
 Mon,  6 Apr 2020 16:08:13 +0000 (UTC)
 (envelope-from ehaupt@FreeBSD.org)
Received: from beaver (unknown [81.6.39.88])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client did not present a certificate) (Authenticated sender: ehaupt)
 by smtp.freebsd.org (Postfix) with ESMTPSA id 99181127EB;
 Mon,  6 Apr 2020 16:08:12 +0000 (UTC)
 (envelope-from ehaupt@FreeBSD.org)
Date: Mon, 6 Apr 2020 18:08:11 +0200
From: Emanuel Haupt <ehaupt@FreeBSD.org>
To: Mathieu Arnold <mat@freebsd.org>
Cc: Emanuel Haupt <ehaupt@freebsd.org>, Alexey Dokuchaev
 <danfe@freebsd.org>, ports-committers@freebsd.org,
 svn-ports-all@freebsd.org, svn-ports-head@freebsd.org
Subject: Re: svn commit: r530864 - head/audio/fasttracker2
Message-Id: <20200406180811.615ba361a285b49d60c332ce@FreeBSD.org>
In-Reply-To: <20200406155336.bjshfwz7ueq5bjp2@aching.in.mat.cc>
References: <202004060736.0367a5jk032226@repo.freebsd.org>
 <20200406123833.GA45635@FreeBSD.org>
 <20200406152927.64594364bfe06cd5be79d373@FreeBSD.org>
 <20200406155336.bjshfwz7ueq5bjp2@aching.in.mat.cc>
X-Mailer: Sylpheed 3.7.0 (GTK+ 2.24.32; amd64-portbld-freebsd12.0)
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
X-BeenThere: svn-ports-all@freebsd.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: SVN commit messages for the ports tree <svn-ports-all.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-ports-all>,
 <mailto:svn-ports-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-ports-all/>
List-Post: <mailto:svn-ports-all@freebsd.org>
List-Help: <mailto:svn-ports-all-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-ports-all>,
 <mailto:svn-ports-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 06 Apr 2020 16:08:13 -0000

Mathieu Arnold <mat@freebsd.org> wrote:
> On Mon, Apr 06, 2020 at 03:29:27PM +0200, Emanuel Haupt wrote:
> > Alexey Dokuchaev <danfe@freebsd.org> wrote:
> > > On Mon, Apr 06, 2020 at 07:36:05AM +0000, Emanuel Haupt wrote:
> > > > New Revision: 530864
> > > > URL: https://svnweb.freebsd.org/changeset/ports/530864
> > > > 
> > > > Log:
> > > >   - Restore accidentally removed Makefile header
> > > >   - Provide an option to build with pulseaudio
> > > > 
> > > > ...
> > > > @@ -29,14 +32,17 @@ DESKTOP_ENTRIES="FastTracker II" \
> > > >  
> > > >  PLIST_FILES=	bin/fasttracker2
> > > > share/pixmaps/ft2-clone.ico 
> > > > -OPTIONS_DEFINE=	ALSA
> > > > -OPTIONS_DEFAULT=ALSA
> > > > +OPTIONS_DEFINE=	ALSA PULSEAUDIO
> > > > +OPTIONS_DEFAULT=ALSA PULSEAUDIO
> > > 
> > > We typically do not enable PA by default in FreeBSD ports because
> > > it's mainly Linuxish piece of software, unneeded under FreeBSD as
> > > we have superior sound stack which offers similar, but better
> > > placed and implemented functionality by itself.  It may be
> > > helpful in some bizarre edge case usage scenario (which justifies
> > > having it as an OPTION), but for most users r530864 would pull
> > > needless and often unwanted dependency.
> > 
> > I'll keep that in mind for the next update (upstream has short
> > release cycles).
> 
> Hi,
> 
> Unless upstream has a release cycle of a day, why not simply remove
> PULSEAUDIO fron the OPTIONS_DEFAULT line and commit just that?

r530886 done.