From owner-svn-src-projects@FreeBSD.ORG Sat May 14 23:30:30 2011 Return-Path: Delivered-To: svn-src-projects@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 593471065688; Sat, 14 May 2011 23:30:30 +0000 (UTC) (envelope-from marius@alchemy.franken.de) Received: from alchemy.franken.de (alchemy.franken.de [194.94.249.214]) by mx1.freebsd.org (Postfix) with ESMTP id E2E7C8FC12; Sat, 14 May 2011 23:30:29 +0000 (UTC) Received: from alchemy.franken.de (localhost [127.0.0.1]) by alchemy.franken.de (8.14.4/8.14.4/ALCHEMY.FRANKEN.DE) with ESMTP id p4ENUSUU058440; Sun, 15 May 2011 01:30:28 +0200 (CEST) (envelope-from marius@alchemy.franken.de) Received: (from marius@localhost) by alchemy.franken.de (8.14.4/8.14.4/Submit) id p4ENUSlP058439; Sun, 15 May 2011 01:30:28 +0200 (CEST) (envelope-from marius) Date: Sun, 15 May 2011 01:30:28 +0200 From: Marius Strobl To: Attilio Rao Message-ID: <20110514233028.GF92688@alchemy.franken.de> References: <201105131521.p4DFLVKs074711@svn.freebsd.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.4.2.3i Cc: svn-src-projects@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r221842 - projects/largeSMP/sys/sparc64/sparc64 X-BeenThere: svn-src-projects@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the src " projects" tree" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 14 May 2011 23:30:30 -0000 On Fri, May 13, 2011 at 05:28:59PM +0200, Attilio Rao wrote: > 2011/5/13 Marius Strobl : > > Author: marius > > Date: Fri May 13 15:21:31 2011 > > New Revision: 221842 > > URL: http://svn.freebsd.org/changeset/base/221842 > > > > Log: > > ??When setting up pc_other_cpus for APs based on pc_allcpu clear pc_cpuid > > ??in the former rather than the latter. > > ??This gets this branch working on at least Jalapeno-class CPUs. > > > > Modified: > > ??projects/largeSMP/sys/sparc64/sparc64/mp_machdep.c > > > > Modified: projects/largeSMP/sys/sparc64/sparc64/mp_machdep.c > > ============================================================================== > > --- projects/largeSMP/sys/sparc64/sparc64/mp_machdep.c ??Fri May 13 15:20:57 2011 ?? ?? ?? ??(r221841) > > +++ projects/largeSMP/sys/sparc64/sparc64/mp_machdep.c ??Fri May 13 15:21:31 2011 ?? ?? ?? ??(r221842) > > @@ -470,7 +470,7 @@ cpu_mp_bootstrap(struct pcpu *pc) > > ?? ?? ?? ??smp_cpus++; > > ?? ?? ?? ??KASSERT(curthread != NULL, ("%s: curthread", __func__)); > > ?? ?? ?? ??ocpus = all_cpus; > > - ?? ?? ?? CPU_CLR(curcpu, &all_cpus); > > + ?? ?? ?? CPU_CLR(curcpu, &ocpus); > > ?? ?? ?? ??PCPU_SET(other_cpus, ocpus); > > ?? ?? ?? ??printf("SMP: AP CPU #%d Launched!\n", curcpu); > > > > > > How idiot can I be? > I watched that path like 10 times yesterday... > FYI, as of r221932 this branch now works MP on all three classes of Cheetah, Jalapeno and Spitfire CPUs. While working on this I noticed that there's a bit of room for improvement in the sparc64 IPI code, which I'll commit once this branch has been merged into head. Then I'll also add support for more than 32 CPUs in the MD part, both of which really are orthogonal to the cpuset_t conversion. Marius