From owner-freebsd-bugs@FreeBSD.ORG Tue Mar 3 15:40:04 2009 Return-Path: Delivered-To: freebsd-bugs@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 4FF4A1065672 for ; Tue, 3 Mar 2009 15:40:04 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id 3F5068FC0A for ; Tue, 3 Mar 2009 15:40:04 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) by freefall.freebsd.org (8.14.3/8.14.3) with ESMTP id n23Fe4oB086522 for ; Tue, 3 Mar 2009 15:40:04 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.3/8.14.3/Submit) id n23Fe4YJ086521; Tue, 3 Mar 2009 15:40:04 GMT (envelope-from gnats) Date: Tue, 3 Mar 2009 15:40:04 GMT Message-Id: <200903031540.n23Fe4YJ086521@freefall.freebsd.org> To: freebsd-bugs@FreeBSD.org From: Nick Sayer Cc: Subject: Re: kern/132273: glabel failing on journaled partition X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: Nick Sayer List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 03 Mar 2009 15:40:04 -0000 The following reply was made to PR kern/132273; it has been noted by GNATS. From: Nick Sayer To: bug-followup@FreeBSD.org Cc: Subject: Re: kern/132273: glabel failing on journaled partition Date: Tue, 3 Mar 2009 07:38:58 -0800 I haven't yet tried this, and I am not a geom internals expert, but might this be the fix? --- sys/geom/label/g_label.c.orig 2008-12-28 14:45:10.000000000 -0800 +++ sys/geom/label/g_label.c 2009-03-03 07:36:57.000000000 -0800 @@ -158,6 +158,8 @@ pp2 = LIST_FIRST(&gp->provider); if (pp2 == NULL) continue; + if (pp2->flags & G_PF_ORPHAN) + continue; if (strcmp(pp2->name, name) == 0) { G_LABEL_DEBUG(1, "Label %s(%s) already exists (%s).", label, name, pp->name);