From owner-freebsd-hackers@FreeBSD.ORG Mon Mar 1 19:52:49 2010 Return-Path: Delivered-To: freebsd-hackers@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id A4982106566C for ; Mon, 1 Mar 2010 19:52:49 +0000 (UTC) (envelope-from a_best01@uni-muenster.de) Received: from zivm-exrelay2.uni-muenster.de (ZIVM-EXRELAY2.UNI-MUENSTER.DE [128.176.192.15]) by mx1.freebsd.org (Postfix) with ESMTP id 2EA998FC1A for ; Mon, 1 Mar 2010 19:52:47 +0000 (UTC) X-IronPort-AV: E=Sophos;i="4.49,561,1262559600"; d="scan'208";a="237984660" Received: from zivmaildisp1.uni-muenster.de (HELO ZIVMAILUSER01.UNI-MUENSTER.DE) ([128.176.188.85]) by zivm-relay2.uni-muenster.de with ESMTP; 01 Mar 2010 20:52:46 +0100 Received: by ZIVMAILUSER01.UNI-MUENSTER.DE (Postfix, from userid 149459) id 92DA01B0768; Mon, 1 Mar 2010 20:52:46 +0100 (CET) Date: Mon, 01 Mar 2010 20:52:45 +0100 (CET) From: Alexander Best Sender: Organization: Westfaelische Wilhelms-Universitaet Muenster To: jhell Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: freebsd-hackers@freebsd.org Subject: Re: `make cleanworld` and /usr/obj/lib32/usr/src X-BeenThere: freebsd-hackers@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Technical Discussions relating to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 01 Mar 2010 19:52:49 -0000 jhell schrieb am 2010-03-01: > On Sun, 28 Feb 2010 11:54, alexbestms@ wrote: > >Gary Jennejohn schrieb am 2010-02-28: > >>On Sat, 27 Feb 2010 14:49:58 +0100 (CET) > >>Alexander Best wrote: > >>>how about something like this? > >>Based on a quick look it seems OK to me. > >>Have you tested it? > >i did. it works when `make cleanworld` is being run from /usr/src. > >i'm not > >sure however what the > >.if ${.CURDIR} == ${.OBJDIR} || ${.CURDIR}/obj == ${.OBJDIR} > >.if exists(${BW_CANONICALOBJDIR}/) > >statement is for so i didn't include the lib32 cleanup in that > >clause. my > >guess is that it's used to catch the case where `make cleanworld` > >is being run > >in /usr/obj/usr/src > You can't run make from a obj directory there is no Makefile, > Targets or spoons. ;) > This line here: > BW_CANONICALOBJDIR:=${MAKEOBJDIRPREFIX}${.CURDIR} > Allows the end-user to set MAKEOBJDIRPREFIX in their environment and > have the obj directory somewhere other than CANONICALOBJDIR. oh. and btw: wouldn't it be reasonable to prevent a user shooting himself in the foot if he has the brilliant idea of setting "MAKEOBJDIRPREFIX = /" ? alex > BW is an abbreviation for "buildworld". > >cheers. > >alex > >>--- > >>Gary Jennejohn > >_______________________________________________ > >freebsd-hackers@freebsd.org mailing list > >http://lists.freebsd.org/mailman/listinfo/freebsd-hackers > >To unsubscribe, send any mail to > >"freebsd-hackers-unsubscribe@freebsd.org" > -- > jhell