Date: Mon, 23 Mar 2015 14:52:46 -0500 From: Bryan Drewery <bdrewery@FreeBSD.org> To: Gerald Pfeifer <gerald@pfeifer.com>, Mathieu Arnold <mat@FreeBSD.org> Cc: Sunpoet Po-Chuan Hsieh <sunpoet@freebsd.org>, svn-ports-head@freebsd.org, svn-ports-all@freebsd.org, ports-committers@freebsd.org Subject: Re: svn commit: r381968 - head/lang/gcc5 Message-ID: <55106F0E.9090700@FreeBSD.org> In-Reply-To: <alpine.LSU.2.11.1503232038520.15042@tuna.site> References: <201503222311.t2MNBE8d075929@svn.freebsd.org> <CAMHz58SEVfiUsrz0f2dMVsvA-kL4e%2BTF2JcuzYBp7bPPEYsCow@mail.gmail.com> <551061EC.5090702@FreeBSD.org> <alpine.LSU.2.11.1503232038520.15042@tuna.site>
next in thread | previous in thread | raw e-mail | index | archive | help
This is an OpenPGP/MIME signed message (RFC 4880 and 3156)
--614lJWbNktcOgeQAs58ODClOwxo6hFNks
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: quoted-printable
On 3/23/2015 2:44 PM, Gerald Pfeifer wrote:
> On Mon, 23 Mar 2015, Bryan Drewery wrote:
>>> USE_LDCONFIG stores the directory name to
>>> ${LOCALBASE}/libdata/ldconfig/${UNIQUENAME}.
>>> Since lang/gcc* now share same PORTNAME (gcc), you need to
>>> set UNIQUENAME manually.
>> I just hit this. I've fixed it in r382022.
>=20
> Thanks for fixing this, Bryan, but...
>=20
> ...doesn't this point to a design problem with the infrastructure?
Definitely. I think UNIQUENAME is now really only used for USE_LDCONFIG.
It may make sense to default it to the values I put into the gcc ports.
>=20
> Mk/bsd.ports.mk says:
>=20
> # UNIQUENAME - A name for your port that is globally unique. By defa=
ult,
> # this is set to ${LATEST_LINK} when LATEST_LINK is set,=
> # and to ${PKGNAMEPREFIX}${PORTNAME} otherwise.
>=20
> # PKGNAMESUFFIX - Suffix to specify compilation options or a version
> # designator (in case there are different versions of=
> # one port as is the case for Tcl).
>=20
> If PKGNAMESUFFIX is used as Mat suggested (to carry a version number), =
> shouldn't it become part of UNIQUENAME? Can this be improved?
>=20
> If not, I guess I should just revert PORTNAME to gcc47, gcc48, and=20
> so forth. Using PKGNAMESUFFIX is not providing the expected benefit. =
> And things just are becoming more complex. :-(
>=20
> Gerald
>=20
--=20
Regards,
Bryan Drewery
--614lJWbNktcOgeQAs58ODClOwxo6hFNks
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="signature.asc"
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2
iQEcBAEBAgAGBQJVEG8OAAoJEDXXcbtuRpfP4HYH/jvJWElNm4S8u6aa8sS+qaKC
lb3V5PWzGPT+PjzXEqkY81PQ3fKIAqyqeIk62n64y/3Iuoeghg+en/K1TMgmAjFI
2/10+EDYqlumQaOimQV3BCZuqi/oDHHZid0CqoVRYuTcMj+OFf9jyqOsMAbpu8GE
OslDflDzBlLg3ROqRBdabZxiLp0AgbhfTRBtM8/XipQ0TstmIy+ZMDwlF9eXhzjG
B0AgmwkJ58d8kbqe1z/pcfwqSCZt3XUsnaADeDGFm+rVCeic4olILSQ05PTNf7tB
H3zHwOQ/lZ2rpntHE84eyhtC4VEqZZGCltOGStrvR6rUNgSxREL5OLh2R+EBWxM=
=Uf1B
-----END PGP SIGNATURE-----
--614lJWbNktcOgeQAs58ODClOwxo6hFNks--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?55106F0E.9090700>