From owner-svn-src-all@FreeBSD.ORG Fri Apr 27 13:55:43 2012 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id E255A106564A; Fri, 27 Apr 2012 13:55:43 +0000 (UTC) (envelope-from asmrookie@gmail.com) Received: from mail-lpp01m010-f54.google.com (mail-lpp01m010-f54.google.com [209.85.215.54]) by mx1.freebsd.org (Postfix) with ESMTP id C65B98FC0C; Fri, 27 Apr 2012 13:55:42 +0000 (UTC) Received: by lagv3 with SMTP id v3so690953lag.13 for ; Fri, 27 Apr 2012 06:55:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:date :x-google-sender-auth:message-id:subject:from:to:cc:content-type; bh=3befTjujDJv1D6peDyRdB6IjaR9KZ9BNxGVYJkGOiZg=; b=kge7SSPfm6YC0KKeJRx6dHd2n3Nr6FCXgrZV4hBzqam29Q95hTTTupkhJQc/LJJiz1 uSVefZj1SD4+Ai5o7OYQJZedAjwbx91sRNE1Un+LZU9rRh98s7K6IDE2OTv7bvecB3Ma bopBYNwly+0g0OOQVEUdWi7Dt1qJyn2R2HXNT0OBGFMurYcWLGVLCyMg9YlhPN0W6Vh7 eCkM3qMBajfG+cvLXyP5UserNvuN2ycNEQWwKKarM5ek85ZqUAQxtlE3rlYFXRk800XS /yBMkW8Rn3K5UjoqdfZJta9AaC4R6J8VeK60jN97ZFDml+Wfr3gQ4GJB2Hx7J9NbrA03 rgrQ== MIME-Version: 1.0 Received: by 10.152.132.166 with SMTP id ov6mr11624455lab.35.1335534941511; Fri, 27 Apr 2012 06:55:41 -0700 (PDT) Sender: asmrookie@gmail.com Received: by 10.112.63.146 with HTTP; Fri, 27 Apr 2012 06:55:41 -0700 (PDT) In-Reply-To: <201204270740.43912.jhb@freebsd.org> References: <201204262024.q3QKOPA6067287@svn.freebsd.org> <201204270740.43912.jhb@freebsd.org> Date: Fri, 27 Apr 2012 14:55:41 +0100 X-Google-Sender-Auth: 2fU5FgQhZ5KMu5J-0ESel8-wphY Message-ID: From: Attilio Rao To: John Baldwin Content-Type: text/plain; charset=UTF-8 Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r234723 - in head/sys: amd64/amd64 amd64/include i386/i386 i386/include pc98/pc98 sparc64/include sparc64/sparc64 x86/x86 X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 27 Apr 2012 13:55:44 -0000 2012/4/27, John Baldwin : > On Thursday, April 26, 2012 4:24:25 pm Attilio Rao wrote: >> Author: attilio >> Date: Thu Apr 26 20:24:25 2012 >> New Revision: 234723 >> URL: http://svn.freebsd.org/changeset/base/234723 >> >> Log: >> Clean up the intr* MD KPI from the SMP dependency, removing a cause of >> discrepancy between modules and kernel, but deal with SMP differences >> within the functions themselves. >> >> As an added bonus this also helps in terms of code readability. > > Hmm, this should not have affected anything with modules as no modules > should have ever called this. Also, making intr_bind() available for UP > kernels on x86 is largely pointless. It's only caller is already > conditional > in sys/x86/x86/nexus.c: It doesn't mean that there couldn't be an user in the future of this KPI in terms of thirdy part modules. These functions are part of the public KPI and we speak a lot about making our KPI as less as dependent by compiling options so I don't really see why you are not happy about this. If the function (intr_bind() included) is part of the public KPI it can be called by thirdy part modules too. Attilio -- Peace can only be achieved by understanding - A. Einstein