From owner-freebsd-ports@FreeBSD.ORG Mon Sep 17 16:59:10 2012 Return-Path: Delivered-To: ports@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 32445106573B; Mon, 17 Sep 2012 16:59:10 +0000 (UTC) (envelope-from mezz.freebsd@gmail.com) Received: from mail-ob0-f182.google.com (mail-ob0-f182.google.com [209.85.214.182]) by mx1.freebsd.org (Postfix) with ESMTP id D3EB98FC14; Mon, 17 Sep 2012 16:59:09 +0000 (UTC) Received: by obbun3 with SMTP id un3so11598548obb.13 for ; Mon, 17 Sep 2012 09:59:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=uAoV/RxbazzDovifoGt4cwi287lmZKH9RCED7+JiCK4=; b=QpMy5cFid34XZVqB3hthQkNzAGryTKmsqlIZVWb86RWDlSSlfjC2GS9U+dTuhnRwR6 9B+bwKfWR07DjINyLMbPgQ55gwZdqHO/QzMCpoIImIrx9xb8EFpZ/rvgCEZboZywFDs9 K/GJvMqYH4dT7ATLV3sudxVK249lXtPl0+A0Rve5T0FntYOfMemMHHu5io/2ZpfWKu81 T2vGyGL+JdfvjDeLRexIeDLSi4T9GnJj144FyuV5AiYhzaTMqlga4dy9NCjjWwDiNYN5 TE/XMTVwUsQCSMILPahxMhCu6JqqGlrevN1/ml28cHUjLBZkQlgTrVfCi5k+B2xbpHgt fODw== MIME-Version: 1.0 Received: by 10.60.12.106 with SMTP id x10mr12077176oeb.103.1347901149010; Mon, 17 Sep 2012 09:59:09 -0700 (PDT) Received: by 10.76.97.168 with HTTP; Mon, 17 Sep 2012 09:59:08 -0700 (PDT) In-Reply-To: References: <20120917163310.GA57928@freefall.freebsd.org> Date: Mon, 17 Sep 2012 11:59:08 -0500 Message-ID: From: Jeremy Messenger To: Freddie Cash Content-Type: text/plain; charset=ISO-8859-1 Cc: Thomas Abthorpe , ports@freebsd.org Subject: Re: [CORRECTION] Change to the header in ports Makefiles, take two X-BeenThere: freebsd-ports@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Porting software to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 17 Sep 2012 16:59:10 -0000 On Mon, Sep 17, 2012 at 11:43 AM, Freddie Cash wrote: > On Mon, Sep 17, 2012 at 9:33 AM, Thomas Abthorpe > wrote: >> It was recently posted on, >> http://blogs.freebsdish.org/portmgr/2012/09/01/change-to-the-header-in-ports-makefiles/ >> that we would adopt a new header for the ports Makefiles. The initial >> discussion seemed to show enough support for the idea of completely >> stripping the header, leaving only the $FreeBSD$ tag. After the >> announcement was made, more people stated strong feelings that when and >> where possible attribution be maintained in the header. >> >> A private discussion was held among ports committers, and while opinions >> were as varied as the individuals who shared them, it was decided to unify >> on a two line header. >> >> # Created by: J.Q. Public >> # $FreeBSD$ >> >> The Whom line from the classic six line header becomes Created By. >> >> Sometimes, as a result of a repocopy, or changed maintainership, the >> Created By and MAINTAINER is no longer in synchronisation. To avoid >> confusion, the first line can be removed, optionally leaving us with a one >> line header. >> >> # $FreeBSD$ > > Wouldn't it make sense to have the "# $FreeBSD$" line be the first > line of the file, so that it never changes? Having some files where > the FreeBSD tag is first, and other files where it's second seems > arbitrarily inconsistent. > > Lines that don't change should come first, so that things are always the same. The copyright always come first. The $FreeBSD$ does change at the each commit. > IMHO, of course. :) I don't care if it's IMHO, but dude you are pain in ass already. > -- > Freddie Cash > fjwcash@gmail.com -- mezz.freebsd@gmail.com - mezz@FreeBSD.org FreeBSD GNOME Team http://www.FreeBSD.org/gnome/ - gnome@FreeBSD.org