From owner-freebsd-current@FreeBSD.ORG Sat Jan 29 15:40:04 2005 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 2A2C216A4CE for ; Sat, 29 Jan 2005 15:40:04 +0000 (GMT) Received: from mail.freebsd.org.cn (dns3.freebsd.org.cn [61.129.66.75]) by mx1.FreeBSD.org (Postfix) with SMTP id 6357643D2D for ; Sat, 29 Jan 2005 15:39:59 +0000 (GMT) (envelope-from delphij@frontfree.net) Received: (qmail 73350 invoked by uid 0); 29 Jan 2005 15:31:46 -0000 Received: from unknown (HELO beastie.frontfree.net) (219.239.99.7) by mail.freebsd.org.cn with SMTP; 29 Jan 2005 15:31:46 -0000 Received: from localhost (localhost.frontfree.net [127.0.0.1]) by beastie.frontfree.net (Postfix) with ESMTP id 39B7E1339E3; Sat, 29 Jan 2005 23:39:49 +0800 (CST) Received: from beastie.frontfree.net ([127.0.0.1]) by localhost (beastie.frontfree.net [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 05440-07; Sat, 29 Jan 2005 23:39:35 +0800 (CST) Received: by beastie.frontfree.net (Postfix, from userid 1001) id E3AB81332DF; Sat, 29 Jan 2005 23:39:34 +0800 (CST) Date: Sat, 29 Jan 2005 23:39:34 +0800 From: Xin LI To: Poul-Henning Kamp Message-ID: <20050129153934.GA5834@frontfree.net> References: <20050129161022.0de822fe@Magellan.Leidinger.net> <46996.1107012088@critter.freebsd.dk> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="IS0zKkzwUGydFO0o" Content-Disposition: inline In-Reply-To: <46996.1107012088@critter.freebsd.dk> User-Agent: Mutt/1.4.2.1i X-GPG-key-ID/Fingerprint: 0xCAEEB8C0 / 43B8 B703 B8DD 0231 B333 DC28 39FB 93A0 CAEE B8C0 X-GPG-Public-Key: http://www.delphij.net/delphij.asc X-Operating-System: FreeBSD beastie.frontfree.net 5.3-RELEASE-p2 FreeBSD 5.3-RELEASE-p2 #15: Wed Dec 15 10:43:16 CST 2004 delphij@beastie.frontfree.net:/usr/obj/usr/src/sys/BEASTIE i386 X-URL: http://www.delphij.net X-By: delphij@beastie.frontfree.net X-Location: Beijing, China X-Virus-Scanned: by amavisd-new at frontfree.net cc: Alexander Leidinger cc: current@freebsd.org Subject: Re: We have a lot of duplicated code in the kernel X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 29 Jan 2005 15:40:04 -0000 --IS0zKkzwUGydFO0o Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sat, Jan 29, 2005 at 04:21:28PM +0100, Poul-Henning Kamp wrote: > In message <20050129161022.0de822fe@Magellan.Leidinger.net>, Alexander Le= idinger writes: > >Hi, > > > >http://www.leidinger.net/FreeBSD/simian-20-sys-20050129.log (253k) > >contains a log of duplicated code in /sys (-current as of today). The > >file starts with files with 20 consecutive lines of duplicated code and > >ends with two files which share 1108 lines of code. > > > >If I let the program detect 6 consecutive lines of duplicated code, it > >is also able to detect possible code reuse in the same file, but it also > >prints a lot of "noise" then. > > > >I've filtered the list for some false positives (twa_fwimg, trlld?m, > >if_patm_rtables), if someone else notices some more files please tell me > >about them and I add them to the filter. >=20 > And we'll soon see the tool which generates this in src/tools/tools > somewhere I hope ? :-) A google search indicates that simian is a tool to look for similary of cod= e. http://www.redhillconsulting.com.au/products/simian/ Cheers, --=20 Xin LI http://www.delphij.net/ See complete headers for GPG key and other information. --IS0zKkzwUGydFO0o Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.0 (FreeBSD) iD8DBQFB+642/cVsHxFZiIoRAsp5AJ9397f3YVLjv1iOREm3hRkHlXBBOgCeP8p2 CBAi7QnZg8sa53XtV578p1s= =Duiv -----END PGP SIGNATURE----- --IS0zKkzwUGydFO0o--