Date: Tue, 16 May 2000 20:21:51 -0700 From: Mike Smith <msmith@freebsd.org> To: Bruce Evans <bde@zeta.org.au> Cc: Chuck Paterson <cp@bsdi.com>, "Jeroen C. van Gelderen" <jeroen@vangelderen.org>, Doug Rabson <dfr@nlsystems.com>, arch@FreeBSD.ORG Subject: Re: A new api for asynchronous task execution (2) Message-ID: <200005170321.UAA04388@mass.cdrom.com> In-Reply-To: Your message of "Wed, 17 May 2000 13:01:44 %2B1000." <Pine.BSF.4.21.0005171232460.5385-100000@besplex.bde.org>
next in thread | previous in thread | raw e-mail | index | archive | help
> On Tue, 16 May 2000, Chuck Paterson wrote: > > > Just an FYI, the TQ_DEF probably came from the flag passed > > into the BSD/OS mutex macros which is M_DEF. These are short > > because the macros often get used when there is sever > > indenting and it is much easer to read when they don't cause > > a line split. Also they are used ALL over the place and after > > looking at the code for a few minutes there is never any doubt > > what they stand for. > > Similarly for many of the other names. "queue" should usually be > abbreviated as "q" or "Q", as in <sys/queue.h>. Perhaps "task" > should be abbreviated as "t" or "T" in more places. The names > should be a little more like those in <sys/queue.h>, e.g., > taskq_add instead of taskqueue_enqueue and taskq_remove instead > of taskqueue_free. This is a bad precedent. It might have been a good idea fifteen or twenty years ago, when six-character symbols were all the rage, but we already have serious namespace issues in the kernel, and this doesn't help at all. Heck, "tq" is already taken (tagged queueing). (This applies to crap going into libc as well; especially new stuff. We should be using a symbol prefix that at least *tries* to keep us out of other peoples' namespaces.) -- \\ Give a man a fish, and you feed him for a day. \\ Mike Smith \\ Tell him he should learn how to fish himself, \\ msmith@freebsd.org \\ and he'll hate you for a lifetime. \\ msmith@cdrom.com To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-arch" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200005170321.UAA04388>