From owner-freebsd-hackers@FreeBSD.ORG Tue Mar 4 15:40:31 2008 Return-Path: Delivered-To: freebsd-hackers@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 0E493106567E; Tue, 4 Mar 2008 15:40:31 +0000 (UTC) (envelope-from keramida@ceid.upatras.gr) Received: from igloo.linux.gr (igloo.linux.gr [62.1.205.36]) by mx1.freebsd.org (Postfix) with ESMTP id 5E1A68FC2F; Tue, 4 Mar 2008 15:40:30 +0000 (UTC) (envelope-from keramida@ceid.upatras.gr) Received: from kobe.laptop (vader.bytemobile-rio.ondsl.gr [83.235.57.37]) (authenticated bits=128) by igloo.linux.gr (8.14.1/8.14.1/Debian-9) with ESMTP id m24FdRsa000473 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NOT); Tue, 4 Mar 2008 17:39:45 +0200 Received: from kobe.laptop (kobe.laptop [127.0.0.1]) by kobe.laptop (8.14.2/8.14.2) with ESMTP id m24FdLF1072552; Tue, 4 Mar 2008 17:39:21 +0200 (EET) (envelope-from keramida@ceid.upatras.gr) Received: (from keramida@localhost) by kobe.laptop (8.14.2/8.14.2/Submit) id m24FdLoQ072549; Tue, 4 Mar 2008 17:39:21 +0200 (EET) (envelope-from keramida@ceid.upatras.gr) Date: Tue, 4 Mar 2008 17:39:21 +0200 From: Giorgos Keramidas To: freebsd-hackers@freebsd.org, hackers@freebsd.org Message-ID: <20080304153920.GB61036@kobe.laptop> References: <20080303.224256.635730757.imp@bsdimp.com> <200803041701.36466.doconnor@gsoft.com.au> <20080304153128.GC27540@saraswathy.madambakam.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20080304153128.GC27540@saraswathy.madambakam.org> X-Hellug-MailScanner: Found to be clean X-Hellug-MailScanner-SpamCheck: not spam, SpamAssassin (not cached, score=-3.976, required 5, autolearn=not spam, ALL_TRUSTED -1.80, AWL 0.42, BAYES_00 -2.60) X-Hellug-MailScanner-From: keramida@ceid.upatras.gr X-Spam-Status: No Cc: Subject: Re: Comments on pmake diffs for building on Linux X-BeenThere: freebsd-hackers@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Technical Discussions relating to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 04 Mar 2008 15:40:31 -0000 On 2008-03-04 21:01, Girish Venkatachalam wrote: >On 17:01:28 Mar 04, Daniel O'Connor wrote: >> I did this a while ago when porting some of our code to Linux because it >> builds with pmake.. >> >> Your patches are much nicer than mine however :) >> >> The tailq stuff could be shoved into a linux.h or some such.. So it's >> more obvious what it's for and why it's there. >> > > PMI but why do I see tailq in gentoo? > > I was taken by surprise when I found my code compile and run beautifully > few months ago. > > I am wondering if that is the case, then why port it? Minor compatibility nits here and there, which can turn a simple TAILQ_FOREACH() call to a nightmare of nested preprocessor hells :)