From owner-freebsd-current@FreeBSD.ORG Sat Jan 10 03:18:47 2009 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 81C991065673 for ; Sat, 10 Jan 2009 03:18:47 +0000 (UTC) (envelope-from pyunyh@gmail.com) Received: from rv-out-0506.google.com (rv-out-0506.google.com [209.85.198.229]) by mx1.freebsd.org (Postfix) with ESMTP id 440258FC18 for ; Sat, 10 Jan 2009 03:18:47 +0000 (UTC) (envelope-from pyunyh@gmail.com) Received: by rv-out-0506.google.com with SMTP id b25so11117273rvf.43 for ; Fri, 09 Jan 2009 19:18:47 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:received:received:date:from :to:cc:subject:message-id:reply-to:references:mime-version :content-type:content-disposition:in-reply-to:user-agent; bh=CWqsLMTb1qJYg3hB9gl9SYusi+Pw3rzfHjq4nCtXct0=; b=vqtiDZPlL2YxXN2Gzq7qnnXOpdkJ4lNt8hr2D+dRodvWGW691zeLeID47xoaN16Wk7 Tbi5Q+qFgM56Nh2sZf6Ep3IFM1qoko3ji9T4k/eiiX/AmPVaCy7U3rnGQGwQirwZbi4M lySd/sVVAOF7E7ybeVzQJ/QqO/e2eg7SuuMII= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=date:from:to:cc:subject:message-id:reply-to:references:mime-version :content-type:content-disposition:in-reply-to:user-agent; b=b8I+RuaOaekYK1ZrROLtp4NgqCQavb5cqieUWt3s4Hbr7hRewKIcolGho9Z/ReV4nh SQOukSN5zA8SkFmb8eS9NbyKhygHT3fewUjef/WZWOknKrYrY7s3enH5W/AMUf6sxrjj ooET8eRVauxXjvM49C8F3mcQiMD8Vhot09FWA= Received: by 10.141.116.17 with SMTP id t17mr13072621rvm.239.1231557526944; Fri, 09 Jan 2009 19:18:46 -0800 (PST) Received: from michelle.cdnetworks.co.kr ([211.53.35.84]) by mx.google.com with ESMTPS id c20sm2884582rvf.8.2009.01.09.19.18.44 (version=TLSv1/SSLv3 cipher=RC4-MD5); Fri, 09 Jan 2009 19:18:45 -0800 (PST) Received: from michelle.cdnetworks.co.kr (localhost.cdnetworks.co.kr [127.0.0.1]) by michelle.cdnetworks.co.kr (8.14.3/8.14.3) with ESMTP id n0A3Idsf039039 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Sat, 10 Jan 2009 12:18:39 +0900 (KST) (envelope-from pyunyh@gmail.com) Received: (from yongari@localhost) by michelle.cdnetworks.co.kr (8.14.3/8.14.3/Submit) id n0A3Id9J039038; Sat, 10 Jan 2009 12:18:39 +0900 (KST) (envelope-from pyunyh@gmail.com) Date: Sat, 10 Jan 2009 12:18:39 +0900 From: Pyun YongHyeon To: Kim Culhan Message-ID: <20090110031839.GK30747@cdnetworks.co.kr> References: <89dbfdc30901071438j314ac431h491f9494593caf64@mail.gmail.com> <20090108011220.GA1256@cdnetworks.co.kr> <89dbfdc30901072336l62c46214i113cccf9985bcdae@mail.gmail.com> <20090108075159.GH1256@cdnetworks.co.kr> <89dbfdc30901080835g67b996f4i50e734f0791a0d56@mail.gmail.com> <20090109061032.GF30747@cdnetworks.co.kr> <89dbfdc30901091243w1d01ab59mc2ade81e65e51c5d@mail.gmail.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="YiEDa0DAkWCtVeE4" Content-Disposition: inline In-Reply-To: <89dbfdc30901091243w1d01ab59mc2ade81e65e51c5d@mail.gmail.com> User-Agent: Mutt/1.4.2.3i Cc: freebsd-current@freebsd.org Subject: Re: msk Marvell Yukon 88E8038 hangs X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: pyunyh@gmail.com List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 10 Jan 2009 03:18:48 -0000 --YiEDa0DAkWCtVeE4 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Fri, Jan 09, 2009 at 03:43:38PM -0500, Kim Culhan wrote: > On Fri, Jan 9, 2009 at 1:10 AM, Pyun YongHyeon wrote: > > On Thu, Jan 08, 2009 at 11:35:28AM -0500, Kim Culhan wrote: > > > On Thu, Jan 8, 2009 at 2:51 AM, Pyun YongHyeon wrote: > > > > On Thu, Jan 08, 2009 at 02:36:48AM -0500, Kim Culhan wrote: > > > > > On Wed, Jan 7, 2009 at 8:12 PM, Pyun YongHyeon wrote: > > > > > > On Wed, Jan 07, 2009 at 05:38:28PM -0500, Kim Culhan wrote: > > > > > > > The msk interface on an Acer Aspire 5570Z hangs, frequently when running cvsup. > > > > > > > > > > > > > > Not necessarily at each hang but sometimes coincident, this is > > > > > > > intermittently output to the console: > > > > > > > > > > > > > > in_cksum_skip: out of data by 56952 > > > > > > > > > > > > > > The above is also output to the console at times when receiving a > > > > > > > character through ssh > > > > > > > to a shell. > > > > > > > > > > > > > > The in_cksum_skip messages and msk hangs are also present on this hardware > > > > > > > running 7.1-RELEASE. > > [deleted] > > > Ok, then how about disabling TSO/Tx checksum offload? > > (eg. ifconfig msk0 -tso -txcsum) > > This stops the messages: in_cksum_skip: out of data by 56952 Ok, would you try attached patch? -- Regards, Pyun YongHyeon --YiEDa0DAkWCtVeE4 Content-Type: text/x-diff; charset=us-ascii Content-Disposition: attachment; filename="msk.csum.diff" Index: sys/dev/msk/if_msk.c =================================================================== --- sys/dev/msk/if_msk.c (revision 186998) +++ sys/dev/msk/if_msk.c (working copy) @@ -2608,17 +2608,14 @@ */ if (m->m_pkthdr.len < MSK_MIN_FRAMELEN && (m->m_pkthdr.csum_flags & CSUM_TCP) != 0) { - uint16_t csum; - m = m_pullup(m, offset + sizeof(struct tcphdr)); if (m == NULL) { *m_head = NULL; return (ENOBUFS); } - csum = in_cksum_skip(m, ntohs(ip->ip_len) + offset - - (ip->ip_hl << 2), offset); *(uint16_t *)(m->m_data + offset + - m->m_pkthdr.csum_data) = csum; + m->m_pkthdr.csum_data) = in_cksum_skip(m, + m->m_pkthdr.len, offset); m->m_pkthdr.csum_flags &= ~CSUM_TCP; } if ((m->m_pkthdr.csum_flags & CSUM_TSO) != 0) { --YiEDa0DAkWCtVeE4--