From nobody Mon Jul 11 18:37:15 2022 X-Original-To: freebsd-current@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id E7C3A1D0A66F for ; Mon, 11 Jul 2022 18:37:16 +0000 (UTC) (envelope-from freqlabs@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4LhXg06Frmz3Y4q for ; Mon, 11 Jul 2022 18:37:16 +0000 (UTC) (envelope-from freqlabs@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1657564636; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=1E4YA4IewhJs5eSsDIHm8nmr/MSOlSNgj+P05AnXsII=; b=cxXXgDOo4fUVrk/KtsM9YgB5b9g1CBz5y9I0EbCYXUsb40g1eCe7M1qidIswC/SojW4IOs 9HFImiqO4VV8PpiJa8S8yWXvVOzMdjqgxXWY1T/fQU0KlOfTXr+//u++znQAek8+GHvJGr yLMRX5t8HW3U61tM+i3uq9rr1upNZjNih2eSZvt0qlUkJOBODayKI+ZkbZSJcvav72QxoQ kXyjPiSnR92rmiH6UOpVEoBZlJY1fI8QEHKVfqWpjIxCtLyTeOVnRF4QP1+KARSpDwhgGn 72eQ0sIsoGLD60/HaDFgrEJGapQzZ/lfG7ucevK1qvJZ4pAj4Bpb68eG4aCfsg== Received: from [192.168.1.119] (69-228-200-148.lightspeed.knvltn.sbcglobal.net [69.228.200.148]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) (Authenticated sender: freqlabs/mail) by smtp.freebsd.org (Postfix) with ESMTPSA id 4LhXg04h56zTKB for ; Mon, 11 Jul 2022 18:37:16 +0000 (UTC) (envelope-from freqlabs@FreeBSD.org) Content-Type: multipart/alternative; boundary="------------f316Ma4kSIBCsfrFj4xvK95l" Message-ID: Date: Mon, 11 Jul 2022 14:37:15 -0400 List-Id: Discussions about the use of FreeBSD-current List-Archive: https://lists.freebsd.org/archives/freebsd-current List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-current@freebsd.org MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: BLAKE3 unstability? Content-Language: en-US To: freebsd-current@freebsd.org References: <20220709162640.7my2bq6rax5npdhf@vax.khramtsov.org> <20220709175605.ofkoft2mglrkaqpf@vax.khramtsov.org> From: Ryan Moeller In-Reply-To: ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1657564636; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=1E4YA4IewhJs5eSsDIHm8nmr/MSOlSNgj+P05AnXsII=; b=TZx3YfDL+33hwWjdm8Ea1mDoDv/Cac45bVaV9Bxagk8AcmswrJ6kOYTA32ge58P+iKs1t6 2kc5pvQ8TYyXjRn5DQHqYsuNA1eIkireq7eXLlhR74e+DEX5opCZgqHVzwUDzgYU3tfFqH rt9Svml7qSRSVmYijtQSGH3wQR2Jfdn9jT6Ms7b5oHhBhpnZcDiR/qxYn3NvMXr/kOXndH M2zklgV41mV/Y21rSfZsbsQQl062FnI2CeR0o0wQuWILcwhcAMoeJiPoaUldMu/TgZLEzT 8fw/YXftwG3+b0MT0fOcHhCYoUx0jrhvznx5Bov0jft+gc+Cip74sKmRiD9Q6Q== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1657564636; a=rsa-sha256; cv=none; b=LnJRURvCewSMoZps898cQmJduauCuYOT0MVrSJJGc6kygpIsj4j0CBMyhkVUvsbnwLyQWZ eknHMHLmmugiYwhhyvVqNvB9mqCeZD0ee3jK+hPrDrsCM5ARpVVCPGVE5TZr/5u0WixhnI LHqpWTawgy3sNl6CMWnO/5VR4yu4aims1hUhBoagNM/aFQUHRDCNdGuPXesp1h9pu5jqbT OHm8lkg7hjhz90FzzOliFnXx51jovyN2duyNKc3s87NHCL+hcA1v5feRxa1HHAhtRgC1k9 ba/Sr5IfpKFyIJGJzxn5OwSOqfUTU77IifgPxdxZBGn59IB4KGHVYwRHh24n/Q== ARC-Authentication-Results: i=1; mx1.freebsd.org; none X-ThisMailContainsUnwantedMimeParts: N This is a multi-part message in MIME format. --------------f316Ma4kSIBCsfrFj4xvK95l Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 7/11/22 11:43 AM, Ryan Moeller wrote: > > On 7/9/22 1:56 PM, Evgeniy Khramtsov wrote: >> I can reproduce via: >> >> $ truncate -s 10G /tmp/test >> $ mdconfig -f /tmp/test -S 4096 >> $ zpool create test /dev/md1 >> $ zfs create -o checksum=blake3 test/b >> $ dd if=/dev/random of=/test/b/noise bs=1M count=4096 >> $ sync >> $ zpool scrub test >> $ zpool status > > I cannot reproduce this on openzfs/zfs@cb01da68057 (the commit that > was most recently merged) built out of tree on either stable/13 > 70fd40edb86 or main 9aa02d5120a. > > I'll update a system and see if I can reproduce it with the in-tree ZFS. > > - Ryan > It did not reproduce for me with in-tree ZFS on main@3c9ad9398fcd either. Could you share sysctl kstat.zfs.misc.chksum_bench, maybe we are using different implementations? I do see that blake3 went in with only a Linux module parameter for the implementation selection, so I'll have to fix that. For now we can at least see which was fastest, which should be the one selected. You just won't be able to manually change it to see if that helps. - Ryan --------------f316Ma4kSIBCsfrFj4xvK95l Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: 7bit On 7/11/22 11:43 AM, Ryan Moeller wrote:

On 7/9/22 1:56 PM, Evgeniy Khramtsov wrote:
I can reproduce via:

$ truncate -s 10G /tmp/test
$ mdconfig -f /tmp/test -S 4096
$ zpool create test /dev/md1
$ zfs create -o checksum=blake3 test/b
$ dd if=/dev/random of=/test/b/noise bs=1M count=4096
$ sync
$ zpool scrub test
$ zpool status

I cannot reproduce this on openzfs/zfs@cb01da68057 (the commit that was most recently merged) built out of tree on either stable/13 70fd40edb86 or main 9aa02d5120a.

I'll update a system and see if I can reproduce it with the in-tree ZFS.

- Ryan

It did not reproduce for me with in-tree ZFS on main@3c9ad9398fcd either.

Could you share sysctl kstat.zfs.misc.chksum_bench, maybe we are using different implementations?
I do see that blake3 went in with only a Linux module parameter for the implementation selection, so I'll have to fix that. For now we can at least see which was fastest, which should be the one selected. You just won't be able to manually change it to see if that helps.

- Ryan --------------f316Ma4kSIBCsfrFj4xvK95l--