Date: Wed, 5 Jan 2022 14:48:00 +0000 From: "emaste (Ed Maste)" <phabric-noreply@FreeBSD.org> To: Phabricator <phabric-noreply@FreeBSD.org> Cc: freebsd-net@freebsd.org Subject: [Differential] D33717: route: remove write-only struct hostent from getaddr() Message-ID: <6c41f57f3bf35fd98f611f0d7d8b2cc0@localhost.localdomain> In-Reply-To: <differential-rev-PHID-DREV-zjrsejzgv3kp46yx4cfw-req@reviews.freebsd.org> References: <differential-rev-PHID-DREV-zjrsejzgv3kp46yx4cfw-req@reviews.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--b1_6c41f57f3bf35fd98f611f0d7d8b2cc0 Content-Type: text/plain; charset = "utf-8" Content-Transfer-Encoding: base64 ZW1hc3RlIHVwZGF0ZWQgdGhpcyByZXZpc2lvbiB0byBEaWZmIDEwMDk3My4KZW1hc3RlIGFkZGVk IGEgY29tbWVudC4KCgogIHJlbW92ZSBub3ctdW51c2VkIHZhcmlhYmxlCgpDSEFOR0VTIFNJTkNF IExBU1QgVVBEQVRFCiAgaHR0cHM6Ly9yZXZpZXdzLmZyZWVic2Qub3JnL0QzMzcxNz92cz0xMDA4 MTUmaWQ9MTAwOTczCgpDSEFOR0VTIFNJTkNFIExBU1QgQUNUSU9OCiAgaHR0cHM6Ly9yZXZpZXdz LmZyZWVic2Qub3JnL0QzMzcxNy9uZXcvCgpSRVZJU0lPTiBERVRBSUwKICBodHRwczovL3Jldmll d3MuZnJlZWJzZC5vcmcvRDMzNzE3CgpBRkZFQ1RFRCBGSUxFUwogIHNiaW4vcm91dGUvcm91dGUu YwoKRU1BSUwgUFJFRkVSRU5DRVMKICBodHRwczovL3Jldmlld3MuZnJlZWJzZC5vcmcvc2V0dGlu Z3MvcGFuZWwvZW1haWxwcmVmZXJlbmNlcy8KClRvOiBlbWFzdGUsIG1lbGlmYXJvLCBpbXAsIGhy cwpDYzogZnJlZWJzZC1uZXQtbGlzdAo= --b1_6c41f57f3bf35fd98f611f0d7d8b2cc0 Content-Type: text/x-patch; charset=utf-8; name="D33717.100973.patch" Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename="D33717.100973.patch" ZGlmZiAtLWdpdCBhL3NiaW4vcm91dGUvcm91dGUuYyBiL3NiaW4vcm91dGUvcm91dGUuYwotLS0g YS9zYmluL3JvdXRlL3JvdXRlLmMKKysrIGIvc2Jpbi9yb3V0ZS9yb3V0ZS5jCkBAIC0xMTcsNyAr MTE3LDcgQEAKIHN0YXRpYyB2b2lkCXByaW50YihpbnQsIGNvbnN0IGNoYXIgKik7CiBzdGF0aWMg dm9pZAlmbHVzaHJvdXRlcyhpbnQgYXJnYywgY2hhciAqYXJndltdKTsKIHN0YXRpYyBpbnQJZmx1 c2hyb3V0ZXNfZmliKGludCk7Ci1zdGF0aWMgaW50CWdldGFkZHIoaW50LCBjaGFyICosIHN0cnVj dCBob3N0ZW50ICoqLCBpbnQpOworc3RhdGljIGludAlnZXRhZGRyKGludCwgY2hhciAqLCBpbnQp Owogc3RhdGljIGludAlrZXl3b3JkKGNvbnN0IGNoYXIgKik7CiAjaWZkZWYgSU5FVAogc3RhdGlj IHZvaWQJaW5ldF9tYWtlbWFzayhzdHJ1Y3Qgc29ja2FkZHJfaW4gKiwgdV9sb25nKTsKQEAgLTc5 MCw3ICs3OTAsNiBAQAogbmV3cm91dGUoaW50IGFyZ2MsIGNoYXIgKiphcmd2KQogewogCXN0cnVj dCBzaWdhY3Rpb24gc2E7Ci0Jc3RydWN0IGhvc3RlbnQgKmhwOwogCXN0cnVjdCBmaWJsICpmbDsK IAljaGFyICpjbWQ7CiAJY29uc3QgY2hhciAqZGVzdCwgKmdhdGV3YXksICplcnJtc2c7CkBAIC04 MDIsNyArODAxLDYgQEAKIAlnYXRld2F5ID0gTlVMTDsKIAlmbGFncyA9IFJURl9TVEFUSUM7CiAJ bnJmbGFncyA9IDA7Ci0JaHAgPSBOVUxMOwogCVRBSUxRX0lOSVQoJmZpYmxfaGVhZCk7CiAKIAlz aWdlbXB0eXNldCgmc2Euc2FfbWFzayk7CkBAIC04OTMsMzUgKzg5MSwzNSBAQAogCQkJY2FzZSBL X0lGQToKIAkJCQlpZiAoIS0tYXJnYykKIAkJCQkJdXNhZ2UoTlVMTCk7Ci0JCQkJZ2V0YWRkcihS VEFYX0lGQSwgKisrYXJndiwgTlVMTCwgbnJmbGFncyk7CisJCQkJZ2V0YWRkcihSVEFYX0lGQSwg KisrYXJndiwgbnJmbGFncyk7CiAJCQkJYnJlYWs7CiAJCQljYXNlIEtfSUZQOgogCQkJCWlmICgh LS1hcmdjKQogCQkJCQl1c2FnZShOVUxMKTsKLQkJCQlnZXRhZGRyKFJUQVhfSUZQLCAqKythcmd2 LCBOVUxMLCBucmZsYWdzKTsKKwkJCQlnZXRhZGRyKFJUQVhfSUZQLCAqKythcmd2LCBucmZsYWdz KTsKIAkJCQlicmVhazsKIAkJCWNhc2UgS19HRU5NQVNLOgogCQkJCWlmICghLS1hcmdjKQogCQkJ CQl1c2FnZShOVUxMKTsKLQkJCQlnZXRhZGRyKFJUQVhfR0VOTUFTSywgKisrYXJndiwgTlVMTCwg bnJmbGFncyk7CisJCQkJZ2V0YWRkcihSVEFYX0dFTk1BU0ssICorK2FyZ3YsIG5yZmxhZ3MpOwog CQkJCWJyZWFrOwogCQkJY2FzZSBLX0dBVEVXQVk6CiAJCQkJaWYgKCEtLWFyZ2MpCiAJCQkJCXVz YWdlKE5VTEwpOwotCQkJCWdldGFkZHIoUlRBWF9HQVRFV0FZLCAqKythcmd2LCBOVUxMLCBucmZs YWdzKTsKKwkJCQlnZXRhZGRyKFJUQVhfR0FURVdBWSwgKisrYXJndiwgbnJmbGFncyk7CiAJCQkJ Z2F0ZXdheSA9ICphcmd2OwogCQkJCWJyZWFrOwogCQkJY2FzZSBLX0RTVDoKIAkJCQlpZiAoIS0t YXJnYykKIAkJCQkJdXNhZ2UoTlVMTCk7Ci0JCQkJaWYgKGdldGFkZHIoUlRBWF9EU1QsICorK2Fy Z3YsICZocCwgbnJmbGFncykpCisJCQkJaWYgKGdldGFkZHIoUlRBWF9EU1QsICorK2FyZ3YsIG5y ZmxhZ3MpKQogCQkJCQlucmZsYWdzIHw9IEZfSVNIT1NUOwogCQkJCWRlc3QgPSAqYXJndjsKIAkJ CQlicmVhazsKIAkJCWNhc2UgS19ORVRNQVNLOgogCQkJCWlmICghLS1hcmdjKQogCQkJCQl1c2Fn ZShOVUxMKTsKLQkJCQlnZXRhZGRyKFJUQVhfTkVUTUFTSywgKisrYXJndiwgTlVMTCwgbnJmbGFn cyk7CisJCQkJZ2V0YWRkcihSVEFYX05FVE1BU0ssICorK2FyZ3YsIG5yZmxhZ3MpOwogCQkJCS8q IEZBTExUSFJPVUdIICovCiAJCQljYXNlIEtfTkVUOgogCQkJCW5yZmxhZ3MgfD0gRl9GT1JDRU5F VDsKQEAgLTk1NiwxMyArOTU0LDEzIEBACiAJCX0gZWxzZSB7CiAJCQlpZiAoKHJ0bV9hZGRycyAm IFJUQV9EU1QpID09IDApIHsKIAkJCQlkZXN0ID0gKmFyZ3Y7Ci0JCQkJaWYgKGdldGFkZHIoUlRB WF9EU1QsICphcmd2LCAmaHAsIG5yZmxhZ3MpKQorCQkJCWlmIChnZXRhZGRyKFJUQVhfRFNULCAq YXJndiwgbnJmbGFncykpCiAJCQkJCW5yZmxhZ3MgfD0gRl9JU0hPU1Q7CiAJCQl9IGVsc2UgaWYg KChydG1fYWRkcnMgJiBSVEFfR0FURVdBWSkgPT0gMCkgewogCQkJCWdhdGV3YXkgPSAqYXJndjsK LQkJCQlnZXRhZGRyKFJUQVhfR0FURVdBWSwgKmFyZ3YsICZocCwgbnJmbGFncyk7CisJCQkJZ2V0 YWRkcihSVEFYX0dBVEVXQVksICphcmd2LCBucmZsYWdzKTsKIAkJCX0gZWxzZSB7Ci0JCQkJZ2V0 YWRkcihSVEFYX05FVE1BU0ssICphcmd2LCBOVUxMLCBucmZsYWdzKTsKKwkJCQlnZXRhZGRyKFJU QVhfTkVUTUFTSywgKmFyZ3YsIG5yZmxhZ3MpOwogCQkJCW5yZmxhZ3MgfD0gRl9GT1JDRU5FVDsK IAkJCX0KIAkJfQpAQCAtMTE1NCw3ICsxMTUyLDcgQEAKICAqIHJldHVybmluZyAxIGlmIGEgaG9z dCBhZGRyZXNzLCAwIGlmIGEgbmV0d29yayBhZGRyZXNzLgogICovCiBzdGF0aWMgaW50Ci1nZXRh ZGRyKGludCBpZHgsIGNoYXIgKnN0ciwgc3RydWN0IGhvc3RlbnQgKipocHAsIGludCBucmZsYWdz KQorZ2V0YWRkcihpbnQgaWR4LCBjaGFyICpzdHIsIGludCBucmZsYWdzKQogewogCXN0cnVjdCBz b2NrYWRkciAqc2E7CiAjaWYgZGVmaW5lZChJTkVUKQpAQCAtMTE3OSw5ICsxMTc3LDYgQEAKIAkJ YWZsZW4gPSBzaXplb2Yoc3RydWN0IHNvY2thZGRyX2RsKTsKICNlbmRpZgogCX0KLSNpZm5kZWYg SU5FVAotCWhwcCA9IE5VTEw7Ci0jZW5kaWYKIAlydG1fYWRkcnMgfD0gKDEgPDwgaWR4KTsKIAlz YSA9IChzdHJ1Y3Qgc29ja2FkZHIgKikmc29baWR4XTsKIAlzYS0+c2FfZmFtaWx5ID0gYWY7CkBA IC0xMjMzLDcgKzEyMjgsNyBAQAogCQlzd2l0Y2ggKGlkeCkgewogCQljYXNlIFJUQVhfRFNUOgog CQkJbnJmbGFncyB8PSBGX0ZPUkNFTkVUOwotCQkJZ2V0YWRkcihSVEFYX05FVE1BU0ssIHN0ciwg TlVMTCwgbnJmbGFncyk7CisJCQlnZXRhZGRyKFJUQVhfTkVUTUFTSywgc3RyLCBucmZsYWdzKTsK IAkJCWJyZWFrOwogCQl9CiAJCXJldHVybiAoMCk7CkBAIC0xMjgwLDkgKzEyNzUsNiBAQAogCiAj aWZkZWYgSU5FVAogCXNpbiA9IChzdHJ1Y3Qgc29ja2FkZHJfaW4gKikodm9pZCAqKXNhOwotCWlm IChocHAgPT0gTlVMTCkKLQkJaHBwID0gJmhwOwotCSpocHAgPSBOVUxMOwogCiAJcSA9IHN0cmNo cihzdHIsJy8nKTsKIAlpZiAocSAhPSBOVUxMICYmIGlkeCA9PSBSVEFYX0RTVCkgewpAQCAtMTMw Myw3ICsxMjk1LDYgQEAKIAogCWhwID0gZ2V0aG9zdGJ5bmFtZShzdHIpOwogCWlmIChocCAhPSBO VUxMKSB7Ci0JCSpocHAgPSBocDsKIAkJc2luLT5zaW5fZmFtaWx5ID0gaHAtPmhfYWRkcnR5cGU7 CiAJCW1lbW1vdmUoKGNoYXIgKikmc2luLT5zaW5fYWRkciwgaHAtPmhfYWRkciwKIAkJICAgIE1J Tigoc2l6ZV90KWhwLT5oX2xlbmd0aCwgc2l6ZW9mKHNpbi0+c2luX2FkZHIpKSk7Cgo= --b1_6c41f57f3bf35fd98f611f0d7d8b2cc0--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?6c41f57f3bf35fd98f611f0d7d8b2cc0>