From nobody Thu Jul 17 22:53:34 2025 X-Original-To: current@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4bjpBP4k7zz62MDP for ; Thu, 17 Jul 2025 22:53:49 +0000 (UTC) (envelope-from rick.macklem@gmail.com) Received: from mail-ej1-x632.google.com (mail-ej1-x632.google.com [IPv6:2a00:1450:4864:20::632]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "WR4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4bjpBP2FFgz3CYv; Thu, 17 Jul 2025 22:53:49 +0000 (UTC) (envelope-from rick.macklem@gmail.com) Authentication-Results: mx1.freebsd.org; none Received: by mail-ej1-x632.google.com with SMTP id a640c23a62f3a-adfb562266cso249127166b.0; Thu, 17 Jul 2025 15:53:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1752792826; x=1753397626; darn=freebsd.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=WgEISK0ABUdGVpTm9pRWdL+O+UV6vh4YmNgn/YByE+k=; b=ZhipTBwUgRzY8X/4um67AGSWwzzt/fQlaenQj/9UsWVYXao9tq7q3f0ETWrt0Fqju2 lyvCgZRaZi3Nu6VIp4QEx8L2mmZSBOvv0NJe+py5Y5oF6UCdS4hDWTjVyY9QyC2tZZKV 9iPIeL8ALX09w0QgYV07p2sFdmm4kygkDibhlQR+EbVSiJpGifZnJ8tVibUXxDFxf5Jz FGe0N9BKJoSfx2KF4n7RcpOxZuRrEzAwB+XBLHkgz4mJ8xpx/7fB/BZA6PtVE3n4ZEQj Wy1VSfaEc/T1T47nxCZIokj+mmrEtkUS9ePMRFJLUqnL9mAGM8Wi43g4drp+ayTTkQpJ yQWw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1752792826; x=1753397626; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=WgEISK0ABUdGVpTm9pRWdL+O+UV6vh4YmNgn/YByE+k=; b=cP0gVDatAdmOcA9UyCHo5gfSYMCcQ6e5COEqAknwpjY/yZzX3XmsadxoQXOBJYb5hD k1pHnY6im45kkpi32hA/mKu4BykvL2hrkkyASR6ZbMyKY4P7u3vYJ4v/3ScuyCXndcI9 dNMBcvtaKoTkGRkhNpIAVzvf0H6igcTlbQZJyZ/r7x4h4ucXpXhHMBq+//gtVnPDrhru LE4wl9dH2H0VeHm5HR85tP9fts/z17dSwSb4iR+IPNJi1OFVZm4KjR2VsK+nzFNx+5hR jMVLxwPhYzETAnVieQImT1Dv51Lvc5bREdZojt4klwAPex0QP4E/bHc4bmq15f/YXDYP EirQ== X-Forwarded-Encrypted: i=1; AJvYcCUVIaWCoW6299aK/gZDEX7uY2GPizNTJ0gmQItb3aI+fuPo60FtQUj9p7Kv60mTMo7GVCc=@freebsd.org, AJvYcCVixVt2Jyz1+To72oI2t6agw5aaEHHOu6uV2XlDBMNqko3G70eh1n/7f/vvmSpMgghwlpsr4pH9+lY=@freebsd.org X-Gm-Message-State: AOJu0Yy8XC0+r7wG7fRFA1jRWuKndTRwvLDJ+KIzJKM7RhwtryzRDdRU m3KsBbg4QKYnI6ktW2RHEu3jacpNUhoxtFqpIrb2pd5diW9EjAtnI5s3+qjiHGWO16fth4ZPCpl EklAvzqom9/ACszdLsMxtDa368/vAusvY X-Gm-Gg: ASbGncug2OB9SFOeLDzRdBCjcxEF+uQFdDOe+/LywdTO6NOpP8A+kjCzO4FqjaWq9oN Dms/5WlLGQnnb04u41ntZTWYhLbznTmzSjFR6CBSL+uYXbwHeHSHrAmsXKObAJq5/wz+d59fksB p8+15TlHZEk5QqDPBKCpEgFJubm4Att84+XLahalM5XMWzs4unKMiyIv7fyYXlorx6YH86nB5ge b+qxG78CNc82o6S/gWXSB8g78A0cEsobN6gQPI= X-Google-Smtp-Source: AGHT+IFBt8cGpEQVFCh6fLnCMFrd2cr8d3ZRWIM9wdgu1fLJOPqgxpupVRde/MMj+xrrDkmcBzNU1S6yyqAH3FmluKY= X-Received: by 2002:a17:907:6d1a:b0:add:ede0:b9c4 with SMTP id a640c23a62f3a-ae9c9b0e3bemr857932266b.42.1752792825722; Thu, 17 Jul 2025 15:53:45 -0700 (PDT) List-Id: Discussions about the use of FreeBSD-current List-Archive: https://lists.freebsd.org/archives/freebsd-current List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-current@FreeBSD.org MIME-Version: 1.0 References: <86ecuqcw3d.fsf@ltc.des.dev> <86qzyfaq8f.fsf@ltc.des.dev> In-Reply-To: <86qzyfaq8f.fsf@ltc.des.dev> From: Rick Macklem Date: Thu, 17 Jul 2025 15:53:34 -0700 X-Gm-Features: Ac12FXysDtI4n8NDz9znxt_C7UO0Faz4C-6xQ6vuMtEEIsGVUGIQo77N-D9iKvA Message-ID: Subject: Re: NFS panic in latest main To: =?UTF-8?Q?Dag=2DErling_Sm=C3=B8rgrav?= Cc: current@freebsd.org, kib@freebsd.org, rmacklem@freebsd.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: 4bjpBP2FFgz3CYv X-Spamd-Bar: ---- X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; TAGGED_FROM(0.00)[]; ASN(0.00)[asn:15169, ipnet:2a00:1450::/32, country:US] On Thu, Jul 17, 2025 at 6:42=E2=80=AFAM Dag-Erling Sm=C3=B8rgrav wrote: > > CAUTION: This email originated from outside of the University of Guelph. = Do not click links or open attachments unless you recognize the sender and = know the content is safe. If in doubt, forward suspicious emails to IThelp@= uoguelph.ca. > > I have another one: > > db_trace_self_wrapper() at db_trace_self_wrapper+0x2b/frame 0xfffffe0= 08dfd0490 > assert_vop_locked() at assert_vop_locked+0x49/frame 0xfffffe008dfd04b= 0 > VOP_PATHCONF_APV() at VOP_PATHCONF_APV+0x42/frame 0xfffffe008dfd04e0 > nfsv4_fillattr() at nfsv4_fillattr+0xfa8/frame 0xfffffe008dfd0670 > nfsvno_fillattr() at nfsvno_fillattr+0xdd/frame 0xfffffe008dfd0710 > nfsrvd_getattr() at nfsrvd_getattr+0x3c6/frame 0xfffffe008dfd09a0 > nfsrvd_dorpc() at nfsrvd_dorpc+0x167e/frame 0xfffffe008dfd0bb0 > nfssvc_program() at nfssvc_program+0x852/frame 0xfffffe008dfd0db0 > svc_run_internal() at svc_run_internal+0xaa8/frame 0xfffffe008dfd0ee0 > svc_thread_start() at svc_thread_start+0xb/frame 0xfffffe008dfd0ef0 > fork_exit() at fork_exit+0x82/frame 0xfffffe008dfd0f30 > fork_trampoline() at fork_trampoline+0xe/frame 0xfffffe008dfd0f30 > --- trap 0xc, rip =3D 0x2a07bda3b4ea, rsp =3D 0x2a07bc818ed8, rbp =3D= 0x2a07bc819170 --- > vnode 0xfffff8007dfdac08: type VDIR state VSTATE_CONSTRUCTED op 0xfff= fffff822fc120 > usecount 3, writecount 0, refcount 1 seqc users 0 mountedhere 0 > hold count flags () > flags (VV_ROOT) > lock type tmpfs: UNLOCKED > tag VT_TMPFS, tmpfs_node 0xfffff800ada100f0, flags 0x0, links 2 > mode 0755, owner 0, group 0, size 0, status 0x0 > > VOP_PATHCONF Entry (vp): 0xfffff8007dfdac08 is not locked but should = be > > This can be reliably triggered by running the nfsv4 test case from > review D51371. Note that you will need to apply D51372 first to allow > the client jail to mount NFS file systems. The bug is in nfsrvd_getattr() at around line# 308-343. No real client bumps into a VV_ROOT vnode like this. I'll work on a patch. The code is handling the case where the getattr crosses a server mount poin= t and it doesn't relock vp. I haven't touched this code in decades, so I need= to remember exactly what needs to be done in this case? I'll post a patch for testing when I have one. rick > > DES > -- > Dag-Erling Sm=C3=B8rgrav - des@FreeBSD.org