Date: Tue, 10 Mar 2009 15:19:01 +0100 (CET) From: Bapt <baptiste.daroussin@gmail.com> To: FreeBSD-gnats-submit@FreeBSD.org Subject: ports/132503: [PATCH] graphics/feh: support NETWM fullscreen Message-ID: <20090310141902.12ADEF1B0F@wicklow.lan> Resent-Message-ID: <200903101420.n2AEK2Ft017474@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
>Number: 132503
>Category: ports
>Synopsis: [PATCH] graphics/feh: support NETWM fullscreen
>Confidential: no
>Severity: non-critical
>Priority: low
>Responsible: freebsd-ports-bugs
>State: open
>Quarter:
>Keywords:
>Date-Required:
>Class: sw-bug
>Submitter-Id: current-users
>Arrival-Date: Tue Mar 10 14:20:01 UTC 2009
>Closed-Date:
>Last-Modified:
>Originator: Bapt
>Release: FreeBSD 7.1-PRERELEASE i386
>Organization:
>Environment:
System: FreeBSD wicklow.lan 7.1-PRERELEASE FreeBSD 7.1-PRERELEASE #7: Mon Oct 13 22:58:33 CEST 2008 root@wicklow.lan:/usr/obj/usr/src/sys/WICKLOW i386
>Description:
Here is a patch from upstream to add support for NETWM fullscreen in feh
>How-To-Repeat:
>Fix:
--- patch-NETWM begins here ---
Index: src/winwidget.c
===================================================================
--- src/winwidget.c (revision 52)
+++ src/winwidget.c (revision 54)
@@ -159,4 +159,5 @@
{
XSetWindowAttributes attr;
+ XEvent ev;
XClassHint *xch;
MWMHints mwmhints;
@@ -256,4 +257,20 @@
XChangeProperty(disp, ret->win, prop, prop, 32, PropModeReplace,
(unsigned char *) &mwmhints, PROP_MWM_HINTS_ELEMENTS);
+ }
+ if (ret->full_screen) {
+ Atom prop_fs = XInternAtom(disp, "_NET_WM_STATE_FULLSCREEN", False);
+ Atom prop_state = XInternAtom(disp, "_NET_WM_STATE", False);
+
+ memset(&ev, 0, sizeof(ev));
+ ev.xclient.type = ClientMessage;
+ ev.xclient.message_type = prop_state;
+ ev.xclient.display = disp;
+ ev.xclient.window = ret->win;
+ ev.xclient.format = 32;
+ ev.xclient.data.l[0] = (ret->full_screen ? 1 : 0);
+ ev.xclient.data.l[1] = prop_fs;
+
+ XChangeProperty(disp, ret->win, prop_state, XA_ATOM, 32,
+ PropModeReplace, &prop_fs, 1);
}
--- patch-NETWM ends here ---
>Release-Note:
>Audit-Trail:
>Unformatted:
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20090310141902.12ADEF1B0F>