From nobody Tue Apr 30 20:04:52 2024 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4VTWPx1yWHz5JqYX; Tue, 30 Apr 2024 20:04:53 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4VTWPw48QMz4HYK; Tue, 30 Apr 2024 20:04:52 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1714507492; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=WG2sA/86+q6cLsaRsKobEtagh1JY45T64uSUMqH55sM=; b=u7/kedr83EvXBrkNaYOC0RV6Mo13IhHJULOpV7l+HnW2MxHr9j8rynbH53vKEhoy3ush8S EVqPSMNFlFOJe/ZkWATwlIDjUFhNbazczLd0KX3wpILoo2nsjyX8X4NwcWoXM6Jl2jOAMM a90doIUgBu4QtTT71LtnJXl9k1eXcTY+0Th+ZEpi2t3wJHPGXsbUzepXbfvpiz9EIlClPk e4L3D8xWcfRZ70r3DOAise9kqxj2EKcJraqBvYDqfoo8nbBdiTFNb9JDkcyfNR/1DuZ0qL Ntd7ZhAFPqJ0InnhxwJwigfhaCM52FTdd6SIksyR1bkDm9W3o1oISt8JvNn7xQ== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1714507492; a=rsa-sha256; cv=none; b=VAAkIuYHVUYMNsOYeJGu4iJPoBsaH1AeEuTaw/49WF0gjZj/qaOG0MXvLoM+mONYTZQ3lK +XKWXhG0vsXqM6ZqWZhOh7L0fBIsaM2n2pNUt1ctO/WW3A9lBhWkyE25+Pm69wAkIPZF4V IqPReN4zW2hmnEO3UVIToT9hwsC8MB9fWF3z3w906oBbA0C3UppPpcmTeQpAqUDQY+lFMX R4xq3hEg4UiRdBTPJQdISYFLB1rv3aZqp092fyiupG8pI68K2WoESbDt5uOgjVRD5UlMaO 6XBmdHxhsaX9+TwoBLlBuMmmBRR101UCDw63wHg8BNi4basioeoOz8ildmI5nQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1714507492; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=WG2sA/86+q6cLsaRsKobEtagh1JY45T64uSUMqH55sM=; b=In7BpsGsGaiZ8OfvVvrNxk6AGiqz/wNiK+N/nwEA7y1yrbZUGMxfqDbK+b3wMeXYIr8exA UvYafJiK5Gj1vW+180KBWbi0ApaGEBXhcMYEMQC75X6l4mnQAh/rbHWbhOWZqjeqPUuDYF NPoMktarz+PNXG24zrgsQgTS3mAyuwv5Gdb2auEdFMkG+1+QSC1GXTCaLTwfmzSiBRqPlD hvPScGaIs7GRhUOLboF48rDjDAaWM+bGS8YkmN3ax8LqcxpltM06wfO2NjOaw6QJz2ddcm PQXE1P8mSaWPgPKaGF8s26LqpB62mweUHwiuWlpKpBumXD4W77wiOlRvrBXClg== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4VTWPw3mnQzprL; Tue, 30 Apr 2024 20:04:52 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.17.1/8.17.1) with ESMTP id 43UK4qZb076776; Tue, 30 Apr 2024 20:04:52 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.17.1/8.17.1/Submit) id 43UK4qYX076774; Tue, 30 Apr 2024 20:04:52 GMT (envelope-from git) Date: Tue, 30 Apr 2024 20:04:52 GMT Message-Id: <202404302004.43UK4qYX076774@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Navdeep Parhar Subject: git: 21aba396551e - main - cxgbe(4): Minor tweaks to comments. List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: np X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 21aba396551e29808fa56a6d4fab17e871c3524f Auto-Submitted: auto-generated The branch main has been updated by np: URL: https://cgit.FreeBSD.org/src/commit/?id=21aba396551e29808fa56a6d4fab17e871c3524f commit 21aba396551e29808fa56a6d4fab17e871c3524f Author: Navdeep Parhar AuthorDate: 2024-04-30 20:01:07 +0000 Commit: Navdeep Parhar CommitDate: 2024-04-30 20:02:45 +0000 cxgbe(4): Minor tweaks to comments. No functional change intended. MFC after: 1 week Sponsored by: Chelsio Communications --- sys/dev/cxgbe/t4_main.c | 12 +++++++----- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git a/sys/dev/cxgbe/t4_main.c b/sys/dev/cxgbe/t4_main.c index 1b1adc2f8614..a9611f239132 100644 --- a/sys/dev/cxgbe/t4_main.c +++ b/sys/dev/cxgbe/t4_main.c @@ -5317,9 +5317,13 @@ get_params__post_init(struct adapter *sc) } /* - * MPSBGMAP is queried separately because only recent firmwares support - * it as a parameter and we don't want the compound query above to fail - * on older firmwares. + * The parameters that follow may not be available on all firmwares. We + * query them individually rather than in a compound query because old + * firmwares fail the entire query if an unknown parameter is queried. + */ + + /* + * MPS buffer group configuration. */ param[0] = FW_PARAM_DEV(MPSBGMAP); val[0] = 0; @@ -5331,7 +5335,6 @@ get_params__post_init(struct adapter *sc) /* * Determine whether the firmware supports the filter2 work request. - * This is queried separately for the same reason as MPSBGMAP above. */ param[0] = FW_PARAM_DEV(FILTER2_WR); val[0] = 0; @@ -5343,7 +5346,6 @@ get_params__post_init(struct adapter *sc) /* * Find out whether we're allowed to use the ULPTX MEMWRITE DSGL. - * This is queried separately for the same reason as other params above. */ param[0] = FW_PARAM_DEV(ULPTX_MEMWRITE_DSGL); val[0] = 0;