From nobody Mon Jul 31 06:46:25 2023 X-Original-To: dev-commits-ports-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4RDpgX4v1zz4prdB; Mon, 31 Jul 2023 06:46:42 +0000 (UTC) (envelope-from fernando.apesteguia@gmail.com) Received: from mail-lj1-f177.google.com (mail-lj1-f177.google.com [209.85.208.177]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1D4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4RDpgN70sDz3JWc; Mon, 31 Jul 2023 06:46:40 +0000 (UTC) (envelope-from fernando.apesteguia@gmail.com) Authentication-Results: mx1.freebsd.org; dkim=none; spf=pass (mx1.freebsd.org: domain of fernando.apesteguia@gmail.com designates 209.85.208.177 as permitted sender) smtp.mailfrom=fernando.apesteguia@gmail.com; dmarc=none Received: by mail-lj1-f177.google.com with SMTP id 38308e7fff4ca-2b9ab1725bbso60952621fa.0; Sun, 30 Jul 2023 23:46:40 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1690785999; x=1691390799; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=mq7GPZ3aNB5gekO/X0Ke+elpxeErv2ljku/sn3PR1TI=; b=eg6qUCSqUtIwOn42Lg8xHPtCrBCdygKWnDxo2enb3S3Ctj/ZqQCSUyTsv4KbXtSjb2 NIdM0nBXBrJIlnwb8XmYqrBwpzhMzNa/CdkfazzfE4AZUqkuzVhR9+WouFPNl/QvSpnf wGYGQK+udImyjAyXh/JCOt0AMmTOgqiXydSbBpo+AKPUIX8CTp+aGa3XRYydJCscmqHh JcMutN67NE0QqRJZ+8OhidmRvCawirUc8MHTHlorafJpzxhoajmW0DWd6eVlC1RvFwui q6JYpkothti55UCy+hdrsCfKgMBJKpxckMT0bqnjLeZvMOukRQOblmmgdzaxiEXZgsc6 9F+A== X-Gm-Message-State: ABy/qLaCWctUZJC4dBvuiXN+Zd0SwZ+DIcwpl8yBoJ01oznqVKSJpGsc 9Eek+60CglxxRexOOskJGEhTIHzQikU= X-Google-Smtp-Source: APBJJlGR65zDlB7ZywtWx0/I1sSRpZCtgwVm3VziHQTMlvTiKMBU4kFeBaIN+I6qfhDC6+NdGoNyfA== X-Received: by 2002:a2e:9e51:0:b0:2b4:65ef:3af5 with SMTP id g17-20020a2e9e51000000b002b465ef3af5mr6229745ljk.30.1690785998370; Sun, 30 Jul 2023 23:46:38 -0700 (PDT) Received: from mail-lj1-f182.google.com (mail-lj1-f182.google.com. [209.85.208.182]) by smtp.gmail.com with ESMTPSA id x2-20020a2e9c82000000b002b9ef00b10csm198448lji.2.2023.07.30.23.46.38 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 30 Jul 2023 23:46:38 -0700 (PDT) Received: by mail-lj1-f182.google.com with SMTP id 38308e7fff4ca-2b9c907bc68so50633771fa.2; Sun, 30 Jul 2023 23:46:38 -0700 (PDT) X-Received: by 2002:a2e:8952:0:b0:2b7:33a6:f2c0 with SMTP id b18-20020a2e8952000000b002b733a6f2c0mr6415796ljk.4.1690785997941; Sun, 30 Jul 2023 23:46:37 -0700 (PDT) List-Id: Commits to the main branch of the FreeBSD ports repository List-Archive: https://lists.freebsd.org/archives/dev-commits-ports-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-ports-main@freebsd.org X-BeenThere: dev-commits-ports-main@freebsd.org MIME-Version: 1.0 References: <202307281248.36SCmERV027986@gitrepo.freebsd.org> In-Reply-To: From: =?UTF-8?Q?Fernando_Apestegu=C3=ADa?= Date: Mon, 31 Jul 2023 08:46:25 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: git: 79e5fba255ef - main - cad/PrusaSlicer: update to 2.6.0 To: Alexey Dokuchaev Cc: "ports-committers@FreeBSD.org" , dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org Content-Type: multipart/alternative; boundary="000000000000cc72740601c2ca1e" X-Spamd-Result: default: False [-2.99 / 15.00]; NEURAL_HAM_SHORT(-1.00)[-0.999]; NEURAL_HAM_MEDIUM(-1.00)[-0.998]; NEURAL_HAM_LONG(-1.00)[-0.997]; FORGED_SENDER(0.30)[fernape@freebsd.org,fernandoapesteguia@gmail.com]; R_SPF_ALLOW(-0.20)[+ip4:209.85.128.0/17]; MIME_GOOD(-0.10)[multipart/alternative,text/plain]; RCVD_IN_DNSWL_NONE(0.00)[209.85.208.177:from,209.85.208.182:received]; FROM_NEQ_ENVFROM(0.00)[fernape@freebsd.org,fernandoapesteguia@gmail.com]; MLMMJ_DEST(0.00)[dev-commits-ports-all@freebsd.org,dev-commits-ports-main@freebsd.org]; MIME_TRACE(0.00)[0:+,1:+,2:~]; RWL_MAILSPIKE_POSSIBLE(0.00)[209.85.208.177:from]; FREEMAIL_ENVFROM(0.00)[gmail.com]; R_DKIM_NA(0.00)[]; DMARC_NA(0.00)[freebsd.org]; RCVD_COUNT_THREE(0.00)[4]; ARC_NA(0.00)[]; RCPT_COUNT_THREE(0.00)[4]; RCVD_VIA_SMTP_AUTH(0.00)[]; TO_DN_EQ_ADDR_SOME(0.00)[]; ASN(0.00)[asn:15169, ipnet:209.85.128.0/17, country:US]; TO_DN_SOME(0.00)[]; FROM_HAS_DN(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; RCVD_TLS_LAST(0.00)[]; TAGGED_FROM(0.00)[] X-Rspamd-Queue-Id: 4RDpgN70sDz3JWc X-Spamd-Bar: -- --000000000000cc72740601c2ca1e Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Sat, Jul 29, 2023 at 7:17=E2=80=AFAM Alexey Dokuchaev wrote: > On Fri, Jul 28, 2023 at 04:40:11PM +0200, Fernando Apestegu??a wrote: > > El vie, 28 jul 2023, 15:02, Alexey Dokuchaev escribi??: > > > On Fri, Jul 28, 2023 at 12:48:14PM +0000, Fernando Apestegu??a wrote: > > > > commit 79e5fba255ef2620dd872e21bdd7dc667fea3c19 > > > > > > > > cad/PrusaSlicer: update to 2.6.0 > > > > > > > > PR: 272730 > > > > Reported by: michal.zielonka.8001@gmail.com > > > > Approved by: teodorsigaev@gmail.com (maintainer) > > > > --- > > > > cad/PrusaSlicer/Makefile | 14 +- > > > > cad/PrusaSlicer/distinfo | 6 +- > > > > cad/PrusaSlicer/files/patch-CMakeLists.txt | 19 +- > > > > cad/PrusaSlicer/files/patch-src_CMakeLists.txt | 15 +- > > > > cad/PrusaSlicer/files/patch-src_avrdude_arduino.c | 10 + > > > > .../files/patch-src_libnanosvg_nanosvg.h | 3109 > > > ++++++++++++++++++++ > > > > .../files/patch-src_libnanosvg_nanosvgrast.h | 1485 ++++++++= ++ > > > > > > Who reviewed this? First, we don't create files via patches, and > > > > Maintainer did. It's in the commit log and in the PR. > > Which means they don't have a clue, and you as committer should have > requested this whole mess reworked, not checked in as is. These are > the basics your mentor should have explained, did he not? > You can contact them and ask them. I assume you know how to get that information. About how to contribute to FreeBSD, well, I **don't do** patch review/build testing in all supported platforms I can get my hands on/run testing in clean environments/modernization of old ports/train submitters/etc. But I *keep my fingers crossed when I do git push*. That has to count for something right? Have a nice day. > > ./danfe > --000000000000cc72740601c2ca1e Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable


=
On Sat, Jul 29, 2023 at 7:17=E2=80=AF= AM Alexey Dokuchaev <danfe@freebsd.= org> wrote:
On Fri, Jul 28, 2023 at 04:40:11PM +0200, Fernando Apestegu??a wrote: > El vie, 28 jul 2023, 15:02, Alexey Dokuchaev escribi??:
> > On Fri, Jul 28, 2023 at 12:48:14PM +0000, Fernando Apestegu??a wr= ote:
> > > commit 79e5fba255ef2620dd872e21bdd7dc667fea3c19
> > >
> > >=C2=A0 =C2=A0cad/PrusaSlicer: update to 2.6.0
> > >
> > >=C2=A0 =C2=A0PR:=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0272730
> > >=C2=A0 =C2=A0Reported by:=C2=A0 =C2=A0 michal.zielonka.8001@gmail.co= m
> > >=C2=A0 =C2=A0Approved by:=C2=A0 =C2=A0 teodorsigaev@gmail.com (maintaine= r)
> > > ---
> > >=C2=A0 cad/PrusaSlicer/Makefile=C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0|=C2= =A0 =C2=A014 +-
> > >=C2=A0 cad/PrusaSlicer/distinfo=C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0|=C2= =A0 =C2=A0 6 +-
> > >=C2=A0 cad/PrusaSlicer/files/patch-CMakeLists.txt=C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0|=C2=A0 =C2=A019 +-
> > >=C2=A0 cad/PrusaSlicer/files/patch-src_CMakeLists.txt=C2=A0 = =C2=A0 =C2=A0|=C2=A0 =C2=A015 +-
> > >=C2=A0 cad/PrusaSlicer/files/patch-src_avrdude_arduino.c=C2= =A0 |=C2=A0 =C2=A010 +
> > >=C2=A0 .../files/patch-src_libnanosvg_nanosvg.h=C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0| 3109
> > ++++++++++++++++++++
> > >=C2=A0 .../files/patch-src_libnanosvg_nanosvgrast.h=C2=A0 =C2= =A0 =C2=A0 =C2=A0| 1485 ++++++++++
> >
> > Who reviewed this?=C2=A0 First, we don't create files via pat= ches, and
>
> Maintainer did. It's in the commit log and in the PR.

Which means they don't have a clue, and you as committer should have requested this whole mess reworked, not checked in as is.=C2=A0 These are <= br>
the basics your mentor should have explained, did he not?
<= /div>

You ca= n contact them and ask them. I assume you know how to get that information.=

About= how to contribute to FreeBSD, well, I **don't do** patch review/build = testing in all supported platforms I can get my hands on/run testing in cle= an environments/modernization of old ports/train submitters/etc.
But I *keep my fingers crossed when I do git push*. T= hat has to count for something right?

<= /div>
Have a nice day.
=C2=A0