From owner-cvs-all Tue Nov 19 22:16:41 2002 Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 5377E37B401; Tue, 19 Nov 2002 22:16:40 -0800 (PST) Received: from obsecurity.dyndns.org (adsl-63-207-60-146.dsl.lsan03.pacbell.net [63.207.60.146]) by mx1.FreeBSD.org (Postfix) with ESMTP id 5C2D943E4A; Tue, 19 Nov 2002 22:16:33 -0800 (PST) (envelope-from kris@obsecurity.org) Received: from rot13.obsecurity.org (rot13.obsecurity.org [10.0.0.5]) by obsecurity.dyndns.org (Postfix) with ESMTP id 016F566C61; Tue, 19 Nov 2002 22:16:29 -0800 (PST) Received: by rot13.obsecurity.org (Postfix, from userid 1000) id 06849128D; Tue, 19 Nov 2002 22:16:29 -0800 (PST) Date: Tue, 19 Nov 2002 22:16:28 -0800 From: Kris Kennaway To: Nate Lawson Cc: Kris Kennaway , cvs-committers@FreeBSD.ORG, cvs-all@FreeBSD.ORG Subject: Re: cvs commit: src/sys/cam/scsi scsi_cd.c scsi_cd.h src/sys/dev/ata atapi-cd.c src/sys/sys cdrio.h src/usr.sbin/burncd burncd.8 burncd.c src/usr.sbin/cdcontrol cdcontrol.1 cdcontrol.c Message-ID: <20021120061628.GA9011@rot13.obsecurity.org> References: <20021120022910.GA7969@rot13.obsecurity.org> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="wRRV7LY7NUeQGEoC" Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.4i Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG --wRRV7LY7NUeQGEoC Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Nov 19, 2002 at 09:44:16PM -0800, Nate Lawson wrote: > I will commit a one-line addition that if the value is less than 177, > scale it appropriately. This change won't hurt the new API and > maintaining ABI is nice. Sounds like a good solution. > However, I'm a little dismayed at the review process here. The change has > been in -current for a month with a message saying it would be MFCd in a > month. Not one of the negative comments on the MFC has indicated a single > application outside of our tree that uses our _FreeBSD_only_ ioctl API. = =20 > Neither of the two maintainers who reviewed the patch had a problem with > it. Why didn't you express your concerns earlier? I didn't see the commit..sorry, but shit happens. Kris --wRRV7LY7NUeQGEoC Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.2.1 (FreeBSD) iD8DBQE92yi7Wry0BWjoQKURAir4AJkBaGI7vprVzQm6OtuApkaelkAyVgCeKfJV AnHF6qE5smLQxDuiKEpZsxI= =dl8/ -----END PGP SIGNATURE----- --wRRV7LY7NUeQGEoC-- To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message