Date: Thu, 8 Mar 2012 10:43:44 -0500 From: John Baldwin <jhb@freebsd.org> To: freebsd-current@freebsd.org Cc: freebsd-wireless@freebsd.org, Bernhard Schmidt <bschmidt@freebsd.org> Subject: Re: patches for if_iwi and wlan for WEP mode Message-ID: <201203081043.44801.jhb@freebsd.org> In-Reply-To: <CAJ-Vmo=T4Muzsgafhfq2QLencWdr37-frpQeczn_U4wx5MhwxA@mail.gmail.com> References: <20120306.024212.108736612.iwasaki@jp.FreeBSD.org> <201203072017.44409.bschmidt@freebsd.org> <CAJ-Vmo=T4Muzsgafhfq2QLencWdr37-frpQeczn_U4wx5MhwxA@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Wednesday, March 07, 2012 2:43:52 pm Adrian Chadd wrote: > On 7 March 2012 11:17, Bernhard Schmidt <bschmidt@freebsd.org> wrote: > > On Tuesday 06 March 2012 21:12:55 Adrian Chadd wrote: > >> .. except that the default if_transmit handling breaks fragments. Sigh. > >> > >> So we're going to have to implement if_transmit for all net80211 > >> drivers soon and fix fragment handling. > > > > Not saying that you are wrong, it is unrelated to the issue at hand > > though and I'm not even sure it can be fixed just by replacing > > if_transmit(). Anyways, a bug going unnoticed for 3 years or something > > isn't that high on my priority list. > > Oh, it's absolutely not a requirement here. It was more a comment that > he didn't need to implement if_transmit just yet in order to fix this > bug, but it's likely a good idea moving forward. > > I have recently acquired an iwi(4) NIC so I'll also test this out. > Don't let me stop you though. :) However, you could do that by having a net80211_ifattach() type thing that sets if_transmit and invokes the driver-provided if_start. I don't think wireless devices are using multiple transmit queues in such a way that if_transmit would be a benefit, and if_start is a simpler model. -- John Baldwin
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201203081043.44801.jhb>