From nobody Tue Apr 18 13:02:02 2023 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4Q13wV4T0rz454cj; Tue, 18 Apr 2023 13:02:02 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Q13wV3xdsz4Kgm; Tue, 18 Apr 2023 13:02:02 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1681822922; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=nGDlN11oP/wQIpGdjQLa6v14tYdTGKP+Gt1uPFQBHqU=; b=mXV4WPyaw4thhrN5bqURomOEZyhZ/NI/4ourUaKcOzlztiCukpHBicFbiBC1eqFhhHxaGh p8l9BzLcFCgFNMk485VfFCsM+onkf9uURiKEAmXHqm64Ukw22wFvhr0Cqg2vFTgmlqzlGK XWq97SpxQvOFdtUE5YtrcVMff752uFx010qmnQTJlT/ftvWy/oIxFAAS6ju5yKgFJQEcRd y4/mT3A+EsHCjUYMODAD0NOC750C14scdgn4C+A3NJ/X0Tx3cgPZfeL6194cfML10d2dbC 4B9ZzywYvdyIEwMtV7KKRPPWdlKnF+3keiuA0jEz98LOYsHLY27SI+v6HIhd/w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1681822922; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=nGDlN11oP/wQIpGdjQLa6v14tYdTGKP+Gt1uPFQBHqU=; b=vqXhPo+NHE4tJaYs74WzZg7At0RDvO14Tq/RaBf6X8mI2QbXr9KIRubr4hDwakJj//bplL MqDxUL1tWjFdaBN1d5gRFXN/KjBBs8sMaiioaVPiOn41I6mFhLGe/U1s/Shwzb6ePvCqMp cZ45TyPfbr77CmocC8ASukI1v0ZkVHWdp8Vm6KgzO4kUXKawYAaAfPn5dK01RlMi6dEwp6 jY9dgrKoM1wa/zi4Kao36h52M7qWkcBpW3PWE0DNWibeLAkR2s62PX+kZrp94JquyOs1l5 F4cFATr0ys9CQ2NFZMMXB1c+QqcNr8vjoiGOOSSZtHu2uX6G4xx3fXO9TGJNSg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1681822922; a=rsa-sha256; cv=none; b=ueiZ6vvfcDqZKgt8cULfDhuoizZoN4i7U2AnNCg4QT9oNb1RDgDJ5S4Eid18PCSG03Y89q yC00Hi9btBpSz0SZNqZlLAjOGFo7BiwP33pd4LpAJUmtzIeUFf0n1IAJhLhH7DD2/z+mOw cR4SAYKYrIwsg7TnI5AFcI5eGrsxYb8oTrbUOHevGOnQ4U+/jCC77pVcO6Kf/ZRnDvlxX6 VG0dj4/een/sUnMY3JCX/8oBpgPYQoBcCBATJ6HLxCOVq97BkDvUjH8jibssQhrIjbPVeX zQIfCLChBApTzjh4s38VgOYYyhEx829lERpMfwD/51a4YbLNm5vvm7Pl/2/qCw== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4Q13wV31Lrz1Bm4; Tue, 18 Apr 2023 13:02:02 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.16.1/8.16.1) with ESMTP id 33ID22uj078974; Tue, 18 Apr 2023 13:02:02 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.16.1/8.16.1/Submit) id 33ID22ab078973; Tue, 18 Apr 2023 13:02:02 GMT (envelope-from git) Date: Tue, 18 Apr 2023 13:02:02 GMT Message-Id: <202304181302.33ID22ab078973@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Hans Petter Selasky Subject: git: 3bb3e4768ff8 - main - mlx5: Make MLX5_COMP_EQ_SIZE tunable. List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-all@freebsd.org X-BeenThere: dev-commits-src-all@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: hselasky X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 3bb3e4768ff854b88ba0a7d129edad49f15d7ce3 Auto-Submitted: auto-generated X-ThisMailContainsUnwantedMimeParts: N The branch main has been updated by hselasky: URL: https://cgit.FreeBSD.org/src/commit/?id=3bb3e4768ff854b88ba0a7d129edad49f15d7ce3 commit 3bb3e4768ff854b88ba0a7d129edad49f15d7ce3 Author: Hans Petter Selasky AuthorDate: 2023-04-18 11:11:02 +0000 Commit: Hans Petter Selasky CommitDate: 2023-04-18 13:01:06 +0000 mlx5: Make MLX5_COMP_EQ_SIZE tunable. When using hardware pacing, this value can be increased, because more SQ's means more EQ events aswell. Make it tunable, hw.mlx5.comp_eq_size . MFC after: 1 week Sponsored by: NVIDIA Networking --- sys/dev/mlx5/driver.h | 4 ---- sys/dev/mlx5/mlx5_core/mlx5_main.c | 23 ++++++++++++++++++++++- 2 files changed, 22 insertions(+), 5 deletions(-) diff --git a/sys/dev/mlx5/driver.h b/sys/dev/mlx5/driver.h index 16ada325b1be..47ed4a9d73f3 100644 --- a/sys/dev/mlx5/driver.h +++ b/sys/dev/mlx5/driver.h @@ -805,10 +805,6 @@ struct mlx5_core_dct { u16 uid; }; -enum { - MLX5_COMP_EQ_SIZE = 1024, -}; - enum { MLX5_PTYS_IB = 1 << 0, MLX5_PTYS_EN = 1 << 2, diff --git a/sys/dev/mlx5/mlx5_core/mlx5_main.c b/sys/dev/mlx5/mlx5_core/mlx5_main.c index 6ddeaf64ed89..9e9b7b845528 100644 --- a/sys/dev/mlx5/mlx5_core/mlx5_main.c +++ b/sys/dev/mlx5/mlx5_core/mlx5_main.c @@ -84,6 +84,11 @@ SYSCTL_INT(_hw_mlx5, OID_AUTO, fast_unload_enabled, CTLFLAG_RWTUN, &mlx5_fast_unload_enabled, 0, "Set to enable fast unload. Clear to disable."); +static int mlx5_core_comp_eq_size = 1024; +SYSCTL_INT(_hw_mlx5, OID_AUTO, comp_eq_size, CTLFLAG_RDTUN | CTLFLAG_MPSAFE, + &mlx5_core_comp_eq_size, 0, + "Set default completion EQ size between 1024 and 16384 inclusivly. Value should be power of two."); + static LIST_HEAD(intf_list); static LIST_HEAD(dev_list); static DEFINE_MUTEX(intf_mutex); @@ -178,6 +183,22 @@ static struct mlx5_profile profiles[] = { }, }; +static int +mlx5_core_get_comp_eq_size(void) +{ + int value = mlx5_core_comp_eq_size; + + if (value < 1024) + value = 1024; + else if (value > 16384) + value = 16384; + + /* make value power of two, rounded down */ + while (value & (value - 1)) + value &= (value - 1); + return (value); +} + static void mlx5_set_driver_version(struct mlx5_core_dev *dev) { const size_t driver_ver_sz = @@ -686,7 +707,7 @@ static int alloc_comp_eqs(struct mlx5_core_dev *dev) INIT_LIST_HEAD(&table->comp_eqs_list); ncomp_vec = table->num_comp_vectors; - nent = MLX5_COMP_EQ_SIZE; + nent = mlx5_core_get_comp_eq_size(); for (i = 0; i < ncomp_vec; i++) { eq = kzalloc_node(sizeof(*eq), GFP_KERNEL, dev->priv.numa_node);