From owner-p4-projects@FreeBSD.ORG  Wed Dec  6 00:01:19 2006
Return-Path: <owner-p4-projects@FreeBSD.ORG>
X-Original-To: p4-projects@freebsd.org
Delivered-To: p4-projects@freebsd.org
Received: by hub.freebsd.org (Postfix, from userid 32767)
	id 4474116A416; Wed,  6 Dec 2006 00:01:19 +0000 (UTC)
X-Original-To: perforce@FreeBSD.org
Delivered-To: perforce@FreeBSD.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [69.147.83.52])
	by hub.freebsd.org (Postfix) with ESMTP id 1E09C16A407
	for <perforce@FreeBSD.org>; Wed,  6 Dec 2006 00:01:19 +0000 (UTC)
	(envelope-from zec@FreeBSD.org)
Received: from repoman.freebsd.org (repoman.freebsd.org [69.147.83.41])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 13DCC43CA6
	for <perforce@FreeBSD.org>; Wed,  6 Dec 2006 00:00:37 +0000 (GMT)
	(envelope-from zec@FreeBSD.org)
Received: from repoman.freebsd.org (localhost [127.0.0.1])
	by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id kB601IxD011856
	for <perforce@FreeBSD.org>; Wed, 6 Dec 2006 00:01:18 GMT
	(envelope-from zec@FreeBSD.org)
Received: (from perforce@localhost)
	by repoman.freebsd.org (8.13.6/8.13.4/Submit) id kB601Igq011850
	for perforce@freebsd.org; Wed, 6 Dec 2006 00:01:18 GMT
	(envelope-from zec@FreeBSD.org)
Date: Wed, 6 Dec 2006 00:01:18 GMT
Message-Id: <200612060001.kB601Igq011850@repoman.freebsd.org>
X-Authentication-Warning: repoman.freebsd.org: perforce set sender to
	zec@FreeBSD.org using -f
From: Marko Zec <zec@FreeBSD.org>
To: Perforce Change Reviews <perforce@FreeBSD.org>
Cc: 
Subject: PERFORCE change 111169 for review
X-BeenThere: p4-projects@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: p4 projects tree changes <p4-projects.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/p4-projects>
List-Post: <mailto:p4-projects@freebsd.org>
List-Help: <mailto:p4-projects-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 06 Dec 2006 00:01:19 -0000

http://perforce.freebsd.org/chv.cgi?CH=111169

Change 111169 by zec@zec_tpx32 on 2006/12/06 00:01:10

	Set V_loif to point to the ifnet corresponding to the "lo0"
	interface before calling if_attach() for it.  This is important
	since in rt_dispatch() we mark the looped back mbufs to have
	m_pkthdr.rcvif set to V_loif, so we should guarantee that V_loif
	will be valid at the time the first PF_ROUTE message will be
	generated.
	
	Could be also that I'm fixing symptomps here and not the
	causes, i.e. some kind of leakage between vnet instances.  XXX.

Affected files ...

.. //depot/projects/vimage/src/sys/net/if_loop.c#4 edit

Differences ...

==== //depot/projects/vimage/src/sys/net/if_loop.c#4 (text+ko) ====

@@ -157,6 +157,11 @@
 		free(sc, M_LO);
 		return (ENOSPC);
 	}
+#ifdef VIMAGE
+	ifp->if_vnetb = curvnetb;
+#endif
+	if (V_loif == NULL)
+		V_loif = ifp;
 
 	if_initname(ifp, ifc->ifc_name, unit);
 	ifp->if_mtu = LOMTU;
@@ -170,8 +175,6 @@
 	mtx_lock(&lo_mtx);
 	LIST_INSERT_HEAD(&V_lo_list, sc, sc_next);
 	mtx_unlock(&lo_mtx);
-	if (V_loif == NULL)
-		V_loif = ifp;
 
 	return (0);
 }