From owner-svn-src-head@FreeBSD.ORG Sat Nov 1 11:05:45 2008 Return-Path: Delivered-To: svn-src-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 11E211065676; Sat, 1 Nov 2008 11:05:45 +0000 (UTC) (envelope-from brde@optusnet.com.au) Received: from mail01.syd.optusnet.com.au (mail01.syd.optusnet.com.au [211.29.132.182]) by mx1.freebsd.org (Postfix) with ESMTP id 896938FC18; Sat, 1 Nov 2008 11:05:44 +0000 (UTC) (envelope-from brde@optusnet.com.au) Received: from c122-106-151-199.carlnfd1.nsw.optusnet.com.au (c122-106-151-199.carlnfd1.nsw.optusnet.com.au [122.106.151.199]) by mail01.syd.optusnet.com.au (8.13.1/8.13.1) with ESMTP id mA1B5f8n025247 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Sat, 1 Nov 2008 22:05:42 +1100 Date: Sat, 1 Nov 2008 22:05:41 +1100 (EST) From: Bruce Evans X-X-Sender: bde@delplex.bde.org To: Robert Watson In-Reply-To: <200810311447.m9VElFtp083250@svn.freebsd.org> Message-ID: <20081101212937.D12448@delplex.bde.org> References: <200810311447.m9VElFtp083250@svn.freebsd.org> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r184509 - head/share/man/man9 X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 01 Nov 2008 11:05:45 -0000 On Fri, 31 Oct 2008, Robert Watson wrote: > Log: > In style(9) examples of err() and errx(), use sysexits(3) errors rather > than returning 1. style(9) was correct. Using sysexits(3) is a style bug in most cases, especially in err() and errx() messages where there is a text message and not just a cryptic error code. (Originally, in 4.4BSD, sysexits.3 doesn't exist and /usr/src/admin/style/style had no mention of sysexits.h. What /usr/src/admin/style/style had was a rule to not label every error exit with a unique error code, since this gives a large undocumented set of program-specific error codes which no one remembers. Using sysexits gives the same results in practice -- it gives a large documented set of generic error codes which no one remembers, so it was a bug to change the rule from disallowing lots of error codes to encouraging use of sysexits. In 4.4BSD-Lite2, sysexits.3 still doesn't exist, and sysexits.h is only referred to in 11 .c files. This shows that use of sysexits is very unusual in BSD code. Some FreeBSD users like it and added it to style.9 and some FreeBSD .c files, so it is just unusual in FreeBSD code.) Bruce