From owner-freebsd-ports@FreeBSD.ORG Sat Jun 16 13:18:49 2012 Return-Path: Delivered-To: freebsd-ports@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 2C53C1065673; Sat, 16 Jun 2012 13:18:49 +0000 (UTC) (envelope-from utisoft@gmail.com) Received: from mail-bk0-f54.google.com (mail-bk0-f54.google.com [209.85.214.54]) by mx1.freebsd.org (Postfix) with ESMTP id 800978FC0C; Sat, 16 Jun 2012 13:18:48 +0000 (UTC) Received: by bkvi18 with SMTP id i18so3747080bkv.13 for ; Sat, 16 Jun 2012 06:18:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:from:date :x-google-sender-auth:message-id:subject:to:cc:content-type :content-transfer-encoding; bh=ixiRCqGDhegQkSXOZnHXAoGB/Xf8JHoqGyp8uOwjCho=; b=fogXjFOB26OT/3uZcrdTYpMS3t9c5e/gldCX5r8JNF24zBjRAPukTBabyIxWDRW3JK NbEjG3AaWOO84xexUg8ePZZwnINZdhjBSG9pHP0HLQqJa7nX8H5CHra6T0BVK5qu+V+S r38v5dCWnQbrs2WPZYDzTQpllXF0AfuE9vbUSmDqBIH6HdiS2M6U7fC/mOHPM/5qTtzt gPtfQvCjPUBRdMv9oo840tb+fcsSQCPEPBIFXSdEqUJIXjnzoaz64kiD11feZdHwvjSX Qh2NvnzpYTGxgLogaj+ZK0WsgaC8g6c2iruFSV7cmtR70Ex1BOFP99uyr9+3x3xBF9ZO V8LQ== Received: by 10.204.153.15 with SMTP id i15mr4161846bkw.74.1339852727209; Sat, 16 Jun 2012 06:18:47 -0700 (PDT) MIME-Version: 1.0 Sender: utisoft@gmail.com Received: by 10.204.171.138 with HTTP; Sat, 16 Jun 2012 06:18:16 -0700 (PDT) In-Reply-To: <4FD8AFEC.6070605@FreeBSD.org> References: <4FD8AFEC.6070605@FreeBSD.org> From: Chris Rees Date: Sat, 16 Jun 2012 14:18:16 +0100 X-Google-Sender-Auth: W4m4EBOTC1SJV2uJWLnyxvnTGns Message-ID: To: Matthew Seaman Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Cc: freebsd-ports Subject: Re: [CFT] UNIQUENAME patches X-BeenThere: freebsd-ports@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Porting software to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 16 Jun 2012 13:18:49 -0000 On 13 June 2012 16:21, Matthew Seaman wrote: > > Dear all, > > After recent mention in this list that UNIQUENAME is not actually a > unique name for each port and how obviously non-sensical that is, plus > how it causes various problems with OPTIONS processing and how having a > proper UNIQUENAME will facilitate the new sub-package functionality > currently on the drawing board. > > So, here are some patches: > > =A0 http://people.freebsd.org/~matthew/uniquename/uniquenames.diff > > There's also some data on the effect these have on OPTIONSFILE and > UNIQUENAME values per port in > > =A0 http://people.freebsd.org/~matthew/uniquename/before/* > =A0 http://people.freebsd.org/~matthew/uniquename/after/* > > Summarizing the changes: > > =A0 * UNIQUENAME is now unique per port, and is primarily derived from > =A0 =A0 the port directory name. > > =A0 * Where the port directory name isn't unique (eg. accessibility/orca > =A0 =A0 vs graphics/orca) there is a new UNIQUEPREFIX variable to > =A0 =A0 distinguish the affected ports. =A0This is set for all the LANG > =A0 =A0 specific category ports (arabic, chinese, french, german, hebrew, > =A0 =A0 hungarian, japanese, korean, polish, portuguese, russian, > =A0 =A0 ukranian, vietnamese) to the standard 2 character abbreviation fo= r > =A0 =A0 that LANG. =A0Otherwise it is only set for the specific ports whe= re > =A0 =A0 there is a directory name collision, usually based on the categor= y > =A0 =A0 names. > > =A0 * To avoid accidental non-uniqueness, UNIQUENAME should be treated > =A0 =A0 as a read-only variable by port maintainers. =A0UNIQUEPREFIX shou= ld > =A0 =A0 only be set where necessary to resolve conflicts. =A0All instance= s of > =A0 =A0 ports setting UNIQUENAME have been removed: in the majority of > =A0 =A0 cases, this turned out to be a no-op as the new UNIQUENAME turned > =A0 =A0 out to be the same as what most ports were previously overriding > =A0 =A0 it to. That's great-- though rather than patching colliding-only ports, can't we just add the category to it? .for cat in ${CATEGORIES} UNIQUEPREFIX?=3D ${cat} .endfor (copying the code from PKGCATEGORY; might be better off moving the PKGCATEGORY code up higher and just using that). Chris