From owner-dev-commits-src-all@freebsd.org Tue Jan 19 22:12:42 2021 Return-Path: Delivered-To: dev-commits-src-all@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id BABE54E1808; Tue, 19 Jan 2021 22:12:42 +0000 (UTC) (envelope-from arichardson.kde@gmail.com) Received: from mail-ej1-f43.google.com (mail-ej1-f43.google.com [209.85.218.43]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4DL2vt4kkvz4nmn; Tue, 19 Jan 2021 22:12:42 +0000 (UTC) (envelope-from arichardson.kde@gmail.com) Received: by mail-ej1-f43.google.com with SMTP id rv9so11964034ejb.13; Tue, 19 Jan 2021 14:12:42 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=eKFMosnM7TxYEIy/X2+oL5KLUYQq1cSo/ee8w+NHorc=; b=lI43SFuAq062JqdNUigg5ITGynfyRjSbgU+jCuUC8MdwOTIzgYNh2KInptTFBjgJKi LZcRPqjFJftfWp2fV9O2UDI1trw9+jnuCwQsaPlLCGgj+uf1wMQvp0hdfrG8aHw7l3YR adLAv52pcAJjRwBVjEKw2eD2DA3qAkvFzGscTwOAdEcufzf9sIajQqeDrD2rSttwvxAo 8cWAFfFaQ6V9pZFDyuWOtIdb+3MvFrg2ZV0cIIw4uGq3EiHPEnTY+QRcdjydiwp6tG+N IsJlXNERWIWrgrtB5shYIllDvQ0YGKm5Fi99NswXLEtewmf1tbGaLJn+UmEQuM/XGTkk iJeA== X-Gm-Message-State: AOAM5321+9KBm9GI5+84WbZKtjw6wdyAnXIlKfKQ4JyFs8JwLSJIaVjV cuqXRWdwV2XjIx/k0Eh9mQTyGwEEqr4= X-Google-Smtp-Source: ABdhPJykyZthvi1zXYL2X5fBCPx7/ukDpVHxYC4K9xUbJtdTBX/Xbv2SZO3TIuSpDeO0UKNh7ea/vg== X-Received: by 2002:a17:907:961c:: with SMTP id gb28mr4119481ejc.393.1611094360445; Tue, 19 Jan 2021 14:12:40 -0800 (PST) Received: from mail-wm1-f50.google.com (mail-wm1-f50.google.com. [209.85.128.50]) by smtp.gmail.com with ESMTPSA id di28sm74515edb.71.2021.01.19.14.12.40 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 19 Jan 2021 14:12:40 -0800 (PST) Received: by mail-wm1-f50.google.com with SMTP id m2so1166083wmm.1; Tue, 19 Jan 2021 14:12:40 -0800 (PST) X-Received: by 2002:a7b:cb8a:: with SMTP id m10mr1427193wmi.127.1611094359970; Tue, 19 Jan 2021 14:12:39 -0800 (PST) MIME-Version: 1.0 References: <202101192138.10JLcj1E078724@gitrepo.freebsd.org> <71483E38-0C2A-4A03-99A7-1438A691A975@freebsd.org> In-Reply-To: <71483E38-0C2A-4A03-99A7-1438A691A975@freebsd.org> From: Alexander Richardson Date: Tue, 19 Jan 2021 22:12:29 +0000 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: git: c1a3d7f20696 - main - Remove remaining uses of ${COMPILER_FEATURES:Mc++11} To: Jessica Clarke Cc: "src-committers@freebsd.org" , "dev-commits-src-all@freebsd.org" , "dev-commits-src-main@freebsd.org" Content-Type: text/plain; charset="UTF-8" X-Rspamd-Queue-Id: 4DL2vt4kkvz4nmn X-Spamd-Bar: ---- Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; TAGGED_FROM(0.00)[] X-BeenThere: dev-commits-src-all@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Commit messages for all branches of the src repository List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 19 Jan 2021 22:12:42 -0000 On Tue, 19 Jan 2021 at 21:42, Jessica Clarke wrote: > > On 19 Jan 2021, at 21:38, Alex Richardson wrote: > > diff --git a/usr.sbin/Makefile b/usr.sbin/Makefile > > index bd2f0cbe0797..2e01b0fcf847 100644 > > --- a/usr.sbin/Makefile > > +++ b/usr.sbin/Makefile > > @@ -186,9 +186,7 @@ SUBDIR.${MK_NTP}+= ntp > > SUBDIR.${MK_OPENSSL}+= keyserv > > SUBDIR.${MK_PF}+= ftp-proxy > > SUBDIR.${MK_PKGBOOTSTRAP}+= pkg > > -.if ${COMPILER_FEATURES:Mc++11} > > -SUBDIR.${MK_PMC}+= pmc > > -.endif > > +SUBDIR.${MK_PMC}.${MK_CXX}+= pmc > > src.opts.mk already disables MK_PMC is MK_CXX is no. > > Jess. > Ah I didn't check src.opts. Will revert this part of the commit shortly. Thanks, Alex