From owner-freebsd-hackers@FreeBSD.ORG  Mon Oct 30 05:17:55 2006
Return-Path: <owner-freebsd-hackers@FreeBSD.ORG>
X-Original-To: freebsd-hackers@freebsd.org
Delivered-To: freebsd-hackers@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 992F516A407
	for <freebsd-hackers@freebsd.org>; Mon, 30 Oct 2006 05:17:55 +0000 (UTC)
	(envelope-from dave@endlessdream.org)
Received: from endlessdream.org (mail.dammcomputers.com [63.246.134.222])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 3C45043D45
	for <freebsd-hackers@freebsd.org>; Mon, 30 Oct 2006 05:17:55 +0000 (GMT)
	(envelope-from dave@endlessdream.org)
Received: from [192.168.1.106] [70.126.42.209] by endlessdream.org with ESMTP
	(SMTPD32-8.15) id AB52D390166; Mon, 30 Oct 2006 00:19:14 -0500
Message-ID: <45458BBE.6030103@endlessdream.org>
Date: Mon, 30 Oct 2006 00:21:02 -0500
From: Dave Clausen <dave@endlessdream.org>
User-Agent: Thunderbird 1.5.0.7 (Windows/20060909)
MIME-Version: 1.0
To: freebsd-hackers@freebsd.org
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Process arguments
X-BeenThere: freebsd-hackers@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Technical Discussions relating to FreeBSD
	<freebsd-hackers.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-hackers>, 
	<mailto:freebsd-hackers-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-hackers>
List-Post: <mailto:freebsd-hackers@freebsd.org>
List-Help: <mailto:freebsd-hackers-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-hackers>,
	<mailto:freebsd-hackers-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 30 Oct 2006 05:17:55 -0000

Hello list,

I'm a n00b to the FreeBSD kernel and I'm trying to log all commands run 
on the command line from within the kernel for security purposes by 
loading a kernel module which redefines execve().  I've successfully 
created the KLD and have it working, but am having problems saving the 
command's arguments.
Could anyone point me to where in the kernel I should be looking for the 
arguments sent to the process?  p->p_args gives me the parent process's 
cmdname only (sh, in this case), and uap->argv is just the relative 
pathname of uap->fname.  Ideally, I'd like the user, full command line, 
and cwd logged for each command entered.

Here's an example of what I've been working away on:

int
new_execve (struct thread *td, struct execve_args *uap)
{
       char *user;
       struct proc *p = td->td_proc;

       user = p->p_pgrp->pg_session->s_login;
       if (p->p_ucred->cr_ruid == 1001) {
               printf("%s %d %s\n", user, p->p_pid, uap->fname);
       }
       return (execve(td,uap));
}

Running 'ls -al' with the above, I get the username, pid, and absolute 
filename printed such as, but can't find the actual arguments:
dave 6689 /bin/ls

Any help would be appreciated.