From owner-freebsd-current@FreeBSD.ORG  Thu Nov 19 14:55:19 2009
Return-Path: <owner-freebsd-current@FreeBSD.ORG>
Delivered-To: freebsd-current@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 257DD1065672;
	Thu, 19 Nov 2009 14:55:19 +0000 (UTC) (envelope-from jhb@freebsd.org)
Received: from cyrus.watson.org (cyrus.watson.org [65.122.17.42])
	by mx1.freebsd.org (Postfix) with ESMTP id EE5DB8FC18;
	Thu, 19 Nov 2009 14:55:18 +0000 (UTC)
Received: from bigwig.baldwin.cx (66.111.2.69.static.nyinternet.net
	[66.111.2.69])
	by cyrus.watson.org (Postfix) with ESMTPSA id 9CCF246B2E;
	Thu, 19 Nov 2009 09:55:18 -0500 (EST)
Received: from jhbbsd.hudson-trading.com (unknown [209.249.190.8])
	by bigwig.baldwin.cx (Postfix) with ESMTPA id CB77F8A021;
	Thu, 19 Nov 2009 09:55:17 -0500 (EST)
From: John Baldwin <jhb@freebsd.org>
To: freebsd-current@freebsd.org
Date: Thu, 19 Nov 2009 09:42:19 -0500
User-Agent: KMail/1.9.7
References: <200911182059.35769.hselasky@freebsd.org>
In-Reply-To: <200911182059.35769.hselasky@freebsd.org>
MIME-Version: 1.0
Content-Type: text/plain;
  charset="iso-8859-1"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
Message-Id: <200911190942.19645.jhb@freebsd.org>
X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.0.1
	(bigwig.baldwin.cx); Thu, 19 Nov 2009 09:55:17 -0500 (EST)
X-Virus-Scanned: clamav-milter 0.95.1 at bigwig.baldwin.cx
X-Virus-Status: Clean
X-Spam-Status: No, score=-2.5 required=4.2 tests=AWL,BAYES_00,RDNS_NONE
	autolearn=no version=3.2.5
X-Spam-Checker-Version: SpamAssassin 3.2.5 (2008-06-10) on bigwig.baldwin.cx
Cc: Hans Petter Selasky <hselasky@freebsd.org>
Subject: Re: [PATCH] Panic when inserting PCCARD
X-BeenThere: freebsd-current@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Discussions about the use of FreeBSD-current
	<freebsd-current.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>, 
	<mailto:freebsd-current-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-current>
List-Post: <mailto:freebsd-current@freebsd.org>
List-Help: <mailto:freebsd-current-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
	<mailto:freebsd-current-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 19 Nov 2009 14:55:19 -0000

On Wednesday 18 November 2009 2:59:33 pm Hans Petter Selasky wrote:
> Hi,
> 
> I am sometimes using a PCCARD which panics the FreeBSD 9-current kernel due 
to 
> generating some interrupts immediately when plugged in. Can someone add the 
> required checks to handle spurious interrupts on non-enabled IRQ vectors?
> 
> Backtrace:
> 
> pccard_intr()
> cbb_func_intr()
> intr_event_execute_handlers()
> 
> --HPS
> 
> sys/dev/pccard/pccard.c
> 
> static void
> pccard_intr(void *arg)
> {
>         struct pccard_function *pf = (struct pccard_function*) arg;
> 
> +       if (pf == NULL || pf->intr_handler == NULL) return;
>         pf->intr_handler(pf->intr_handler_arg); 
> }

I don't think 'pf' can ever be NULL here.  However, the second check might be 
valid.  Perhaps Warner (imp@) has a comment though?

-- 
John Baldwin