Date: Tue, 02 Aug 2022 17:43:48 -0700 From: Cy Schubert <Cy.Schubert@cschubert.com> To: Mark Johnston <markj@FreeBSD.org> Cc: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org Subject: Re: git: 1165fc9a5266 - main - ctfconvert: Give bitfield types names distinct from the base type Message-ID: <20220803004348.14C4610F@slippy.cwsent.com> In-Reply-To: <202208030039.2730dCnR016853@gitrepo.freebsd.org> References: <202208030039.2730dCnR016853@gitrepo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
In message <202208030039.2730dCnR016853@gitrepo.freebsd.org>, Mark Johnston wri tes: > The branch main has been updated by markj: > > URL: https://cgit.FreeBSD.org/src/commit/?id=1165fc9a526630487a1feb63daef65c5 > aee1a583 > > commit 1165fc9a526630487a1feb63daef65c5aee1a583 > Author: Mark Johnston <markj@FreeBSD.org> > AuthorDate: 2022-08-03 00:32:17 +0000 > Commit: Mark Johnston <markj@FreeBSD.org> > CommitDate: 2022-08-03 00:32:17 +0000 > > ctfconvert: Give bitfield types names distinct from the base type > > CTF integers have an explicit width and so can be used to represent > bitfields. Bitfield types emitted by ctfconvert(1) share the name of > the base integer type, so a struct field with type "unsigned int : 15" > will have a type named "unsigned int". > > To avoid ambiguity when looking up types by name, add a suffix to names > of bitfield types to distinguish them from the base type. Then, if > ctfmerge happens to order bitfield types before the corresponding base > type in a CTF file, a name lookup will return the base type, which is > always going to be the desired behaviour. > > PR: 265403 > Reported by: cy > MFC after: 1 week > Sponsored by: The FreeBSD Foundation Thank you muchly. -- Cheers, Cy Schubert <Cy.Schubert@cschubert.com> FreeBSD UNIX: <cy@FreeBSD.org> Web: http://www.FreeBSD.org NTP: <cy@nwtime.org> Web: https://nwtime.org e**(i*pi)+1=0
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20220803004348.14C4610F>