From owner-svn-src-stable-8@FreeBSD.ORG  Mon Jul  1 06:58:36 2013
Return-Path: <owner-svn-src-stable-8@FreeBSD.ORG>
Delivered-To: svn-src-stable-8@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by hub.freebsd.org (Postfix) with ESMTP id 1BE97236;
 Mon,  1 Jul 2013 06:58:36 +0000 (UTC)
 (envelope-from yongari@FreeBSD.org)
Received: from svn.freebsd.org (svn.freebsd.org
 [IPv6:2001:1900:2254:2068::e6a:0])
 by mx1.freebsd.org (Postfix) with ESMTP id 0E12511A3;
 Mon,  1 Jul 2013 06:58:36 +0000 (UTC)
Received: from svn.freebsd.org ([127.0.1.70])
 by svn.freebsd.org (8.14.7/8.14.7) with ESMTP id r616wZvG006824;
 Mon, 1 Jul 2013 06:58:35 GMT (envelope-from yongari@svn.freebsd.org)
Received: (from yongari@localhost)
 by svn.freebsd.org (8.14.7/8.14.5/Submit) id r616wZr8006823;
 Mon, 1 Jul 2013 06:58:35 GMT (envelope-from yongari@svn.freebsd.org)
Message-Id: <201307010658.r616wZr8006823@svn.freebsd.org>
From: Pyun YongHyeon <yongari@FreeBSD.org>
Date: Mon, 1 Jul 2013 06:58:35 +0000 (UTC)
To: src-committers@freebsd.org, svn-src-all@freebsd.org,
 svn-src-stable@freebsd.org, svn-src-stable-8@freebsd.org
Subject: svn commit: r252453 - stable/8/sys/dev/bge
X-SVN-Group: stable-8
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
X-BeenThere: svn-src-stable-8@freebsd.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: SVN commit messages for only the 8-stable src tree
 <svn-src-stable-8.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-src-stable-8>, 
 <mailto:svn-src-stable-8-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-stable-8>
List-Post: <mailto:svn-src-stable-8@freebsd.org>
List-Help: <mailto:svn-src-stable-8-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-stable-8>, 
 <mailto:svn-src-stable-8-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 01 Jul 2013 06:58:36 -0000

Author: yongari
Date: Mon Jul  1 06:58:35 2013
New Revision: 252453
URL: http://svnweb.freebsd.org/changeset/base/252453

Log:
  MFC r251481:
    Do not report current link status if driver is not running.
    Reporting link status in driver has a side-effect that makes mii(4)
    check current link status.  mii(4) will call link status change
    callback when it sees link state change.  Normally this wouldn't
    have problems. However, ASF/IPMI firmware can actively access PHY
    regardless of driver's running state such that reporting link
    status for not-running interface can generate meaningless link
    UP/DOWN messages.
  
    This change also makes dhclient think driver got a valid link
    regardless of link establishment so it will bypass dhclient's
    initial link status check. I think that wouldn't be issue
    though.

Modified:
  stable/8/sys/dev/bge/if_bge.c
Directory Properties:
  stable/8/sys/   (props changed)
  stable/8/sys/dev/   (props changed)
  stable/8/sys/dev/bge/   (props changed)

Modified: stable/8/sys/dev/bge/if_bge.c
==============================================================================
--- stable/8/sys/dev/bge/if_bge.c	Mon Jul  1 06:58:05 2013	(r252452)
+++ stable/8/sys/dev/bge/if_bge.c	Mon Jul  1 06:58:35 2013	(r252453)
@@ -5621,6 +5621,10 @@ bge_ifmedia_sts(struct ifnet *ifp, struc
 
 	BGE_LOCK(sc);
 
+	if ((ifp->if_flags & IFF_UP) == 0) {
+		BGE_UNLOCK(sc);
+		return;
+	}
 	if (sc->bge_flags & BGE_FLAG_TBI) {
 		ifmr->ifm_status = IFM_AVALID;
 		ifmr->ifm_active = IFM_ETHER;