From owner-dev-commits-src-all@freebsd.org Wed Apr 21 10:03:43 2021 Return-Path: Delivered-To: dev-commits-src-all@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 18BC05FF14C; Wed, 21 Apr 2021 10:03:43 +0000 (UTC) (envelope-from mpp302@gmail.com) Received: from mail-ej1-f49.google.com (mail-ej1-f49.google.com [209.85.218.49]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4FQGNG2Qb1z4tQW; Wed, 21 Apr 2021 10:03:41 +0000 (UTC) (envelope-from mpp302@gmail.com) Received: by mail-ej1-f49.google.com with SMTP id w23so46852923ejb.9; Wed, 21 Apr 2021 03:03:41 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding :content-language; bh=zwJAisHHP4+fJkN8JS5UFken42ml9/M+Nj7wfenuXBY=; b=kFVxOg7AG3TD3+A25KJQPtKq7gviUuKsD2jIkRkohy5BQ7FqjQKEcKvHfzH7XCGfs4 Fo4+/burPqCWWEum5SnxaFlYdFOdTbQluf2rN2oEjhSWJFzbcfXpyj+CRV/E3MEHOcg5 z6CqU+WSXtWz55Ti854J3W/mWuZVb4Mvz2sXW2z/v7WZ7i8+A5+LMf5N1RoZzwsUhNiB sYwueBTpdVu3OJ170QycZZyUK4kcurM7ZE5b7O4SvXSKVvIetOIIYKdnWDGUC9q1piWt QeW4aZaltrm3IzT659LSr7NrV9igEVbr1JcV/s+emWMv3Ul3xzqFvoP18LYiDfOWGZuA Na3Q== X-Gm-Message-State: AOAM531jHe3KF3J35thp0B21zHm3TkiO5LSo2cQaetqDe5uB3zGAmQYU 4StHWSR65ML5xEU3d+hKoyoN1FfDlXds0b0k X-Google-Smtp-Source: ABdhPJz2qLx87KOD9m1X1GmzNJJ/fXYb9Wku47a+BNXT2CQozGY+uRtZcSKSGNRghdVr4QfxSStsLQ== X-Received: by 2002:a17:906:430f:: with SMTP id j15mr32106150ejm.543.1618999420122; Wed, 21 Apr 2021 03:03:40 -0700 (PDT) Received: from [192.168.0.106] (ip5f5bd493.dynamic.kabel-deutschland.de. [95.91.212.147]) by smtp.gmail.com with ESMTPSA id r17sm2539812edt.70.2021.04.21.03.03.39 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 21 Apr 2021 03:03:39 -0700 (PDT) Subject: Re: git: c4207d867c20 - main - fork.2: Add a simple use pattern To: Konstantin Belousov Cc: src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org References: <202104172113.13HLD6UI014137@gitrepo.freebsd.org> From: Mateusz Piotrowski <0mp@FreeBSD.org> Message-ID: <04cb1d58-a7ca-9ea1-0d69-57251c378794@FreeBSD.org> Date: Wed, 21 Apr 2021 12:03:51 +0200 User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:78.0) Gecko/20100101 Thunderbird/78.9.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US X-Rspamd-Queue-Id: 4FQGNG2Qb1z4tQW X-Spamd-Bar: --- Authentication-Results: mx1.freebsd.org; dkim=none; dmarc=none; spf=pass (mx1.freebsd.org: domain of mpp302@gmail.com designates 209.85.218.49 as permitted sender) smtp.mailfrom=mpp302@gmail.com X-Spamd-Result: default: False [-3.00 / 15.00]; RCVD_VIA_SMTP_AUTH(0.00)[]; RBL_SENDERSCORE_FAIL(0.00)[209.85.218.49:server fail]; TO_DN_SOME(0.00)[]; R_SPF_ALLOW(-0.20)[+ip4:209.85.128.0/17:c]; RWL_MAILSPIKE_GOOD(0.00)[209.85.218.49:from]; RCVD_COUNT_THREE(0.00)[3]; NEURAL_HAM_SHORT(-1.00)[-1.000]; FREEMAIL_TO(0.00)[gmail.com]; FORGED_SENDER(0.30)[0mp@FreeBSD.org,mpp302@gmail.com]; RECEIVED_SPAMHAUS_PBL(0.00)[95.91.212.147:received]; MIME_TRACE(0.00)[0:+]; R_DKIM_NA(0.00)[]; FREEMAIL_ENVFROM(0.00)[gmail.com]; MID_RHS_MATCH_FROM(0.00)[]; FROM_NEQ_ENVFROM(0.00)[0mp@FreeBSD.org,mpp302@gmail.com]; ASN(0.00)[asn:15169, ipnet:209.85.128.0/17, country:US]; ARC_NA(0.00)[]; RBL_DBL_DONT_QUERY_IPS(0.00)[209.85.218.49:from]; NEURAL_HAM_MEDIUM(-1.00)[-1.000]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_THREE(0.00)[4]; NEURAL_HAM_LONG(-1.00)[-1.000]; MIME_GOOD(-0.10)[text/plain]; DMARC_NA(0.00)[FreeBSD.org]; SPAMHAUS_ZRD(0.00)[209.85.218.49:from:127.0.2.255]; TO_MATCH_ENVRCPT_SOME(0.00)[]; RCVD_IN_DNSWL_NONE(0.00)[209.85.218.49:from]; RCVD_TLS_ALL(0.00)[]; MAILMAN_DEST(0.00)[dev-commits-src-main,dev-commits-src-all] X-BeenThere: dev-commits-src-all@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Commit messages for all branches of the src repository List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 21 Apr 2021 10:03:43 -0000 On 20/04/2021 11:58, Konstantin Belousov wrote: > On Sat, Apr 17, 2021 at 09:13:06PM +0000, Mateusz Piotrowski wrote: >> URL: https://cgit.FreeBSD.org/src/commit/?id=c4207d867c201a726aa3157e09262f72166c89c4 >> >> commit c4207d867c201a726aa3157e09262f72166c89c4 >> Author: Mateusz Piotrowski <0mp@FreeBSD.org> >> AuthorDate: 2021-04-17 21:10:48 +0000 >> Commit: Mateusz Piotrowski <0mp@FreeBSD.org> >> CommitDate: 2021-04-17 21:12:06 +0000 >> >> fork.2: Add a simple use pattern >> >> It seems to be a nice idea to show how fork() is usually used in >> practice. This may act as a guide to developers who want to quickly >> recall how to use the fork() function. >> >> Reviewed by: bcr, yuripv >> MFC after: 1 week >> Differential Revision: https://reviews.freebsd.org/D27626 >> > Using printf around fork is not the best idea, and definitely should not > be provided as a guiding example in the man page. Using stdio safely around > fork() requires at least flushing buffers and ensuring that opened FILEs are > in some consistent state right at fork. > > It would work by chance in your example, mostly because you did not used > anything in stdio before fork, but any further changes would result in > very puzzling bugs (for beginners, who are the target of this example). OK, I've opened a revision on Phabricator to address those issues: https://reviews.freebsd.org/D29880