From owner-cvs-all@FreeBSD.ORG  Tue Jan 17 16:47:01 2006
Return-Path: <owner-cvs-all@FreeBSD.ORG>
X-Original-To: cvs-all@freebsd.org
Delivered-To: cvs-all@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id E26E616A41F;
	Tue, 17 Jan 2006 16:47:01 +0000 (GMT) (envelope-from mux@freebsd.org)
Received: from elvis.mu.org (elvis.mu.org [192.203.228.196])
	by mx1.FreeBSD.org (Postfix) with ESMTP id BC79B43D62;
	Tue, 17 Jan 2006 16:47:00 +0000 (GMT) (envelope-from mux@freebsd.org)
Received: by elvis.mu.org (Postfix, from userid 1920)
	id A087F1A3C25; Tue, 17 Jan 2006 08:47:00 -0800 (PST)
Date: Tue, 17 Jan 2006 17:47:00 +0100
From: Maxime Henrion <mux@FreeBSD.org>
To: Alexey Dokuchaev <danfe@FreeBSD.org>
Message-ID: <20060117164700.GN55746@elvis.mu.org>
References: <200512202106.jBKL6hNr035186@repoman.freebsd.org>
	<1CDDC33C-01D5-4AFE-99C0-DE848321D78B@nlsystems.com>
	<200601171111.01942.jhb@freebsd.org>
	<AFC3FB6C-AEE0-483B-919C-EDCD6DC26EAE@nlsystems.com>
	<20060117163014.GA17831@FreeBSD.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20060117163014.GA17831@FreeBSD.org>
User-Agent: Mutt/1.4.2.1i
Cc: cvs-src@freebsd.org, src-committers@freebsd.org,
	Doug Rabson <dfr@nlsystems.com>, cvs-all@freebsd.org,
	John Baldwin <jhb@freebsd.org>
Subject: Re: cvs commit: src/sys/pci agp.c
X-BeenThere: cvs-all@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: CVS commit messages for the entire tree <cvs-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-all>
List-Post: <mailto:cvs-all@freebsd.org>
List-Help: <mailto:cvs-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 17 Jan 2006 16:47:02 -0000

Alexey Dokuchaev wrote:
> On Tue, Jan 17, 2006 at 04:19:07PM +0000, Doug Rabson wrote:
> > 
> > On 17 Jan 2006, at 16:11, John Baldwin wrote:
> > 
> > >On Tuesday 17 January 2006 06:51, Doug Rabson wrote:
> > >>On 20 Dec 2005, at 21:06, John Baldwin wrote:
> > >>>jhb         2005-12-20 21:06:43 UTC
> > >>>
> > >>>  FreeBSD src repository
> > >>>
> > >>>  Modified files:
> > >>>    sys/pci              agp.c
> > >>>  Log:
> > >>>  Change the agp_find_device() to return the first agp device that
> > >>>has been
> > >>>  attached to a driver rather than always returning agp0.
> > >>
> > >>According to Coverity, this introduces a memory leak
> > >>(devclass_get_devices() allocates memory).
> > >
> > >That it does.  How about this fix:
> > 
> > Looks good to me.
> 
> Except for style bugs (parens around return value).

It rather looks like John has followed the existing style in this file,
which is perfectly legitimate.

Cheers,
Maxime