From owner-svn-src-all@FreeBSD.ORG Wed Jan 28 19:25:10 2015 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id DF8EB6E7; Wed, 28 Jan 2015 19:25:10 +0000 (UTC) Received: from tensor.andric.com (tensor.andric.com [87.251.56.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "tensor.andric.com", Issuer "COMODO RSA Domain Validation Secure Server CA" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 99112F74; Wed, 28 Jan 2015 19:25:10 +0000 (UTC) Received: from [IPv6:2001:7b8:3a7::7cc2:15cb:986d:f14e] (unknown [IPv6:2001:7b8:3a7:0:7cc2:15cb:986d:f14e]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by tensor.andric.com (Postfix) with ESMTPSA id B17285C2E; Wed, 28 Jan 2015 20:25:06 +0100 (CET) Subject: Re: svn commit: r277841 - head/contrib/amd/hlfsd Mime-Version: 1.0 (Mac OS X Mail 8.2 \(2070.6\)) Content-Type: multipart/signed; boundary="Apple-Mail=_A897BEAF-DD84-4D6F-BE19-BD563CE2C61B"; protocol="application/pgp-signature"; micalg=pgp-sha1 X-Pgp-Agent: GPGMail 2.5b4 (05244f0+) From: Dimitry Andric In-Reply-To: <20150128190422.GA58164@vlakno.cz> Date: Wed, 28 Jan 2015 20:25:02 +0100 Message-Id: <874F65B6-0C1A-4230-B277-119C31BA31D7@FreeBSD.org> References: <201501281819.t0SIJQG4073269@svn.freebsd.org> <20150128190422.GA58164@vlakno.cz> To: Roman Divacky X-Mailer: Apple Mail (2.2070.6) Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 28 Jan 2015 19:25:11 -0000 --Apple-Mail=_A897BEAF-DD84-4D6F-BE19-BD563CE2C61B Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=us-ascii On 28 Jan 2015, at 20:04, Roman Divacky wrote: > On Wed, Jan 28, 2015 at 06:19:26PM +0000, Dimitry Andric wrote: >> Author: dim >> Date: Wed Jan 28 18:19:25 2015 >> New Revision: 277841 >> URL: https://svnweb.freebsd.org/changeset/base/277841 >>=20 >> Log: >> Fix the following clang 3.6.0 warning in = contrib/amd/hlfsd/homedir.c: >>=20 >> contrib/amd/hlfsd/homedir.c:497:8: error: address of array 'buf' = will >> always evaluate to 'true' [-Werror,-Wpointer-bool-conversion] >> if (!buf || buf[0] =3D=3D '\0') >> ~^~~ >>=20 >> In the affected function, 'buf' is declared as an array of char, so = it >> can never be null. Remove the unecessary check. ... > Given that this is a contributed code - have you sent the fix > upstream? Also, upstream seems to have newer versions of this... Apparently upstream fixed this about six years ago: = http://git.fsl.cs.sunysb.edu/?p=3Dam-utils-6.2.git;a=3Dcommitdiff;h=3De630= 1006ef97d31745f9ffbb17c58cb39d18c6aa#patch9 The last real import for am-utils was about 7 year ago. Maybe it's time for an update, if it is still actively used. -Dimitry --Apple-Mail=_A897BEAF-DD84-4D6F-BE19-BD563CE2C61B Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename=signature.asc Content-Type: application/pgp-signature; name=signature.asc Content-Description: Message signed with OpenPGP using GPGMail -----BEGIN PGP SIGNATURE----- Version: GnuPG/MacGPG2 v2.0.26 iEYEARECAAYFAlTJN5IACgkQsF6jCi4glqM+RQCfTspEEJW1+ngT+rMNL/YkTf8k rncAoP5nCInKY3RPtJPIVkV6JB3mmETO =iWHd -----END PGP SIGNATURE----- --Apple-Mail=_A897BEAF-DD84-4D6F-BE19-BD563CE2C61B--