From owner-freebsd-hackers Sat Dec 15 10: 3:14 2001 Delivered-To: freebsd-hackers@freebsd.org Received: from mail-out1.apple.com (mail-out1.apple.com [17.254.0.52]) by hub.freebsd.org (Postfix) with ESMTP id 2F9EA37B41A for ; Sat, 15 Dec 2001 10:03:12 -0800 (PST) Received: from mailgate1.apple.com (A17-128-100-225.apple.com [17.128.100.225]) by mail-out1.apple.com (8.11.3/8.11.3) with ESMTP id fBFI3Bu26024 for ; Sat, 15 Dec 2001 10:03:11 -0800 (PST) Received: from scv1.apple.com (scv1.apple.com) by mailgate1.apple.com (Content Technologies SMTPRS 4.2.1) with ESMTP id ; Sat, 15 Dec 2001 10:02:45 -0800 Received: from [17.219.180.26] (minshallidsl1.apple.com [17.219.180.26]) by scv1.apple.com (8.11.3/8.11.3) with ESMTP id fBFI2ua23591; Sat, 15 Dec 2001 10:02:56 -0800 (PST) X-Sender: conrad@mail.apple.com (Unverified) Message-Id: In-Reply-To: <89102.1008197808@winston.freebsd.org> References: Message from Poul-Henning Kamp "of Wed, 12 Dec 2001 21:39:11 +0100." <63529.1008189551@critter.freebsd.dk> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Date: Sat, 15 Dec 2001 09:59:48 -0800 To: Jordan Hubbard , Poul-Henning Kamp From: Conrad Minshall Subject: Re: NFS: How to make FreeBSD fall on its face in one easy step Cc: hackers@freebsd.org Sender: owner-freebsd-hackers@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG At 2:56 PM -0800 12/12/01, Jordan Hubbard wrote: >> The only thing I get is a math exception because "closeprob" is zero >> since no -c option was given. >> >> Can you provide some sample parameters please ? > >Hmmm, how strange, now that I look at the code it's obvious that a >divide by zero will occur with a zero closeprob and the docs state the >default to be "infinity", which is obviously not the case. The >strange part is that I ran this on freebsd.apple.com, which is running >4.4-stable, with one parameter (the filename) exactly as I pasted in >the usage instructions before. Perhaps all this time spent living >next to the Macintosh in my office has induced that copy of FreeBSD to >be more "friendly" and mask simple math errors. :-) > >In any case, -c 1 appears to work just fine. That gives a close/open between each "operation". Better is to fix the fsx.c source by inserting an "if" in main()... diff -u -d -b -w -r1.21 fsx.c --- fsx.c 2001/12/11 23:27:20 1.21 +++ fsx.c 2001/12/15 15:31:19 @@ -701,6 +701,7 @@ testcalls++; + if (closeprob) closeopen = (rv >> 3) < (1 << 28) / closeprob; if (debugstart > 0 && testcalls >= debugstart) -- Conrad Minshall, conrad@apple.com, 408 974-2749 Apple Computer, Mac OS X Core Operating Systems To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-hackers" in the body of the message