From owner-svn-src-head@FreeBSD.ORG Thu Apr 17 16:54:50 2014 Return-Path: Delivered-To: svn-src-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 6C438EE2; Thu, 17 Apr 2014 16:54:50 +0000 (UTC) Received: from mail-oa0-x234.google.com (mail-oa0-x234.google.com [IPv6:2607:f8b0:4003:c02::234]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 15FE816E0; Thu, 17 Apr 2014 16:54:50 +0000 (UTC) Received: by mail-oa0-f52.google.com with SMTP id l6so718740oag.39 for ; Thu, 17 Apr 2014 09:54:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:content-type:message-id:mime-version:subject:date:references :to:in-reply-to; bh=Pot1DA34+bSGphOetaovzY51EYhtmEqB0M7nOu3s/3c=; b=VA6RPItY20af7YRsC+4mcefi/t6ad6WQUaG9REhVmTGq3v2H1SnJTMY9ov5faR+Ysy OK4lkKjMvq456AaEK6ok42Slku0EHoqGloqfD9RW6DSKuE5RIdQQVyMwtVCXBT4P+hB6 TV87yCkVTMkRVJ6uH8A1cFoyLcPhaVUqBpCMfpuE2HBM7/H2suby99/htQaA9z2pJize HlA8fY2ZxGdby4jJlMfLRTuoQCDOkksWSDp4336u8HvVwVrk2/hsFKv0Fq7cUy/UpFN+ n5FFXTjmwzk8Ik8rpJnY5ol3hXcehthspcWzTxVPxT8cklafwo5E5FQCHIJr1Ml7OHDV AQjA== X-Received: by 10.182.24.69 with SMTP id s5mr8236017obf.35.1397753689355; Thu, 17 Apr 2014 09:54:49 -0700 (PDT) Received: from [172.22.132.60] ([192.119.231.58]) by mx.google.com with ESMTPSA id np9sm46656399obc.12.2014.04.17.09.54.47 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Thu, 17 Apr 2014 09:54:48 -0700 (PDT) From: Guy Helmer Content-Type: multipart/signed; boundary="Apple-Mail=_C3830BCC-5507-4B1A-8426-561FC9D0897F"; protocol="application/pgp-signature"; micalg=pgp-sha512 Message-Id: Mime-Version: 1.0 (Mac OS X Mail 7.2 \(1874\)) Subject: Re: svn commit: r264617 - head/libexec/atrun Date: Thu, 17 Apr 2014 11:54:45 -0500 References: <201404171600.s3HG0Rvf019250@svn.freebsd.org> To: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org In-Reply-To: <201404171600.s3HG0Rvf019250@svn.freebsd.org> X-Mailer: Apple Mail (2.1874) X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.17 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 17 Apr 2014 16:54:50 -0000 --Apple-Mail=_C3830BCC-5507-4B1A-8426-561FC9D0897F Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=us-ascii On Apr 17, 2014, at 11:00 AM, Guy Helmer wrote: > Author: ghelmer > Date: Thu Apr 17 16:00:26 2014 > New Revision: 264617 > URL: http://svnweb.freebsd.org/changeset/base/264617 >=20 > Log: > Fix releasing the lock in the parent atrun process after the queue > directory has been processed. Otherwise, a long-running child process > caused other atrun invocations to stall unnecessarily. >=20 I neglected to note that this was submitted by J.R. Oldroyd jr at = opal.com > Modified: > head/libexec/atrun/atrun.c >=20 > Modified: head/libexec/atrun/atrun.c > = =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D > --- head/libexec/atrun/atrun.c Thu Apr 17 15:44:21 2014 = (r264616) > +++ head/libexec/atrun/atrun.c Thu Apr 17 16:00:26 2014 = (r264617) > @@ -567,6 +567,12 @@ main(int argc, char *argv[]) > if (run_batch && (gloadavg() < load_avg)) > run_file(batch_name, batch_uid, batch_gid); >=20 > + if (flock(dirfd(spool), LOCK_UN) =3D=3D -1) > + perr("cannot unlock %s", ATJOB_DIR); > + > + if (closedir(spool) =3D=3D -1) > + perr("cannot closedir %s", ATJOB_DIR); > + > closelog(); > exit(EXIT_SUCCESS); > } >=20 --Apple-Mail=_C3830BCC-5507-4B1A-8426-561FC9D0897F Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename=signature.asc Content-Type: application/pgp-signature; name=signature.asc Content-Description: Message signed with OpenPGP using GPGMail -----BEGIN PGP SIGNATURE----- Comment: GPGTools - https://gpgtools.org iQEcBAEBCgAGBQJTUAdVAAoJEJmJzK+PHOvEZVEH/3cVBr03KnwzSOHH3S/5M77R PAlMx2eDxaBJqzcN0cAxrPtOmFnWTIUL3H29sNDCkGSVwM/B0ITrOxQfmxCqCbI7 MuCNIjDz04HnmauBcZierjs/N8KG7pn7x/pjQ0DKFMi6bpvWVY16mE1/ZQqS7SjK 43zxUlZJhG9RCQYZZWBurpgWQgltcMulZBDgH3891tQ7Z2i2hkj5kj/GRDbTdkIw 64YJ1cGl0PKi+rzLiCavzxlG7YWS1EKsECR3yE3AUDmLYMjKzOA3GTva3+McU0R+ JyRIEVegVKwASAdOliq/JjlX3GJV9EJR6aEOvSFtZiQSUCEL+J8K0ExmQGwb2i4= =yQc0 -----END PGP SIGNATURE----- --Apple-Mail=_C3830BCC-5507-4B1A-8426-561FC9D0897F--