Skip site navigation (1)Skip section navigation (2)
Date:      Sat, 26 Sep 2015 02:15:16 -0700
From:      Colin Percival <cperciva@freebsd.org>
To:        "freebsd-acpi@freebsd.org" <freebsd-acpi@freebsd.org>, Jung-uk Kim <jkim@FreeBSD.org>, John Baldwin <jhb@freebsd.org>, ian Smith <smithi@nimnet.asn.au>
Subject:   Re: disabling sleep when shutting down
Message-ID:  <56066224.6020503@freebsd.org>
In-Reply-To: <56065D33.7080109@obluda.cz>
References:  <55FA3848.7090802@freebsd.org> <55FB233D.2080000@FreeBSD.org> <55FB48E3.20401@freebsd.org> <55FC4F13.3090603@FreeBSD.org> <55FC57F9.3050702@yahoo.com> <55FE5D54.1030806@freebsd.org> <5601A863.5070406@FreeBSD.org> <560262BF.7090107@freebsd.org> <5602DE8D.3020102@FreeBSD.org> <560648A7.4030708@freebsd.org> <56065D33.7080109@obluda.cz>

next in thread | previous in thread | raw e-mail | index | archive | help
On 09/26/15 01:54, Dan Lukes wrote:
> Colin Percival wrote:
>> I've written (but not yet actually compiled or tested, so beware of typos) a patch which I think makes sense.
> 
> It look good.
> 
> But it seems to me the goal has been lost during discussion. It has been
> started because of unwilling interaction of LID close and ongoing
> shutdown, isn't it ?

Yes, I tripped over this in the context of "tell FreeBSD to shut down, then
close the lid of my laptop".

> Unless I misunderstood the code, your patch seems to solve it for
> special case only:
> hw.acpi.lid_switch_state=S3
> 
> But what about Sx states for x -ne 3 ?
> 
> I don't feel to be expert on ACPI code, thus it's possible those states
> are handled (=ignored) correctly as well. In such case ignore this message.

I may be wrong, but I believe all the ACPI Sx states go through the same
function which is checking for suspend_blocked in my patch.

-- 
Colin Percival
Security Officer Emeritus, FreeBSD | The power to serve
Founder, Tarsnap | www.tarsnap.com | Online backups for the truly paranoid



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?56066224.6020503>