From owner-svn-src-projects@FreeBSD.ORG Mon Apr 28 14:45:26 2014 Return-Path: Delivered-To: svn-src-projects@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 828A2D64; Mon, 28 Apr 2014 14:45:26 +0000 (UTC) Received: from bigwig.baldwin.cx (bigwig.baldwin.cx [IPv6:2001:470:1f11:75::1]) (using TLSv1 with cipher DHE-RSA-CAMELLIA256-SHA (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 5ACBE1708; Mon, 28 Apr 2014 14:45:26 +0000 (UTC) Received: from ralph.baldwin.cx (pool-173-70-85-31.nwrknj.fios.verizon.net [173.70.85.31]) by bigwig.baldwin.cx (Postfix) with ESMTPSA id 54571B94A; Mon, 28 Apr 2014 10:45:25 -0400 (EDT) From: John Baldwin To: Mark Murray Subject: Re: svn commit: r265045 - projects/random_number_generator/sys/dev/random Date: Mon, 28 Apr 2014 09:12:52 -0400 Message-ID: <2404556.5ed5qdM2Fl@ralph.baldwin.cx> User-Agent: KMail/4.10.5 (FreeBSD/10.0-STABLE; KDE/4.10.5; amd64; ; ) In-Reply-To: <201404280751.s3S7p8Sg008554@svn.freebsd.org> References: <201404280751.s3S7p8Sg008554@svn.freebsd.org> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.2.7 (bigwig.baldwin.cx); Mon, 28 Apr 2014 10:45:25 -0400 (EDT) Cc: svn-src-projects@freebsd.org, src-committers@freebsd.org X-BeenThere: svn-src-projects@freebsd.org X-Mailman-Version: 2.1.17 Precedence: list List-Id: "SVN commit messages for the src " projects" tree" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 28 Apr 2014 14:45:26 -0000 On Monday, April 28, 2014 07:51:08 AM Mark Murray wrote: > Author: markm > Date: Mon Apr 28 07:51:07 2014 > New Revision: 265045 > URL: http://svnweb.freebsd.org/changeset/base/265045 > > Log: > It turns out powerpc also doesn't have __uint128_t. > > Modified: > projects/random_number_generator/sys/dev/random/uint128.h > > Modified: projects/random_number_generator/sys/dev/random/uint128.h > ============================================================================ > == --- projects/random_number_generator/sys/dev/random/uint128.h Mon Apr 28 > 07:50:45 2014 (r265044) +++ > projects/random_number_generator/sys/dev/random/uint128.h Mon Apr 28 > 07:51:07 2014 (r265045) @@ -34,7 +34,7 @@ > * Everyone knows you always need the __uint128_t types! > */ > > -#if !defined(__arm__) && !defined(__mips__) && !defined(__i386__) && > !defined(__pc98__) +#if !defined(__arm__) && !defined(__mips__) && > !defined(__i386__) && !defined(__pc98__) && !defined(__powerpc__) /* We do > have an inbuilt __uint128_t type */ A better test would be to use #ifdef __SIZEOF_INT128__ instead of listing architectures. (Especially given it might be true on a given platform based on compiler options like -march.) This is what Boost uses to detect a native 128-bit integer and works with both GCC and clang. -- John Baldwin