Skip site navigation (1)Skip section navigation (2)
Date:      Mon, 17 Dec 2012 21:45:57 +0100
From:      Baptiste Daroussin <bapt@FreeBSD.org>
To:        Marius Strobl <marius@alchemy.franken.de>
Cc:        svn-ports-head@freebsd.org, Wesley Shields <wxs@freebsd.org>, svn-ports-all@freebsd.org, ports-committers@freebsd.org
Subject:   Re: svn commit: r309126 - head/audio/aumix
Message-ID:  <20121217204557.GC68303@ithaqua.etoilebsd.net>
In-Reply-To: <20121217203633.GA57454@alchemy.franken.de>
References:  <201212172002.qBHK2Bwf057818@svn.freebsd.org> <20121217203633.GA57454@alchemy.franken.de>

next in thread | previous in thread | raw e-mail | index | archive | help

--ctP54qlpMx3WjD+/
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Mon, Dec 17, 2012 at 09:36:33PM +0100, Marius Strobl wrote:
> On Mon, Dec 17, 2012 at 08:02:11PM +0000, Wesley Shields wrote:
> > Author: wxs
> > Date: Mon Dec 17 20:02:10 2012
> > New Revision: 309126
> > URL: http://svnweb.freebsd.org/changeset/ports/309126
> >=20
> > Log:
> >   Convert to new options.
> >  =20
> >   PR:		ports/173783
> >   Submitted by:	Chris Petrik <c.petrik.sosa@gmail.com>
> >   Approved by:	maintainer timeout
> >=20
> > Modified:
> >   head/audio/aumix/Makefile   (contents, props changed)
> >=20
> > Modified: head/audio/aumix/Makefile
> > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D
> > --- head/audio/aumix/Makefile	Mon Dec 17 20:00:53 2012	(r309125)
> > +++ head/audio/aumix/Makefile	Mon Dec 17 20:02:10 2012	(r309126)
> > @@ -1,9 +1,5 @@
> > -# New ports collection makefile for:	aumix
> > -# Date created:        21 May 1999
> > -# Whom:                Chris Piazza <cpiazza@FreeBSD.org>
> > -#
> > +# Created by: Chris Piazza <cpiazza@FreeBSD.org>
> >  # $FreeBSD$
> > -#
> > =20
> >  PORTNAME=3D	aumix
> >  PORTVERSION=3D	2.9.1
> > @@ -34,11 +30,12 @@ PLIST_FILES=3D	bin/aumix bin/mute bin/xaum
> >  PLIST_FILES+=3D	share/aumix/${ii}
> >  .endfor
> > =20
> > -OPTIONS=3D	NLS	"Enable NLS support" on \
> > -		GTK2	"Enable GTK2 gui" off
> > +.include <bsd.port.options.mk>
> > =20
> > -.include <bsd.port.pre.mk>
> > -.if defined(WITHOUT_NLS)
> > +OPTIONS_DEFINE=3D	NLS GTK2
> > +OPTIONS_DEFAULT=3D	NLS
> > +
> > +.if ${PORT_OPTIONS:MNLS}
> >  CONFIGURE_ARGS+=3D--disable-nls
> >  .else
> >  USE_GETTEXT=3D	yes
>=20
> Uhm, doesn't that have the NLS bits inverted now?
>=20
> Marius
>=20

Yes it has, I have missed it in first review

regards,
Bapt

--ctP54qlpMx3WjD+/
Content-Type: application/pgp-signature

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.19 (FreeBSD)

iEYEARECAAYFAlDPhIUACgkQ8kTtMUmk6Ewt8QCfZJ1RMhbSWVas4NUtwiHwpap4
N5gAnj4xHc8hakpFIs3N0mOx6A0CGgk9
=B8nq
-----END PGP SIGNATURE-----

--ctP54qlpMx3WjD+/--



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20121217204557.GC68303>