Date: Fri, 5 May 2000 20:28:52 +0100 From: Joe Karthauser <joe@pavilion.net> Cc: cvs-committers@FreeBSD.ORG, cvs-all@FreeBSD.ORG Subject: Re: cvs commit: src/usr.bin/chflags chflags.c [Heads up?] Message-ID: <20000505202851.A20115@pavilion.net> In-Reply-To: <20000430192252.A72668@pavilion.net>; from joe@pavilion.net on Sun, Apr 30, 2000 at 07:22:52PM %2B0100 References: <200004041412.HAA01023@freefall.freebsd.org> <20000430192252.A72668@pavilion.net>
next in thread | previous in thread | raw e-mail | index | archive | help
I only received one reply to this so I'm guessing that no-one else minds.
[I know that we've all been preoccupied with restructuring documents ;)]
It's been suggested the {g|s}etflagsbyname is a better set of
function names, and I'm inclined to agree. I'm going to commit
this next week, unless there are serious objections in advance.
(I'm away for a few days so won't get any commit mail until Monday,
but I will check for replies before I commit anything.)
Joe
On Sun, Apr 30, 2000 at 07:22:52PM +0100, Joe Karthauser wrote:
> On Tue, Apr 04, 2000 at 07:12:36AM -0700, Bruce Evans wrote:
> > bde 2000/04/04 07:12:36 PDT
> >
> > Modified files:
> > usr.bin/chflags chflags.c
> > Log:
> > Fixed prototype for setflags(). setflags() returns int, not u_long,
> > and "extern" in function prototypes is a style bug. The type mismatch
> > broke chflags(1) on i386's with 64-bit longs and may have broken it on
> > alphas.
>
> I want to revisit this issue now that the 4.0 release is well out
> of the way. There was a lot of discussion that {g|s}etflags are
> too generic names for these functions. Does anyone have a constructive
> opinion of why I shouldn't rename them to {g|s}etfflags instead
> and re-add them to libc? (Would that require a minor version bump
> also?)
>
> Joe
>
> p.s. for those who don't know, these functions provide the ability
> to translate between the u_long and string representions of chflags
> style file flags (schg, nodump, uunlnk, etc).
>
> They're used by 'ls -ol', chflags, install, find, mtree, amongst
> others.
>
> pps. they were named {g|s}setflags in keeping with the preexisting
> {g|s}etmode function calls for manipulating file modes.
>
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20000505202851.A20115>