From owner-svn-src-all@FreeBSD.ORG  Sun May 10 10:15:37 2015
Return-Path: <owner-svn-src-all@FreeBSD.ORG>
Delivered-To: svn-src-all@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115])
 (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by hub.freebsd.org (Postfix) with ESMTPS id B20D7CAD;
 Sun, 10 May 2015 10:15:37 +0000 (UTC)
Received: from svn.freebsd.org (svn.freebsd.org
 [IPv6:2001:1900:2254:2068::e6a:0])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client did not present a certificate)
 by mx1.freebsd.org (Postfix) with ESMTPS id A03EF1B18;
 Sun, 10 May 2015 10:15:37 +0000 (UTC)
Received: from svn.freebsd.org ([127.0.1.70])
 by svn.freebsd.org (8.14.9/8.14.9) with ESMTP id t4AAFbXO036697;
 Sun, 10 May 2015 10:15:37 GMT (envelope-from bapt@FreeBSD.org)
Received: (from bapt@localhost)
 by svn.freebsd.org (8.14.9/8.14.9/Submit) id t4AAFbU6036696;
 Sun, 10 May 2015 10:15:37 GMT (envelope-from bapt@FreeBSD.org)
Message-Id: <201505101015.t4AAFbU6036696@svn.freebsd.org>
X-Authentication-Warning: svn.freebsd.org: bapt set sender to bapt@FreeBSD.org
 using -f
From: Baptiste Daroussin <bapt@FreeBSD.org>
Date: Sun, 10 May 2015 10:15:37 +0000 (UTC)
To: src-committers@freebsd.org, svn-src-all@freebsd.org,
 svn-src-head@freebsd.org
Subject: svn commit: r282719 - head/usr.sbin/pw
X-SVN-Group: head
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
X-BeenThere: svn-src-all@freebsd.org
X-Mailman-Version: 2.1.20
Precedence: list
List-Id: "SVN commit messages for the entire src tree \(except for &quot;
 user&quot; and &quot; projects&quot; \)" <svn-src-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-all/>
List-Post: <mailto:svn-src-all@freebsd.org>
List-Help: <mailto:svn-src-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sun, 10 May 2015 10:15:37 -0000

Author: bapt
Date: Sun May 10 10:15:36 2015
New Revision: 282719
URL: https://svnweb.freebsd.org/changeset/base/282719

Log:
  The initial logic for allocating the new string was wrong, the conversion
  to strndup(3) duplicated the same mistake, actually strdup(3) is good enough
  to allocate the new string.

Modified:
  head/usr.sbin/pw/pw_conf.c

Modified: head/usr.sbin/pw/pw_conf.c
==============================================================================
--- head/usr.sbin/pw/pw_conf.c	Sun May 10 10:02:09 2015	(r282718)
+++ head/usr.sbin/pw/pw_conf.c	Sun May 10 10:15:36 2015	(r282719)
@@ -213,15 +213,12 @@ char           *
 newstr(char const * p)
 {
 	char	*q;
-	size_t	 l;
 
 	if ((p = unquote(p)) == NULL)
 		return (NULL);
 
-	l = strlen(p) + 1;
-
-	if ((q = strndup(p, l)) == NULL)
-		err(1, "strndup()");
+	if ((q = strdup(p)) == NULL)
+		err(1, "strdup()");
 
 	return (q);
 }