From owner-svn-src-head@freebsd.org Thu Nov 24 16:31:13 2016 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 2256EC53815; Thu, 24 Nov 2016 16:31:13 +0000 (UTC) (envelope-from araujobsdport@gmail.com) Received: from mail-yw0-x22b.google.com (mail-yw0-x22b.google.com [IPv6:2607:f8b0:4002:c05::22b]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id D34F96BD; Thu, 24 Nov 2016 16:31:12 +0000 (UTC) (envelope-from araujobsdport@gmail.com) Received: by mail-yw0-x22b.google.com with SMTP id i145so43161905ywg.2; Thu, 24 Nov 2016 08:31:12 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:reply-to:in-reply-to:references:from:date:message-id :subject:to:cc; bh=6VSGynMZguh+8LZXhzosnRlGAzeRFcS0Rc+L5gaelpE=; b=iQFdhDBJAQ/1I8FdpoBPokVFK7LoIE1IGEQ1Yjm6Ak4G6BsCUdDjeAQB56CHfHQQMP 9r/kKdYJO3AHck9kjadGRYkBmYwXk71OPQ5SSnEgg6fsp3QJ5pKzGHWEZ8Kwo4N4t2qn aehUjLpXxWmtAtW3uX7hF7DQ4ISTBvr3sBL1Pc4LzpRetbBy7kIY2HoWLWZrksLKckS9 hyfulc0myiVVIEjj8S+Q3AfaXseb6iO6gta5FQJVt7vClE1pAEO3pGCTjva3Tg7f8iif RDN8SlO1oKK3Lc5BCD80E6g+6p70pROK3MEENpIRzlaYXhVtuAIkuUSPiiO+wNcRj15w xsBQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:reply-to:in-reply-to:references :from:date:message-id:subject:to:cc; bh=6VSGynMZguh+8LZXhzosnRlGAzeRFcS0Rc+L5gaelpE=; b=JMejXsMVF0Hzoq8lc/dRcRy3SzFG9Gpd//0Ms4DT7sfsvBBZ5EH0gh7V/B3TJN9BK/ 4NlZgnWjp7t7D37Lw5MWJb1RAzxoYnEinmbO+i/WZkxhX/7VWPllHhSuu7fO1f4fNiW3 r0ySjD7YNtrGTnPYDwt1oFqa5wR2MURYOPT5hNxvYjcQWYg5532f3GL8JvTNlY2L6YFT NoHepaLeWomjzaqepYVgLbP2nwKhrqH02JpN8pM5Y9MDHodSPPQwx/QUt4WyF6WsbUJR Rme161RP46gtHgmNqQnqC8lUdOVuR7ak/1Hnr9mehePix+o783+jyzKo2SxJjyApU5jh i9Kw== X-Gm-Message-State: AKaTC02b1HCWwF/ozknSMKPTXavWA6Cj94ybI/6/XmHwn3VVvXy5ME4yPlV+7McacpMy1Pn6mBeFbsbbg6yHXg== X-Received: by 10.129.78.207 with SMTP id c198mr3903847ywb.295.1480005072069; Thu, 24 Nov 2016 08:31:12 -0800 (PST) MIME-Version: 1.0 Received: by 10.129.163.194 with HTTP; Thu, 24 Nov 2016 08:31:11 -0800 (PST) Received: by 10.129.163.194 with HTTP; Thu, 24 Nov 2016 08:31:11 -0800 (PST) Reply-To: araujo@freebsd.org In-Reply-To: <861sy0n8re.fsf@desk.des.no> References: <201611241450.uAOEoLA5079215@repo.freebsd.org> <861sy0n8re.fsf@desk.des.no> From: Marcelo Araujo Date: Fri, 25 Nov 2016 00:31:11 +0800 Message-ID: Subject: Re: svn commit: r309109 - head/lib/libutil To: =?UTF-8?Q?Dag=2DErling_Sm=C3=B8rgrav?= Cc: src-committers@freebsd.org, svn-src-head@freebsd.org, araujo@freebsd.org, svn-src-all@freebsd.org Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Content-Filtered-By: Mailman/MimeDel 2.1.23 X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 24 Nov 2016 16:31:13 -0000 On Nov 25, 2016 12:27 AM, "Dag-Erling Sm=C3=B8rgrav" wrote: > > Marcelo Araujo writes: > > We have code review, we have some many ways for communication, even > > revert a commit if needed. > > No. This is the kind of mistake where the code will seem to work just > fine and end up in a release before a user suddenly discovers that they > have two instances of the same daemon running and trashing their data. > If I remember correctly, the last time someone touched flopen(), > everything worked except 'service mountd reload' stopped working. > > > Everybody can read the svn history. > > Yeah, but they don't. And before you say MAINTAINERS, they don't read > or respect that either. Believe me, I have years of experience cleaning > up after unapproved, unreviewed commits to code I maintain. Conversely, > another committer once reverted a commit they had reviewed and approved > because they thought I hadn't committed it and hit 'y' blindly when > patch told them it was already applied. > > DES > -- > Dag-Erling Sm=C3=B8rgrav - des@des.no Ok, I understand your frustration, and I apologize about my previous email, but you are a developer that most of people respect in this community. You definitely has voice to solve it in a different way. Best,