From owner-freebsd-ports@FreeBSD.ORG Mon Jun 23 12:26:40 2008 Return-Path: Delivered-To: freebsd-ports@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id CB9B3106564A for ; Mon, 23 Jun 2008 12:26:40 +0000 (UTC) (envelope-from shuvaev@physik.uni-wuerzburg.de) Received: from mailrelay.rz.uni-wuerzburg.de (wrzx28.rz.uni-wuerzburg.de [132.187.3.28]) by mx1.freebsd.org (Postfix) with ESMTP id 4FFE78FC17 for ; Mon, 23 Jun 2008 12:26:39 +0000 (UTC) (envelope-from shuvaev@physik.uni-wuerzburg.de) Received: from virusscan.mail (localhost [127.0.0.1]) by mailrelay.mail (Postfix) with ESMTP id CCD85198E3B for ; Mon, 23 Jun 2008 14:26:38 +0200 (CEST) Received: from localhost (localhost [127.0.0.1]) by virusscan.mail (Postfix) with ESMTP id BF9EB198E08 for ; Mon, 23 Jun 2008 14:26:38 +0200 (CEST) Received: from mail.physik.uni-wuerzburg.de (wthp192.physik.uni-wuerzburg.de [132.187.40.192]) by mailmaster.uni-wuerzburg.de (Postfix) with ESMTP id AA85C198DBD for ; Mon, 23 Jun 2008 14:26:38 +0200 (CEST) Received: from wep4017.physik.uni-wuerzburg.de ([132.187.37.17]) by mail.physik.uni-wuerzburg.de (Lotus Domino Release 8.0.1HF110) with ESMTP id 2008062314263791-60864 ; Mon, 23 Jun 2008 14:26:37 +0200 Received: by wep4017.physik.uni-wuerzburg.de (sSMTP sendmail emulation); Mon, 23 Jun 2008 14:26:37 +0200 From: "Alexey Shuvaev" Date: Mon, 23 Jun 2008 14:26:37 +0200 To: freebsd-ports@freebsd.org Message-ID: <20080623122637.GA51758@wep4017.physik.uni-wuerzburg.de> References: <20080622020728.GC13734@server.vk2pj.dyndns.org> <485DF018.5020703@FreeBSD.org> <485F4B7E.3040905@FreeBSD.org> <485F4EE1.9040603@FreeBSD.org> <485F5582.5040101@FreeBSD.org> <20080623084308.GA51236@wep4017.physik.uni-wuerzburg.de> <485F6585.2040307@FreeBSD.org> MIME-Version: 1.0 In-Reply-To: <485F6585.2040307@FreeBSD.org> Organization: Universitaet Wuerzburg User-Agent: Mutt/1.5.18 (2008-05-17) X-MIMETrack: Itemize by SMTP Server on domino1/uni-wuerzburg(Release 8.0.1HF110 | April 11, 2008) at 06/23/2008 02:26:37 PM, Serialize by Router on domino1/uni-wuerzburg(Release 8.0.1HF110 | April 11, 2008) at 06/23/2008 02:26:38 PM, Serialize complete at 06/23/2008 02:26:38 PM Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-Virus-Scanned: by amavisd-new at uni-wuerzburg.de Subject: Re: Issues with portmaster X-BeenThere: freebsd-ports@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Porting software to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 23 Jun 2008 12:26:40 -0000 On Mon, Jun 23, 2008 at 10:57:41AM +0200, Alex Dupre wrote: > Alexey Shuvaev ha scritto: >> It seems I don't understand something here. Can someone explain why >> jdk ports need to set BUILD_DEPENDS on diablo-jdk15 unconditionally? > > (nearly) every JDK port needs an already usable/installed JDK to > bootstrap the compilation. This is the reason of the BUILD_DEPENDS on > javac that you cannot remove. But the port providing the javac binary ^^^^^^^^^^^^^ > could not be the diablo-jdk. > Mmmm... why not??? In a nutshell, from the user point of view the reason to set BUILD_DEPENDS is to ensure that some port (java here) is installed prior to build. However, if the port checks against installed java in a more complicated manner than BUILD_DEPENDS mechanism can provide, I see no reason to set BUILD_DEPENDS to something just for its own sake. And from the build cluster point of view, the port will be built in a clean environment, so port will not detect any installed java and will set BUILD_DEPENDS *conditionally* (.if !defiend(BOOTSTRAPJDKDIR)). I have a feeling that the way BUILD_DEPENDS is set now is overkill, and one can put it under .if !defined(BOOTSTRAPJDKDIR) without any functional change. Of course, the Right Way To Do This would be to set the whole correct BUILD_DEPENDS line based on detected java. Maybe this is even not so complicated. Or I miss something? Just 0.02$, Alexey.