From owner-freebsd-current@FreeBSD.ORG Sat Nov 19 13:49:23 2005 Return-Path: X-Original-To: freebsd-current@freebsd.org Delivered-To: freebsd-current@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 0ECB316A41F for ; Sat, 19 Nov 2005 13:49:23 +0000 (GMT) (envelope-from rodrigc@crodrigues.org) Received: from sccrmhc13.comcast.net (sccrmhc13.comcast.net [204.127.202.64]) by mx1.FreeBSD.org (Postfix) with ESMTP id B0EBB43D6A for ; Sat, 19 Nov 2005 13:49:16 +0000 (GMT) (envelope-from rodrigc@crodrigues.org) Received: from c-66-30-114-245.hsd1.ma.comcast.net ([66.30.114.245]) by comcast.net (sccrmhc13) with ESMTP id <200511191348550130039qnhe>; Sat, 19 Nov 2005 13:49:05 +0000 Received: from c-66-30-114-245.hsd1.ma.comcast.net (localhost [127.0.0.1]) by c-66-30-114-245.hsd1.ma.comcast.net (8.13.4/8.13.1) with ESMTP id jAJDmt3q017570; Sat, 19 Nov 2005 08:48:56 -0500 (EST) (envelope-from rodrigc@c-66-30-114-245.hsd1.ma.comcast.net) Received: (from rodrigc@localhost) by c-66-30-114-245.hsd1.ma.comcast.net (8.13.4/8.13.1/Submit) id jAJDmtXq017569; Sat, 19 Nov 2005 08:48:55 -0500 (EST) (envelope-from rodrigc) Date: Sat, 19 Nov 2005 08:48:55 -0500 From: Craig Rodrigues To: Rainer Hurling Message-ID: <20051119134855.GA17536@crodrigues.org> References: <437E1477.7030902@gwdg.de> <20051118190448.GA6870@crodrigues.org> <437E542C.5070602@gwdg.de> <20051118224317.GA8018@crodrigues.org> <437EEBBF.5040601@gwdg.de> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <437EEBBF.5040601@gwdg.de> User-Agent: Mutt/1.4.2.1i Cc: freebsd-current@freebsd.org Subject: Re: mount_msdosfs and longnames X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 19 Nov 2005 13:49:23 -0000 On Sat, Nov 19, 2005 at 10:09:19AM +0100, Rainer Hurling wrote: > ... sorry for the late answer but I have to sleep some hours. > > I checked out version 1.36 of > /usr/src/sbin/mount_msdosfs/mount_msdosfs.c and build/install new system. > > I am not a developer. What have I to do instead of building/installing > the whole system when I only want to change a single file? It depends on the file. To just rebuilt mount_msdosfs, you can do: cd /usr/src/sbin/mount_msdosfs make make install > Now the good news: With mounting version 1.36 all FAT32 Filenames are OK > again :-) Can you try the following patch, rebuild your kernel, and try both old *and* new mount_msdosfs programs? Index: msdosfs_vfsops.c =================================================================== RCS file: /home/ncvs/src/sys/fs/msdosfs/msdosfs_vfsops.c,v retrieving revision 1.148 diff -u -u -r1.148 msdosfs_vfsops.c --- msdosfs_vfsops.c 18 Nov 2005 22:34:31 -0000 1.148 +++ msdosfs_vfsops.c 19 Nov 2005 13:41:36 -0000 @@ -81,7 +81,7 @@ "from", "export", "uid", "gid", "mask", "dirmask", - "shortname", "shortnames", "longname", "longnames", "win95", + "shortname", "shortnames", "longname", "longnames", "nowin95", "win95", "kiconv", "cs_win", "cs_dos", "cs_local", NULL }; @@ -172,11 +172,10 @@ vfs_flagopt(mp->mnt_optnew, "kiconv", &pmp->pm_flags, MSDOSFSMNT_KICONV); - /* XXX: Can't use flagopt due to negative option */ - if (!vfs_getopt(mp->mnt_optnew, "win95", NULL, NULL)) - pmp->pm_flags &= ~MSDOSFSMNT_NOWIN95; - else + if (vfs_getopt(mp->mnt_optnew, "nowin95", NULL, NULL) == 0) pmp->pm_flags |= MSDOSFSMNT_NOWIN95; + else + pmp->pm_flags &= ~MSDOSFSMNT_NOWIN95; if (pmp->pm_flags & MSDOSFSMNT_NOWIN95) pmp->pm_flags |= MSDOSFSMNT_SHORTNAME; -- Craig Rodrigues rodrigc@crodrigues.org