From owner-freebsd-bugs@FreeBSD.ORG Tue Sep 7 18:57:52 2010 Return-Path: Delivered-To: freebsd-bugs@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 52BE910656D0; Tue, 7 Sep 2010 18:57:52 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from cyrus.watson.org (cyrus.watson.org [65.122.17.42]) by mx1.freebsd.org (Postfix) with ESMTP id 1FF468FC08; Tue, 7 Sep 2010 18:57:52 +0000 (UTC) Received: from bigwig.baldwin.cx (66.111.2.69.static.nyinternet.net [66.111.2.69]) by cyrus.watson.org (Postfix) with ESMTPSA id B84B446B91; Tue, 7 Sep 2010 14:57:51 -0400 (EDT) Received: from jhbbsd.localnet (smtp.hudson-trading.com [209.249.190.9]) by bigwig.baldwin.cx (Postfix) with ESMTPSA id DE61C8A04E; Tue, 7 Sep 2010 14:57:50 -0400 (EDT) From: John Baldwin To: Alexander Best Date: Tue, 7 Sep 2010 14:00:44 -0400 User-Agent: KMail/1.13.5 (FreeBSD/7.3-CBSD-20100819; KDE/4.4.5; amd64; ; ) References: <201009071145.o87BjwoX080145@freefall.freebsd.org> <201009070915.18394.jhb@freebsd.org> <20100907140116.GA70520@freebsd.org> In-Reply-To: <20100907140116.GA70520@freebsd.org> MIME-Version: 1.0 Content-Type: Text/Plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Message-Id: <201009071400.44940.jhb@freebsd.org> X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.0.1 (bigwig.baldwin.cx); Tue, 07 Sep 2010 14:57:50 -0400 (EDT) X-Virus-Scanned: clamav-milter 0.95.1 at bigwig.baldwin.cx X-Virus-Status: Clean X-Spam-Status: No, score=-2.6 required=4.2 tests=AWL,BAYES_00 autolearn=ham version=3.2.5 X-Spam-Checker-Version: SpamAssassin 3.2.5 (2008-06-10) on bigwig.baldwin.cx Cc: freebsd-bugs@freebsd.org Subject: Re: kern/150199: [build] kernel doesn't compile with SYSVMSG and any of COMPAT_FREEBSD[456] but no COMPAT_FREEBSD7 X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 07 Sep 2010 18:57:52 -0000 On Tuesday, September 07, 2010 10:01:16 am Alexander Best wrote: > On Tue Sep 7 10, John Baldwin wrote: > > On Tuesday, September 07, 2010 7:45:58 am arundel@freebsd.org wrote: > > > Synopsis: [build] kernel doesn't compile with SYSVMSG and any of COMPAT_FREEBSD[456] but no COMPAT_FREEBSD7 > > > > > > Responsible-Changed-From-To: freebsd-bugs->jhb > > > Responsible-Changed-By: arundel > > > Responsible-Changed-When: Tue Sep 7 11:40:48 UTC 2010 > > > Responsible-Changed-Why: > > > John might have an opinion on this PR, since he added the '20090624' entry to > > > /usr/src/UPDATING which deals with the COMPAT_FREEBSD[4-7] options. > > > > Not a bug: > > > > 20090624: > > The ABI of various structures related to the SYSV IPC API have been > > changed. As a result, the COMPAT_FREEBSD[456] and COMPAT_43 kernel > > options now all require COMPAT_FREEBSD7. Bump __FreeBSD_version to > > 800100. > > wouldn't something like the following make sense? > > .if !defined(COMPAT_FREEBSD7) > . if defined(COMPAT_43) | defined(COMPAT_FREEBSD4) | defined(COMPAT_FREEBSD5) | defined(COMPAT_FREEBSD6) > COMPAT_FREEBSD7 = true > . endif > .endif > > cheers. > alex The problem is in sysproto.h and init_sysent.c and other files that are autogenerated by makesyscalls.sh as they only support tagging system calls with a single compat version. You could fix the headers by just making the compat stuff non-conditional, but init_sysent.c is not that easy. -- John Baldwin