From owner-svn-src-all@freebsd.org Wed Mar 13 00:14:27 2019 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 74C3115445F7; Wed, 13 Mar 2019 00:14:27 +0000 (UTC) (envelope-from araujobsdport@gmail.com) Received: from mail-lf1-x129.google.com (mail-lf1-x129.google.com [IPv6:2a00:1450:4864:20::129]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id DB2148D576; Wed, 13 Mar 2019 00:14:26 +0000 (UTC) (envelope-from araujobsdport@gmail.com) Received: by mail-lf1-x129.google.com with SMTP id y18so132333lfe.1; Tue, 12 Mar 2019 17:14:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:reply-to:from:date:message-id :subject:to:cc; bh=YSxCtBCFfWyv5wrLLjJhRhZksgaAdA6+hCo5Seh4rco=; b=EJKQUJeuU5Vj8fLuAJ+Hk0fvxjKOjgBE2QC9rSkoRPQAQoPvPDFMUxD9T0Psd8pVRv tdOtT2e8WWCKdsgsEheEOQO59glmcmp5GRqFvZ+sLPTzqvmDenO3BpqWyDxJsrYGsx3+ h21hCgrxAr2ohaUumfaQdYznapX/FAWwFUeQ5rrhDYgRhawKGvkUFKFylzsyGa+pxWSx 6nBOxsq2aLD5NJe8IO0/dNFEYZqSq7pmjs1sPlThYVyasAOHe6rb20AUFSZ4WNZq1f4H Vv3Aez4b+5989uBUIvOQKdCVYNxszmsfqGGvpQ33Pk3d6zI4N1wXfGMOFGnD7mcvbKjZ UtrQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:reply-to :from:date:message-id:subject:to:cc; bh=YSxCtBCFfWyv5wrLLjJhRhZksgaAdA6+hCo5Seh4rco=; b=k29mEEpYRGtSc3KoYal1O7olcc1nZwYGct5kVeOHSEinbAA4oUjqp1khUCiLr1zqT+ XBksDPtf2oHX7SJsSqwV/6hQgR4NNJWq2G63m5rGqCj5m1ypZxlWW7Zts7jNpKBiWr7U RkVaN5qisKC2QGiaFd70upEYJDnDjLtHqQX7aasAUTXdtc20HD+3Pw1dMbG1MVNEt4NL AdpKeOOyA4JRB1h3chdHJN1p8KCdOQBJywfFr/f2dklfrrgRD70Pb815E2r1+CIr9I4W evaZso4rj5sOQ8amKjbW3+AduJ34a74/xcx57RrVqLCXuXkd4D6FhnzGjXrFYbaOdW1S Lz0Q== X-Gm-Message-State: APjAAAXBpr0jlHPLkEI1lAuQTRnnRW4n/fjsbOr7SIGCRZeMkG9l7GPK +K086Ravd1lGADTZNTuuAuKX8YG10BXu/1dM1bu1vA== X-Google-Smtp-Source: APXvYqx57ynJWjlZaK99ZsdSMGxnaWDZfOnZlhMV1liL72hhs6Po+2KenhSkXY10AhSUTM3fNJebJGlDH1n4o4LD8VQ= X-Received: by 2002:ac2:43c3:: with SMTP id u3mr7493127lfl.69.1552436064620; Tue, 12 Mar 2019 17:14:24 -0700 (PDT) MIME-Version: 1.0 References: <201903120515.x2C5Fbtw013485@gndrsh.dnsmgr.net> <201903120525.x2C5PH7X013552@gndrsh.dnsmgr.net> In-Reply-To: Reply-To: araujo@freebsd.org From: Marcelo Araujo Date: Wed, 13 Mar 2019 08:14:13 +0800 Message-ID: Subject: Re: svn commit: r345050 - head/bin/date To: Warner Losh Cc: John Baldwin , "Rodney W. Grimes" , Warner Losh , src-committers , svn-src-all , svn-src-head X-Rspamd-Queue-Id: DB2148D576 X-Spamd-Bar: ------ Authentication-Results: mx1.freebsd.org X-Spamd-Result: default: False [-6.94 / 15.00]; NEURAL_HAM_MEDIUM(-1.00)[-0.999,0]; NEURAL_HAM_SHORT(-0.94)[-0.940,0]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; REPLY(-4.00)[] Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.29 X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 13 Mar 2019 00:14:27 -0000 On Wed, Mar 13, 2019, 12:57 AM Warner Losh > > On Tue, Mar 12, 2019, 9:43 AM John Baldwin wrote: > >> On 3/11/19 10:43 PM, Warner Losh wrote: >> > On Mon, Mar 11, 2019 at 11:25 PM Rodney W. Grimes < >> freebsd@gndrsh.dnsmgr.net> >> > wrote: >> > >> >>>> Author: imp >> >>>> Date: Tue Mar 12 04:49:59 2019 >> >>>> New Revision: 345050 >> >>>> URL: https://svnweb.freebsd.org/changeset/base/345050 >> >>>> >> >>>> Log: >> >>>> Remove now useless -d and -t flags. >> >>>> >> >>>> These were used to set dst flag and minutes west of UTC >> >>>> respectively. These are obsolete and have been removed form the >> >>>> kernel. These existed primarily to faithfully emulate early >> >>>> Unix ABIs that have been removed from FreeBSD. >> >>>> >> >>>> Reviewed by: jbh@, brooks@ >> >> Nits: jhb@ and I see he did comment in the review, but he did not >> >> accept it as a reviewew at the top. >> >> >> > >> > This is why I think just the reference to the differential revision is >> > perfectly fine. Why duplicate data? Others complained I hadn't included >> it. >> > He commented, we discussed it on irc (though most of it was about how to >> > use arc better), etc. I thought it warranted it. So please don't >> nitpick. >> > This level is really annoying and frustrating. Does this really help us >> > produce a better product? >> >> To be fair, we have been pretty consistent that 'Reviewed by' in the >> commit >> means 'Accepted' in phab. I probably would have ended up accepting this >> anyway and just didn't click the box, so it's ok. However, we have had >> folks in the past who were tagged in the past and gave feedback, but >> didn't >> approve of the change, but were listed as 'Reviewed by' hence the current >> practice. >> > > But we talked about it outside phab, which to my mind puts it under the > old rules. And it's not Rod's job to police this detail. It would be up to > you to hassle me if I misinterpreted that extra communication wrong. > > Warner > First of all, I would like to apologize to anyone that might get offended with what I will write, but I can't miss this opportunity! In the past 2 years or so, almost everyday there is a new drama, always something nonsense, always one or another nosy individual looking after other people efforts. Is it what we want for FreeBSD? I have started to question myself where we as community will end up. Is there anybody else concerned? Or perhaps I'm the drama queen and overseeing the situation. We should change freefall message to: "don't make drama, make code!" Best, >