Date: Tue, 4 Sep 2012 17:41:17 +0100 From: Chris Rees <utisoft@gmail.com> To: Florian Smeets <flo@smeets.im> Cc: svn-ports-head@freebsd.org, Doug Barton <dougb@freebsd.org>, bugmeister@freebsd.org, svn-ports-all@freebsd.org, ports-committers@freebsd.org, Shaun Amott <shaun@freebsd.org>, Alex Kozlov <ak@freebsd.org> Subject: Re: svn commit: r303626 - head/www/xpi-firebug Message-ID: <CADLo839kD4onjvzD3FQQRsN3h-F9VEATLPuHMLP=HH6oH-LvKg@mail.gmail.com> In-Reply-To: <50462CCA.5060306@smeets.im> References: <201209032233.q83MXSa2053725@svn.freebsd.org> <50453146.2080707@smeets.im> <504537D2.5050608@FreeBSD.org> <50454279.4020309@smeets.im> <50457770.4060402@FreeBSD.org> <20120904041502.GA70861@ravenloft.kiev.ua> <CADLo838vy-%2BjvWD6ONN0KXOMFDBV=ZB-34k9ZJx7hiJs2kM83w@mail.gmail.com> <20120904161424.GA28248@ravenloft.kiev.ua> <50462CCA.5060306@smeets.im>
next in thread | previous in thread | raw e-mail | index | archive | help
On 4 September 2012 17:31, Florian Smeets <flo@smeets.im> wrote: > On 04.09.12 18:14, Alex Kozlov wrote: >> On Tue, Sep 04, 2012 at 12:32:44PM +0100, Chris Rees wrote: >>> On 4 Sep 2012 05:15, "Alex Kozlov" <ak@freebsd.org> wrote: >>>> On Mon, Sep 03, 2012 at 08:37:20PM -0700, Doug Barton wrote: >>>>> On 09/03/2012 16:51, Florian Smeets wrote: >>>>>> So I reread the complete thread (r301039 and followups) again, the >>>>>> only problem there seems to be is pchecker complaining, >>>>> It's a problem for anything that uses 'while read ...' to process >>>>> those files, including portmaster. >>>> I think it breaks all parsers that assume that distinfo is a text file >>>> (have EoL on every line including last). >>>> >>>>> If you have the list of files with this problem and aren't interested >>>>> in fixing them, pass the list along and I'll do it. >>>> I plan to fix all occurrences of this in ports tree once every few months, >>>> but if you wish to fix it now, here is a list: >>>> audio/pianobar/distinfo >>>> devel/pecl-libevent/distinfo >>>> www/xpi-firebug/distinfo >>>> www/xpi-showip/distinfo >>>> www/trac-accountmanager/distinfo >>>> mail/meta1/distinfo >>>> net/istgt/distinfo >>>> sysutils/fusefs-rar2fs/distinfo >>> Is this a diff/patch bug? >>> Perhaps it could be fixed as well... or could its behaviour be thought of >>> as correct? >> I tried many times but could not find the culprit. But I also suspect patch. >> > > No i don't think so, it is already in the diff you download from GNATS. > I suspect it is a bug in getpatch, or one of the functions it calls, in > query-pr.cgi. If you look at the patch in the PR with edit-pr (vi or > vim) and use :set list you will see that the newline is there. This is > why I emailed Shaun, so let's wait what he has to say. > > BTW this does not only affect distinfo, it's always the last file of the > patch, so there are a lot of patch-* files which have a missing newline > at the end. You're quite right. # pkg install gpatch .... [crees@pegasus]/--/workspace/ports/pcvs% svn co $ports/head/chinese/ydict && cd ydict [crees@pegasus]/--/workspace/ports/pcvs/ydict% curl 'http://www.freebsd.org/cgi/query-pr.cgi?pr=ports%2F171324&getpatch=1' | gpatch [crees@pegasus]/--/workspace/ports/pcvs/ydict% curl 'http://www.freebsd.org/cgi/query-pr.cgi?pr=ports%2F171324&getpatch=1' | gpatch % Total % Received % Xferd Average Speed Time Time Time Current Dload Upload Total Spent Left Speed 100 1016 100 1016 0 0 485 0 0:00:02 0:00:02 --:--:-- 539 patching file Makefile patching file distinfo patch unexpectedly ends in middle of line gpatch: **** malformed patch at line 28: so later versions of patch complain about it, rather than patching. The bug is with query-pr.cgi it appears.... We'll never get that fixed, given that gnats3 has been removed from the ports tree. I'll put a patch together if clusteradm/bugmeisters were prepared to have a go-- I could revive the old port skel for it. Any takers? Or shall this just remain unfixed? Chris
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CADLo839kD4onjvzD3FQQRsN3h-F9VEATLPuHMLP=HH6oH-LvKg>